You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by radarwave <gi...@git.apache.org> on 2016/03/28 16:56:13 UTC
[GitHub] incubator-hawq pull request: HAWQ-587. Set GUC 'default_hash_table...
GitHub user radarwave opened a pull request:
https://github.com/apache/incubator-hawq/pull/521
HAWQ-587. Set GUC 'default_hash_table_bucket_number' value dynamically
When doing 'hawq init master/cluster', we will check command option '--default_hash_table_bucket_number' first, if it was not given by user, then we use the value defined in 'hawq-site.xml'.
If no option given and not defined in 'hawq-site.xml', we will calculate a number out for 'default_hash_table_bucket_number' base on segment number and the up limit value 'hawq_rm_nvseg_perquery_limit'.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radarwave/incubator-hawq HAWQ-587
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/521.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #521
----
commit 878026d3d58e44772244b68f37592fbbc9aebdda
Author: rlei <rl...@pivotal.io>
Date: 2016-03-28T10:18:56Z
HAWQ-587. Set GUC 'default_hash_table_bucket_number' value dynamically
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-587. Set GUC 'default_hash_table...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave closed the pull request at:
https://github.com/apache/incubator-hawq/pull/521
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-587. Set GUC 'default_hash_table...
Posted by denalex <gi...@git.apache.org>.
Github user denalex commented on the pull request:
https://github.com/apache/incubator-hawq/pull/521#issuecomment-202498394
The logic looks good, great that you reused the calculation code, so we can guarantee the same value is calculated by Ambari and HAWQ.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-587. Set GUC 'default_hash_table...
Posted by yaoj2 <gi...@git.apache.org>.
Github user yaoj2 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/521#issuecomment-202667565
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-587. Set GUC 'default_hash_table...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the pull request:
https://github.com/apache/incubator-hawq/pull/521#issuecomment-202431165
Some related changes:
1. Do not set GUC 'hawq_rm_nvseg_perquery_perseg_limit' any more since the default value is good enough.
2. Remove option ''--vsegment-number" since we do not need it any more.
3. Add new option "--default_hash_table_bucket_number" to let user define GUC 'default_hash_table_bucket_number'.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-587. Set GUC 'default_hash_table...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the pull request:
https://github.com/apache/incubator-hawq/pull/521#issuecomment-202430166
@denalex, please help to review this, since it can solve conflict with Ambari.
If Ambari already set 'default_hash_table_bucket_number' in hawq-site.xml, then hawq init will just use that value.
Ambari also can give option '--default_hash_table_bucket_number' to 'hawq init master/cluster' command to specify the value.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---