You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/20 10:18:40 UTC

[GitHub] [pulsar] AnonHxy opened a new pull request, #16144: [fix][broker]Fix removing replica clusters on topic-policies not take effect

AnonHxy opened a new pull request, #16144:
URL: https://github.com/apache/pulsar/pull/16144

   ### Motivation
   
   
   * Fix `org.apache.pulsar.client.admin.Topics#removeReplicationClusters` not taking effect:  Because we have used `HierarchyTopicPolicies` to save topic-level policies,  so we shoud  removing `policies.getReplicationClusters() != null`.
   
   ### Modifications
   
   * Removing  `policies.getReplicationClusters() != null` when topic-level policies updating
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added UT `org.apache.pulsar.broker.service.ReplicatorTopicPoliciesTest#testRemoveReplicationClusters`
   
   
   ### Documentation
   
     
   - [x] `doc-not-needed` 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] AnonHxy commented on pull request #16144: [fix][broker]Fix removing replica clusters on topic-policies not take effect

Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #16144:
URL: https://github.com/apache/pulsar/pull/16144#issuecomment-1161219947

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Jason918 commented on pull request #16144: [fix][broker]Fix removing replica clusters on topic-policies not take effect

Posted by GitBox <gi...@apache.org>.
Jason918 commented on PR #16144:
URL: https://github.com/apache/pulsar/pull/16144#issuecomment-1160369873

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] AnonHxy commented on pull request #16144: [fix][broker]Fix removing replica clusters on topic-policies not take effect

Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #16144:
URL: https://github.com/apache/pulsar/pull/16144#issuecomment-1171870068

   @gaozhangmin  PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #16144: [fix][broker]Fix removing replica clusters on topic-policies not take effect

Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #16144:
URL: https://github.com/apache/pulsar/pull/16144


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] AnonHxy commented on pull request #16144: [fix][broker]Fix removing replica clusters on topic-policies not take effect

Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #16144:
URL: https://github.com/apache/pulsar/pull/16144#issuecomment-1161194780

   Also modify the namespace-policy and topic-policy initialization order. PTAL @Jason918 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] AnonHxy commented on pull request #16144: [fix][broker]Fix removing replica clusters on topic-policies not take effect

Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #16144:
URL: https://github.com/apache/pulsar/pull/16144#issuecomment-1165144707

   @Technoboy- @codelipenghui PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org