You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Ahmet Arslan (Created) (JIRA)" <ji...@apache.org> on 2012/01/25 14:20:40 UTC
[jira] [Created] (SOLR-3060) add highlighter support to
SurroundQParserPlugin
add highlighter support to SurroundQParserPlugin
-------------------------------------------------
Key: SOLR-3060
URL: https://issues.apache.org/jira/browse/SOLR-3060
Project: Solr
Issue Type: Improvement
Components: search
Affects Versions: 4.0
Reporter: Ahmet Arslan
Priority: Minor
Fix For: 4.0
Highlighter does not recognize SrndQuery family.
http://search-lucene.com/m/FuDsU1sTjgM
http://search-lucene.com/m/wD8c11gNTb61
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3060) add highlighter support to
SurroundQParserPlugin
Posted by "abhimanyu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199527#comment-13199527 ]
abhimanyu commented on SOLR-3060:
---------------------------------
thanks for ur support in resolving this problem,however i was facing another problem with highlighter while using it with numeric field types as it does not return the highlighted results. i have posted it in jira issues but have not found any help regarding it , any suggestion would be of great help.
> add highlighter support to SurroundQParserPlugin
> -------------------------------------------------
>
> Key: SOLR-3060
> URL: https://issues.apache.org/jira/browse/SOLR-3060
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 4.0
> Reporter: Ahmet Arslan
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-3060.patch, SOLR-3060.patch
>
>
> Highlighter does not recognize SrndQuery family.
> http://search-lucene.com/m/FuDsU1sTjgM
> http://search-lucene.com/m/wD8c11gNTb61
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3060) add highlighter support to
SurroundQParserPlugin
Posted by "Hoss Man (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197168#comment-13197168 ]
Hoss Man commented on SOLR-3060:
--------------------------------
This patch is straight forward and includes tests (thank you so much for the tests).
The meat of the change is that getHighlightQuery is overridden to attempt query rewriting, which gives me two concerns...
1) at a minimum i'm pretty sure super.getHighlightQuery still needs to be called.
2) is this rewriting of hte query done in the SurroundQParser going to cause any problems or unexpected behavior in conjunction with the highlighter component logic that already decides if/when to rewrite the query?
If the crux of the problem is that HighlightComponent rewrites the query automatically _except_ when using the phrase highlighter with the multi-term option (assuming i'm reading the code correctly) then shouldn't that code path of the highlighter be modified to do something sane with any type of Query object? ... why isn't it responsible for calling rewrite on any sub-query of a type it doesn't understanding?
(Highlighting is one of the areas of Lucene/Solr that frequently makes my head hurt, so forgive me if these are silly questions)
> add highlighter support to SurroundQParserPlugin
> -------------------------------------------------
>
> Key: SOLR-3060
> URL: https://issues.apache.org/jira/browse/SOLR-3060
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 4.0
> Reporter: Ahmet Arslan
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-3060.patch, SOLR-3060.patch
>
>
> Highlighter does not recognize SrndQuery family.
> http://search-lucene.com/m/FuDsU1sTjgM
> http://search-lucene.com/m/wD8c11gNTb61
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3060) add highlighter support to
SurroundQParserPlugin
Posted by "Shalu Singh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220696#comment-13220696 ]
Shalu Singh commented on SOLR-3060:
-----------------------------------
Hi Ahmet, i am trying to include the SOLR-2703.patch into SOLR 3.5 downloaded from SVN branches to provide Surround parser. But it is not working after including the 2703 SOLR patch. Do u know how to apply the same??
> add highlighter support to SurroundQParserPlugin
> -------------------------------------------------
>
> Key: SOLR-3060
> URL: https://issues.apache.org/jira/browse/SOLR-3060
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 4.0
> Reporter: Ahmet Arslan
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-3060.patch, SOLR-3060.patch
>
>
> Highlighter does not recognize SrndQuery family.
> http://search-lucene.com/m/FuDsU1sTjgM
> http://search-lucene.com/m/wD8c11gNTb61
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3060) add highlighter support to
SurroundQParserPlugin
Posted by "Shalu Singh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197727#comment-13197727 ]
Shalu Singh commented on SOLR-3060:
-----------------------------------
Thanks for your support and quick reply and resolving my problem. It is giving desirable results now.
> add highlighter support to SurroundQParserPlugin
> -------------------------------------------------
>
> Key: SOLR-3060
> URL: https://issues.apache.org/jira/browse/SOLR-3060
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 4.0
> Reporter: Ahmet Arslan
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-3060.patch, SOLR-3060.patch
>
>
> Highlighter does not recognize SrndQuery family.
> http://search-lucene.com/m/FuDsU1sTjgM
> http://search-lucene.com/m/wD8c11gNTb61
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3060) add highlighter support to
SurroundQParserPlugin
Posted by "Ahmet Arslan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ahmet Arslan updated SOLR-3060:
-------------------------------
Attachment: SOLR-3060.patch
o.a.s.search.QParser#getHighlightQuery() method is overridden.
> add highlighter support to SurroundQParserPlugin
> -------------------------------------------------
>
> Key: SOLR-3060
> URL: https://issues.apache.org/jira/browse/SOLR-3060
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 4.0
> Reporter: Ahmet Arslan
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-3060.patch
>
>
> Highlighter does not recognize SrndQuery family.
> http://search-lucene.com/m/FuDsU1sTjgM
> http://search-lucene.com/m/wD8c11gNTb61
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3060) add highlighter support to
SurroundQParserPlugin
Posted by "abhimanyu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195968#comment-13195968 ]
abhimanyu commented on SOLR-3060:
---------------------------------
thanks for your patch but i am not able to apply this patch ,i am not using any svn version , please tell me how to apply this patch.
> add highlighter support to SurroundQParserPlugin
> -------------------------------------------------
>
> Key: SOLR-3060
> URL: https://issues.apache.org/jira/browse/SOLR-3060
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 4.0
> Reporter: Ahmet Arslan
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-3060.patch, SOLR-3060.patch
>
>
> Highlighter does not recognize SrndQuery family.
> http://search-lucene.com/m/FuDsU1sTjgM
> http://search-lucene.com/m/wD8c11gNTb61
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3060) add highlighter support to
SurroundQParserPlugin
Posted by "Shalu Singh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195976#comment-13195976 ]
Shalu Singh commented on SOLR-3060:
-----------------------------------
i am facing the same problem. Donno how to apply the SOLR-3060.patch
> add highlighter support to SurroundQParserPlugin
> -------------------------------------------------
>
> Key: SOLR-3060
> URL: https://issues.apache.org/jira/browse/SOLR-3060
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 4.0
> Reporter: Ahmet Arslan
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-3060.patch, SOLR-3060.patch
>
>
> Highlighter does not recognize SrndQuery family.
> http://search-lucene.com/m/FuDsU1sTjgM
> http://search-lucene.com/m/wD8c11gNTb61
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3060) add highlighter support to
SurroundQParserPlugin
Posted by "Ahmet Arslan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195979#comment-13195979 ]
Ahmet Arslan commented on SOLR-3060:
------------------------------------
The following commands should do it.
* svn checkout http://svn.apache.org/repos/asf/lucene/dev/trunk
* cd trunk
* curl -O https://issues.apache.org/jira/secure/attachment/12511843/SOLR-3060.patch
* patch -p0 -i SOLR-3060.patch
* cd solr
* ant clean dist
Use newly created trunk/solr/dist/apache-solr-4.0-SNAPSHOT.war file.
> add highlighter support to SurroundQParserPlugin
> -------------------------------------------------
>
> Key: SOLR-3060
> URL: https://issues.apache.org/jira/browse/SOLR-3060
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 4.0
> Reporter: Ahmet Arslan
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-3060.patch, SOLR-3060.patch
>
>
> Highlighter does not recognize SrndQuery family.
> http://search-lucene.com/m/FuDsU1sTjgM
> http://search-lucene.com/m/wD8c11gNTb61
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3060) add highlighter support to
SurroundQParserPlugin
Posted by "abhimanyu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195969#comment-13195969 ]
abhimanyu commented on SOLR-3060:
---------------------------------
i am using patch -p0 -i SOLR-3060.patch --dry-run as mentioned in the docs , but error is coming that not a correct p option,plz tell me how to use ur patch
> add highlighter support to SurroundQParserPlugin
> -------------------------------------------------
>
> Key: SOLR-3060
> URL: https://issues.apache.org/jira/browse/SOLR-3060
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 4.0
> Reporter: Ahmet Arslan
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-3060.patch, SOLR-3060.patch
>
>
> Highlighter does not recognize SrndQuery family.
> http://search-lucene.com/m/FuDsU1sTjgM
> http://search-lucene.com/m/wD8c11gNTb61
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Issue Comment Edited] (SOLR-3060) add highlighter support
to SurroundQParserPlugin
Posted by "abhimanyu (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199527#comment-13199527 ]
abhimanyu edited comment on SOLR-3060 at 2/3/12 5:24 AM:
---------------------------------------------------------
thanks for ur support in resolving this problem,however i was facing another problem with highlighter while using it with numeric field types as it does not return the highlighted results. i have posted it in jira issues but have not found any help regarding it , any suggestion would be of great help.
Please follow the link
https://issues.apache.org/jira/browse/SOLR-3050
was (Author: manyutomar):
thanks for ur support in resolving this problem,however i was facing another problem with highlighter while using it with numeric field types as it does not return the highlighted results. i have posted it in jira issues but have not found any help regarding it , any suggestion would be of great help.
> add highlighter support to SurroundQParserPlugin
> -------------------------------------------------
>
> Key: SOLR-3060
> URL: https://issues.apache.org/jira/browse/SOLR-3060
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 4.0
> Reporter: Ahmet Arslan
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-3060.patch, SOLR-3060.patch
>
>
> Highlighter does not recognize SrndQuery family.
> http://search-lucene.com/m/FuDsU1sTjgM
> http://search-lucene.com/m/wD8c11gNTb61
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3060) add highlighter support to
SurroundQParserPlugin
Posted by "Ahmet Arslan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ahmet Arslan updated SOLR-3060:
-------------------------------
Attachment: SOLR-3060.patch
some test added
> add highlighter support to SurroundQParserPlugin
> -------------------------------------------------
>
> Key: SOLR-3060
> URL: https://issues.apache.org/jira/browse/SOLR-3060
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 4.0
> Reporter: Ahmet Arslan
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-3060.patch, SOLR-3060.patch
>
>
> Highlighter does not recognize SrndQuery family.
> http://search-lucene.com/m/FuDsU1sTjgM
> http://search-lucene.com/m/wD8c11gNTb61
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org