You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Steven Schlansker <ss...@opentable.com> on 2017/02/09 00:45:54 UTC
KIP-121 [VOTE]: Add KStream peek method
Hi everyone,
Thank you for constructive feedback on KIP-121, KStream.peek(ForeachAction<K, V>) ;
it seems like it is time to call a vote which I hope will pass easily :)
https://cwiki.apache.org/confluence/display/KAFKA/KIP-121%3A+Add+KStream+peek+method
I believe the PR attached is already in good shape to consider merging:
https://github.com/apache/kafka/pull/2493
Thanks!
Steven
Re: KIP-121 [VOTE]: Add KStream peek method
Posted by Bill Bejeck <bb...@gmail.com>.
+1
On Wed, Feb 8, 2017 at 7:51 PM, Gwen Shapira <gw...@confluent.io> wrote:
> +1 (binding)
>
> On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker
> <ss...@opentable.com> wrote:
> > Hi everyone,
> >
> > Thank you for constructive feedback on KIP-121,
> KStream.peek(ForeachAction<K, V>) ;
> > it seems like it is time to call a vote which I hope will pass easily :)
> >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 121%3A+Add+KStream+peek+method
> >
> > I believe the PR attached is already in good shape to consider merging:
> >
> > https://github.com/apache/kafka/pull/2493
> >
> > Thanks!
> > Steven
> >
>
>
>
> --
> Gwen Shapira
> Product Manager | Confluent
> 650.450.2760 | @gwenshap
> Follow us: Twitter | blog
>
Re: KIP-121 [VOTE]: Add KStream peek method
Posted by Guozhang Wang <wa...@gmail.com>.
＋1 （binding）
On Thu, Feb 9, 2017 at 7:44 AM, Eno Thereska <en...@gmail.com> wrote:
> +1
>
> Thanks
> Eno
> > On 9 Feb 2017, at 11:04, Damian Guy <da...@gmail.com> wrote:
> >
> > +1
> >
> > On Thu, 9 Feb 2017 at 10:26 Michael Noll <mi...@confluent.io> wrote:
> >
> >> +1 (non-binding)
> >>
> >> And thanks again for suggesting and driving this, Steven! :-)
> >>
> >> Best,
> >> Michael
> >>
> >>
> >>
> >>
> >> On Thu, Feb 9, 2017 at 6:06 AM, Matthias J. Sax <ma...@confluent.io>
> >> wrote:
> >>
> >>> +1
> >>>
> >>> On 2/8/17 4:51 PM, Gwen Shapira wrote:
> >>>> +1 (binding)
> >>>>
> >>>> On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker
> >>>> <ss...@opentable.com> wrote:
> >>>>> Hi everyone,
> >>>>>
> >>>>> Thank you for constructive feedback on KIP-121,
> >>> KStream.peek(ForeachAction<K, V>) ;
> >>>>> it seems like it is time to call a vote which I hope will pass easily
> >> :)
> >>>>>
> >>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> >>> 121%3A+Add+KStream+peek+method
> >>>>>
> >>>>> I believe the PR attached is already in good shape to consider
> >> merging:
> >>>>>
> >>>>> https://github.com/apache/kafka/pull/2493
> >>>>>
> >>>>> Thanks!
> >>>>> Steven
> >>>>>
> >>>>
> >>>>
> >>>>
> >>>
> >>>
> >>
>
>
--
-- Guozhang
Re: KIP-121 [VOTE]: Add KStream peek method
Posted by Eno Thereska <en...@gmail.com>.
+1
Thanks
Eno
> On 9 Feb 2017, at 11:04, Damian Guy <da...@gmail.com> wrote:
>
> +1
>
> On Thu, 9 Feb 2017 at 10:26 Michael Noll <mi...@confluent.io> wrote:
>
>> +1 (non-binding)
>>
>> And thanks again for suggesting and driving this, Steven! :-)
>>
>> Best,
>> Michael
>>
>>
>>
>>
>> On Thu, Feb 9, 2017 at 6:06 AM, Matthias J. Sax <ma...@confluent.io>
>> wrote:
>>
>>> +1
>>>
>>> On 2/8/17 4:51 PM, Gwen Shapira wrote:
>>>> +1 (binding)
>>>>
>>>> On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker
>>>> <ss...@opentable.com> wrote:
>>>>> Hi everyone,
>>>>>
>>>>> Thank you for constructive feedback on KIP-121,
>>> KStream.peek(ForeachAction<K, V>) ;
>>>>> it seems like it is time to call a vote which I hope will pass easily
>> :)
>>>>>
>>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
>>> 121%3A+Add+KStream+peek+method
>>>>>
>>>>> I believe the PR attached is already in good shape to consider
>> merging:
>>>>>
>>>>> https://github.com/apache/kafka/pull/2493
>>>>>
>>>>> Thanks!
>>>>> Steven
>>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>
Re: KIP-121 [VOTE]: Add KStream peek method
Posted by Damian Guy <da...@gmail.com>.
+1
On Thu, 9 Feb 2017 at 10:26 Michael Noll <mi...@confluent.io> wrote:
> +1 (non-binding)
>
> And thanks again for suggesting and driving this, Steven! :-)
>
> Best,
> Michael
>
>
>
>
> On Thu, Feb 9, 2017 at 6:06 AM, Matthias J. Sax <ma...@confluent.io>
> wrote:
>
> > +1
> >
> > On 2/8/17 4:51 PM, Gwen Shapira wrote:
> > > +1 (binding)
> > >
> > > On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker
> > > <ss...@opentable.com> wrote:
> > >> Hi everyone,
> > >>
> > >> Thank you for constructive feedback on KIP-121,
> > KStream.peek(ForeachAction<K, V>) ;
> > >> it seems like it is time to call a vote which I hope will pass easily
> :)
> > >>
> > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > 121%3A+Add+KStream+peek+method
> > >>
> > >> I believe the PR attached is already in good shape to consider
> merging:
> > >>
> > >> https://github.com/apache/kafka/pull/2493
> > >>
> > >> Thanks!
> > >> Steven
> > >>
> > >
> > >
> > >
> >
> >
>
Re: KIP-121 [VOTE]: Add KStream peek method
Posted by Michael Noll <mi...@confluent.io>.
+1 (non-binding)
And thanks again for suggesting and driving this, Steven! :-)
Best,
Michael
On Thu, Feb 9, 2017 at 6:06 AM, Matthias J. Sax <ma...@confluent.io>
wrote:
> +1
>
> On 2/8/17 4:51 PM, Gwen Shapira wrote:
> > +1 (binding)
> >
> > On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker
> > <ss...@opentable.com> wrote:
> >> Hi everyone,
> >>
> >> Thank you for constructive feedback on KIP-121,
> KStream.peek(ForeachAction<K, V>) ;
> >> it seems like it is time to call a vote which I hope will pass easily :)
> >>
> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 121%3A+Add+KStream+peek+method
> >>
> >> I believe the PR attached is already in good shape to consider merging:
> >>
> >> https://github.com/apache/kafka/pull/2493
> >>
> >> Thanks!
> >> Steven
> >>
> >
> >
> >
>
>
Re: KIP-121 [VOTE]: Add KStream peek method
Posted by Eno Thereska <en...@gmail.com>.
KIP is accepted, discussion now moves to PR.
Thanks
Eno
On Wed, Feb 15, 2017 at 12:28 PM, Steven Schlansker <
sschlansker@opentable.com> wrote:
> Oops, sorry, a number of votes were sent only to -dev and not to
> -user and so I missed those in the email I just sent. The actual count is
> more like +8
>
> > On Feb 15, 2017, at 12:24 PM, Steven Schlansker <
> sschlansker@opentable.com> wrote:
> >
> > From reading the bylaws it's not entirely clear who closes the vote or
> how they
> > decide when to do so.
> >
> > Given a week has passed and assuming Jay's and Matthias's votes are
> binding,
> > we have a result of +4 votes with no other votes cast.
> >
> > I'll update the KIP with the result shortly :)
> >
> >> On Feb 14, 2017, at 3:36 PM, Zakee <kz...@netzero.net> wrote:
> >>
> >> +1
> >>
> >> -Zakee
> >>> On Feb 14, 2017, at 1:56 PM, Jay Kreps <ja...@confluent.io> wrote:
> >>>
> >>> +1
> >>>
> >>> Nice improvement.
> >>>
> >>> -Jay
> >>>
> >>> On Tue, Feb 14, 2017 at 1:22 PM, Steven Schlansker <
> >>> sschlansker@opentable.com> wrote:
> >>>
> >>>> Hi, it looks like I have 2 of the 3 minimum votes, can a third voter
> >>>> please consider this KIP?
> >>>> Thanks.
> >>>>
> >>>> (PS - new revision on GitHub PR with hopefully the last round of
> >>>> improvements)
> >>>>
> >>>>> On Feb 8, 2017, at 9:06 PM, Matthias J. Sax <ma...@confluent.io>
> >>>> wrote:
> >>>>>
> >>>>> +1
> >>>>>
> >>>>> On 2/8/17 4:51 PM, Gwen Shapira wrote:
> >>>>>> +1 (binding)
> >>>>>>
> >>>>>> On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker
> >>>>>> <ss...@opentable.com> wrote:
> >>>>>>> Hi everyone,
> >>>>>>>
> >>>>>>> Thank you for constructive feedback on KIP-121,
> >>>> KStream.peek(ForeachAction<K, V>) ;
> >>>>>>> it seems like it is time to call a vote which I hope will pass
> easily
> >>>> :)
> >>>>>>>
> >>>>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> >>>> 121%3A+Add+KStream+peek+method
> >>>>>>>
> >>>>>>> I believe the PR attached is already in good shape to consider
> merging:
> >>>>>>>
> >>>>>>> https://github.com/apache/kafka/pull/2493
> >>>>>>>
> >>>>>>> Thanks!
> >>>>>>> Steven
> >>>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>
> >>>>
> >>>>
> >>
> >> ____________________________________________________________
> >> Police Urge Your City Residents to Carry This at All Times
> >> Smart Trends
> >> http://thirdpartyoffers.netzero.net/TGL3231/
> 58a39467a3d7f146654a1st03duc
> >
>
>
Re: KIP-121 [VOTE]: Add KStream peek method
Posted by Eno Thereska <en...@gmail.com>.
KIP is accepted, discussion now moves to PR.
Thanks
Eno
On Wed, Feb 15, 2017 at 12:28 PM, Steven Schlansker <
sschlansker@opentable.com> wrote:
> Oops, sorry, a number of votes were sent only to -dev and not to
> -user and so I missed those in the email I just sent. The actual count is
> more like +8
>
> > On Feb 15, 2017, at 12:24 PM, Steven Schlansker <
> sschlansker@opentable.com> wrote:
> >
> > From reading the bylaws it's not entirely clear who closes the vote or
> how they
> > decide when to do so.
> >
> > Given a week has passed and assuming Jay's and Matthias's votes are
> binding,
> > we have a result of +4 votes with no other votes cast.
> >
> > I'll update the KIP with the result shortly :)
> >
> >> On Feb 14, 2017, at 3:36 PM, Zakee <kz...@netzero.net> wrote:
> >>
> >> +1
> >>
> >> -Zakee
> >>> On Feb 14, 2017, at 1:56 PM, Jay Kreps <ja...@confluent.io> wrote:
> >>>
> >>> +1
> >>>
> >>> Nice improvement.
> >>>
> >>> -Jay
> >>>
> >>> On Tue, Feb 14, 2017 at 1:22 PM, Steven Schlansker <
> >>> sschlansker@opentable.com> wrote:
> >>>
> >>>> Hi, it looks like I have 2 of the 3 minimum votes, can a third voter
> >>>> please consider this KIP?
> >>>> Thanks.
> >>>>
> >>>> (PS - new revision on GitHub PR with hopefully the last round of
> >>>> improvements)
> >>>>
> >>>>> On Feb 8, 2017, at 9:06 PM, Matthias J. Sax <ma...@confluent.io>
> >>>> wrote:
> >>>>>
> >>>>> +1
> >>>>>
> >>>>> On 2/8/17 4:51 PM, Gwen Shapira wrote:
> >>>>>> +1 (binding)
> >>>>>>
> >>>>>> On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker
> >>>>>> <ss...@opentable.com> wrote:
> >>>>>>> Hi everyone,
> >>>>>>>
> >>>>>>> Thank you for constructive feedback on KIP-121,
> >>>> KStream.peek(ForeachAction<K, V>) ;
> >>>>>>> it seems like it is time to call a vote which I hope will pass
> easily
> >>>> :)
> >>>>>>>
> >>>>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> >>>> 121%3A+Add+KStream+peek+method
> >>>>>>>
> >>>>>>> I believe the PR attached is already in good shape to consider
> merging:
> >>>>>>>
> >>>>>>> https://github.com/apache/kafka/pull/2493
> >>>>>>>
> >>>>>>> Thanks!
> >>>>>>> Steven
> >>>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>
> >>>>
> >>>>
> >>
> >> ____________________________________________________________
> >> Police Urge Your City Residents to Carry This at All Times
> >> Smart Trends
> >> http://thirdpartyoffers.netzero.net/TGL3231/
> 58a39467a3d7f146654a1st03duc
> >
>
>
Re: KIP-121 [VOTE]: Add KStream peek method
Posted by Steven Schlansker <ss...@opentable.com>.
Oops, sorry, a number of votes were sent only to -dev and not to
-user and so I missed those in the email I just sent. The actual count is more like +8
> On Feb 15, 2017, at 12:24 PM, Steven Schlansker <ss...@opentable.com> wrote:
>
> From reading the bylaws it's not entirely clear who closes the vote or how they
> decide when to do so.
>
> Given a week has passed and assuming Jay's and Matthias's votes are binding,
> we have a result of +4 votes with no other votes cast.
>
> I'll update the KIP with the result shortly :)
>
>> On Feb 14, 2017, at 3:36 PM, Zakee <kz...@netzero.net> wrote:
>>
>> +1
>>
>> -Zakee
>>> On Feb 14, 2017, at 1:56 PM, Jay Kreps <ja...@confluent.io> wrote:
>>>
>>> +1
>>>
>>> Nice improvement.
>>>
>>> -Jay
>>>
>>> On Tue, Feb 14, 2017 at 1:22 PM, Steven Schlansker <
>>> sschlansker@opentable.com> wrote:
>>>
>>>> Hi, it looks like I have 2 of the 3 minimum votes, can a third voter
>>>> please consider this KIP?
>>>> Thanks.
>>>>
>>>> (PS - new revision on GitHub PR with hopefully the last round of
>>>> improvements)
>>>>
>>>>> On Feb 8, 2017, at 9:06 PM, Matthias J. Sax <ma...@confluent.io>
>>>> wrote:
>>>>>
>>>>> +1
>>>>>
>>>>> On 2/8/17 4:51 PM, Gwen Shapira wrote:
>>>>>> +1 (binding)
>>>>>>
>>>>>> On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker
>>>>>> <ss...@opentable.com> wrote:
>>>>>>> Hi everyone,
>>>>>>>
>>>>>>> Thank you for constructive feedback on KIP-121,
>>>> KStream.peek(ForeachAction<K, V>) ;
>>>>>>> it seems like it is time to call a vote which I hope will pass easily
>>>> :)
>>>>>>>
>>>>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
>>>> 121%3A+Add+KStream+peek+method
>>>>>>>
>>>>>>> I believe the PR attached is already in good shape to consider merging:
>>>>>>>
>>>>>>> https://github.com/apache/kafka/pull/2493
>>>>>>>
>>>>>>> Thanks!
>>>>>>> Steven
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>
>> ____________________________________________________________
>> Police Urge Your City Residents to Carry This at All Times
>> Smart Trends
>> http://thirdpartyoffers.netzero.net/TGL3231/58a39467a3d7f146654a1st03duc
>
Re: KIP-121 [VOTE]: Add KStream peek method
Posted by Guozhang Wang <wa...@gmail.com>.
Thanks Ismael.
The KIP voting has been accepted with 4 binding +1, and 5 non-binding +1s.
Guozhang
On Wed, Feb 15, 2017 at 12:47 PM, Ismael Juma <is...@juma.me.uk> wrote:
> +1 (binding) from me.
>
> For the record, there were 4 binding +1s (Gwen, Guozhang, Jay and myself).
>
> Ismael
>
> On Wed, Feb 15, 2017 at 8:24 PM, Steven Schlansker <
> sschlansker@opentable.com> wrote:
>
> > From reading the bylaws it's not entirely clear who closes the vote or
> how
> > they
> > decide when to do so.
> >
> > Given a week has passed and assuming Jay's and Matthias's votes are
> > binding,
> > we have a result of +4 votes with no other votes cast.
> >
> > I'll update the KIP with the result shortly :)
> >
> > > On Feb 14, 2017, at 3:36 PM, Zakee <kz...@netzero.net> wrote:
> > >
> > > +1
> > >
> > > -Zakee
> > >> On Feb 14, 2017, at 1:56 PM, Jay Kreps <ja...@confluent.io> wrote:
> > >>
> > >> +1
> > >>
> > >> Nice improvement.
> > >>
> > >> -Jay
> > >>
> > >> On Tue, Feb 14, 2017 at 1:22 PM, Steven Schlansker <
> > >> sschlansker@opentable.com> wrote:
> > >>
> > >>> Hi, it looks like I have 2 of the 3 minimum votes, can a third voter
> > >>> please consider this KIP?
> > >>> Thanks.
> > >>>
> > >>> (PS - new revision on GitHub PR with hopefully the last round of
> > >>> improvements)
> > >>>
> > >>>> On Feb 8, 2017, at 9:06 PM, Matthias J. Sax <ma...@confluent.io>
> > >>> wrote:
> > >>>>
> > >>>> +1
> > >>>>
> > >>>> On 2/8/17 4:51 PM, Gwen Shapira wrote:
> > >>>>> +1 (binding)
> > >>>>>
> > >>>>> On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker
> > >>>>> <ss...@opentable.com> wrote:
> > >>>>>> Hi everyone,
> > >>>>>>
> > >>>>>> Thank you for constructive feedback on KIP-121,
> > >>> KStream.peek(ForeachAction<K, V>) ;
> > >>>>>> it seems like it is time to call a vote which I hope will pass
> > easily
> > >>> :)
> > >>>>>>
> > >>>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > >>> 121%3A+Add+KStream+peek+method
> > >>>>>>
> > >>>>>> I believe the PR attached is already in good shape to consider
> > merging:
> > >>>>>>
> > >>>>>> https://github.com/apache/kafka/pull/2493
> > >>>>>>
> > >>>>>> Thanks!
> > >>>>>> Steven
> > >>>>>>
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>
> > >>>
> > >>>
> > >
> > > ____________________________________________________________
> > > Police Urge Your City Residents to Carry This at All Times
> > > Smart Trends
> > > http://thirdpartyoffers.netzero.net/TGL3231/
> 58a39467a3d7f146654a1st03duc
> >
> >
>
--
-- Guozhang
Re: KIP-121 [VOTE]: Add KStream peek method
Posted by Ismael Juma <is...@juma.me.uk>.
+1 (binding) from me.
For the record, there were 4 binding +1s (Gwen, Guozhang, Jay and myself).
Ismael
On Wed, Feb 15, 2017 at 8:24 PM, Steven Schlansker <
sschlansker@opentable.com> wrote:
> From reading the bylaws it's not entirely clear who closes the vote or how
> they
> decide when to do so.
>
> Given a week has passed and assuming Jay's and Matthias's votes are
> binding,
> we have a result of +4 votes with no other votes cast.
>
> I'll update the KIP with the result shortly :)
>
> > On Feb 14, 2017, at 3:36 PM, Zakee <kz...@netzero.net> wrote:
> >
> > +1
> >
> > -Zakee
> >> On Feb 14, 2017, at 1:56 PM, Jay Kreps <ja...@confluent.io> wrote:
> >>
> >> +1
> >>
> >> Nice improvement.
> >>
> >> -Jay
> >>
> >> On Tue, Feb 14, 2017 at 1:22 PM, Steven Schlansker <
> >> sschlansker@opentable.com> wrote:
> >>
> >>> Hi, it looks like I have 2 of the 3 minimum votes, can a third voter
> >>> please consider this KIP?
> >>> Thanks.
> >>>
> >>> (PS - new revision on GitHub PR with hopefully the last round of
> >>> improvements)
> >>>
> >>>> On Feb 8, 2017, at 9:06 PM, Matthias J. Sax <ma...@confluent.io>
> >>> wrote:
> >>>>
> >>>> +1
> >>>>
> >>>> On 2/8/17 4:51 PM, Gwen Shapira wrote:
> >>>>> +1 (binding)
> >>>>>
> >>>>> On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker
> >>>>> <ss...@opentable.com> wrote:
> >>>>>> Hi everyone,
> >>>>>>
> >>>>>> Thank you for constructive feedback on KIP-121,
> >>> KStream.peek(ForeachAction<K, V>) ;
> >>>>>> it seems like it is time to call a vote which I hope will pass
> easily
> >>> :)
> >>>>>>
> >>>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> >>> 121%3A+Add+KStream+peek+method
> >>>>>>
> >>>>>> I believe the PR attached is already in good shape to consider
> merging:
> >>>>>>
> >>>>>> https://github.com/apache/kafka/pull/2493
> >>>>>>
> >>>>>> Thanks!
> >>>>>> Steven
> >>>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>
> >>>
> >>>
> >
> > ____________________________________________________________
> > Police Urge Your City Residents to Carry This at All Times
> > Smart Trends
> > http://thirdpartyoffers.netzero.net/TGL3231/58a39467a3d7f146654a1st03duc
>
>
Re: KIP-121 [VOTE]: Add KStream peek method
Posted by Ismael Juma <is...@juma.me.uk>.
+1 (binding) from me.
For the record, there were 4 binding +1s (Gwen, Guozhang, Jay and myself).
Ismael
On Wed, Feb 15, 2017 at 8:24 PM, Steven Schlansker <
sschlansker@opentable.com> wrote:
> From reading the bylaws it's not entirely clear who closes the vote or how
> they
> decide when to do so.
>
> Given a week has passed and assuming Jay's and Matthias's votes are
> binding,
> we have a result of +4 votes with no other votes cast.
>
> I'll update the KIP with the result shortly :)
>
> > On Feb 14, 2017, at 3:36 PM, Zakee <kz...@netzero.net> wrote:
> >
> > +1
> >
> > -Zakee
> >> On Feb 14, 2017, at 1:56 PM, Jay Kreps <ja...@confluent.io> wrote:
> >>
> >> +1
> >>
> >> Nice improvement.
> >>
> >> -Jay
> >>
> >> On Tue, Feb 14, 2017 at 1:22 PM, Steven Schlansker <
> >> sschlansker@opentable.com> wrote:
> >>
> >>> Hi, it looks like I have 2 of the 3 minimum votes, can a third voter
> >>> please consider this KIP?
> >>> Thanks.
> >>>
> >>> (PS - new revision on GitHub PR with hopefully the last round of
> >>> improvements)
> >>>
> >>>> On Feb 8, 2017, at 9:06 PM, Matthias J. Sax <ma...@confluent.io>
> >>> wrote:
> >>>>
> >>>> +1
> >>>>
> >>>> On 2/8/17 4:51 PM, Gwen Shapira wrote:
> >>>>> +1 (binding)
> >>>>>
> >>>>> On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker
> >>>>> <ss...@opentable.com> wrote:
> >>>>>> Hi everyone,
> >>>>>>
> >>>>>> Thank you for constructive feedback on KIP-121,
> >>> KStream.peek(ForeachAction<K, V>) ;
> >>>>>> it seems like it is time to call a vote which I hope will pass
> easily
> >>> :)
> >>>>>>
> >>>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> >>> 121%3A+Add+KStream+peek+method
> >>>>>>
> >>>>>> I believe the PR attached is already in good shape to consider
> merging:
> >>>>>>
> >>>>>> https://github.com/apache/kafka/pull/2493
> >>>>>>
> >>>>>> Thanks!
> >>>>>> Steven
> >>>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>
> >>>
> >>>
> >
> > ____________________________________________________________
> > Police Urge Your City Residents to Carry This at All Times
> > Smart Trends
> > http://thirdpartyoffers.netzero.net/TGL3231/58a39467a3d7f146654a1st03duc
>
>
Re: KIP-121 [VOTE]: Add KStream peek method
Posted by Steven Schlansker <ss...@opentable.com>.
Oops, sorry, a number of votes were sent only to -dev and not to
-user and so I missed those in the email I just sent. The actual count is more like +8
> On Feb 15, 2017, at 12:24 PM, Steven Schlansker <ss...@opentable.com> wrote:
>
> From reading the bylaws it's not entirely clear who closes the vote or how they
> decide when to do so.
>
> Given a week has passed and assuming Jay's and Matthias's votes are binding,
> we have a result of +4 votes with no other votes cast.
>
> I'll update the KIP with the result shortly :)
>
>> On Feb 14, 2017, at 3:36 PM, Zakee <kz...@netzero.net> wrote:
>>
>> +1
>>
>> -Zakee
>>> On Feb 14, 2017, at 1:56 PM, Jay Kreps <ja...@confluent.io> wrote:
>>>
>>> +1
>>>
>>> Nice improvement.
>>>
>>> -Jay
>>>
>>> On Tue, Feb 14, 2017 at 1:22 PM, Steven Schlansker <
>>> sschlansker@opentable.com> wrote:
>>>
>>>> Hi, it looks like I have 2 of the 3 minimum votes, can a third voter
>>>> please consider this KIP?
>>>> Thanks.
>>>>
>>>> (PS - new revision on GitHub PR with hopefully the last round of
>>>> improvements)
>>>>
>>>>> On Feb 8, 2017, at 9:06 PM, Matthias J. Sax <ma...@confluent.io>
>>>> wrote:
>>>>>
>>>>> +1
>>>>>
>>>>> On 2/8/17 4:51 PM, Gwen Shapira wrote:
>>>>>> +1 (binding)
>>>>>>
>>>>>> On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker
>>>>>> <ss...@opentable.com> wrote:
>>>>>>> Hi everyone,
>>>>>>>
>>>>>>> Thank you for constructive feedback on KIP-121,
>>>> KStream.peek(ForeachAction<K, V>) ;
>>>>>>> it seems like it is time to call a vote which I hope will pass easily
>>>> :)
>>>>>>>
>>>>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
>>>> 121%3A+Add+KStream+peek+method
>>>>>>>
>>>>>>> I believe the PR attached is already in good shape to consider merging:
>>>>>>>
>>>>>>> https://github.com/apache/kafka/pull/2493
>>>>>>>
>>>>>>> Thanks!
>>>>>>> Steven
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>
>> ____________________________________________________________
>> Police Urge Your City Residents to Carry This at All Times
>> Smart Trends
>> http://thirdpartyoffers.netzero.net/TGL3231/58a39467a3d7f146654a1st03duc
>
Re: KIP-121 [VOTE]: Add KStream peek method
Posted by Steven Schlansker <ss...@opentable.com>.
From reading the bylaws it's not entirely clear who closes the vote or how they
decide when to do so.
Given a week has passed and assuming Jay's and Matthias's votes are binding,
we have a result of +4 votes with no other votes cast.
I'll update the KIP with the result shortly :)
> On Feb 14, 2017, at 3:36 PM, Zakee <kz...@netzero.net> wrote:
>
> +1
>
> -Zakee
>> On Feb 14, 2017, at 1:56 PM, Jay Kreps <ja...@confluent.io> wrote:
>>
>> +1
>>
>> Nice improvement.
>>
>> -Jay
>>
>> On Tue, Feb 14, 2017 at 1:22 PM, Steven Schlansker <
>> sschlansker@opentable.com> wrote:
>>
>>> Hi, it looks like I have 2 of the 3 minimum votes, can a third voter
>>> please consider this KIP?
>>> Thanks.
>>>
>>> (PS - new revision on GitHub PR with hopefully the last round of
>>> improvements)
>>>
>>>> On Feb 8, 2017, at 9:06 PM, Matthias J. Sax <ma...@confluent.io>
>>> wrote:
>>>>
>>>> +1
>>>>
>>>> On 2/8/17 4:51 PM, Gwen Shapira wrote:
>>>>> +1 (binding)
>>>>>
>>>>> On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker
>>>>> <ss...@opentable.com> wrote:
>>>>>> Hi everyone,
>>>>>>
>>>>>> Thank you for constructive feedback on KIP-121,
>>> KStream.peek(ForeachAction<K, V>) ;
>>>>>> it seems like it is time to call a vote which I hope will pass easily
>>> :)
>>>>>>
>>>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
>>> 121%3A+Add+KStream+peek+method
>>>>>>
>>>>>> I believe the PR attached is already in good shape to consider merging:
>>>>>>
>>>>>> https://github.com/apache/kafka/pull/2493
>>>>>>
>>>>>> Thanks!
>>>>>> Steven
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>
> ____________________________________________________________
> Police Urge Your City Residents to Carry This at All Times
> Smart Trends
> http://thirdpartyoffers.netzero.net/TGL3231/58a39467a3d7f146654a1st03duc
Re: KIP-121 [VOTE]: Add KStream peek method
Posted by Steven Schlansker <ss...@opentable.com>.
From reading the bylaws it's not entirely clear who closes the vote or how they
decide when to do so.
Given a week has passed and assuming Jay's and Matthias's votes are binding,
we have a result of +4 votes with no other votes cast.
I'll update the KIP with the result shortly :)
> On Feb 14, 2017, at 3:36 PM, Zakee <kz...@netzero.net> wrote:
>
> +1
>
> -Zakee
>> On Feb 14, 2017, at 1:56 PM, Jay Kreps <ja...@confluent.io> wrote:
>>
>> +1
>>
>> Nice improvement.
>>
>> -Jay
>>
>> On Tue, Feb 14, 2017 at 1:22 PM, Steven Schlansker <
>> sschlansker@opentable.com> wrote:
>>
>>> Hi, it looks like I have 2 of the 3 minimum votes, can a third voter
>>> please consider this KIP?
>>> Thanks.
>>>
>>> (PS - new revision on GitHub PR with hopefully the last round of
>>> improvements)
>>>
>>>> On Feb 8, 2017, at 9:06 PM, Matthias J. Sax <ma...@confluent.io>
>>> wrote:
>>>>
>>>> +1
>>>>
>>>> On 2/8/17 4:51 PM, Gwen Shapira wrote:
>>>>> +1 (binding)
>>>>>
>>>>> On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker
>>>>> <ss...@opentable.com> wrote:
>>>>>> Hi everyone,
>>>>>>
>>>>>> Thank you for constructive feedback on KIP-121,
>>> KStream.peek(ForeachAction<K, V>) ;
>>>>>> it seems like it is time to call a vote which I hope will pass easily
>>> :)
>>>>>>
>>>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
>>> 121%3A+Add+KStream+peek+method
>>>>>>
>>>>>> I believe the PR attached is already in good shape to consider merging:
>>>>>>
>>>>>> https://github.com/apache/kafka/pull/2493
>>>>>>
>>>>>> Thanks!
>>>>>> Steven
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>
> ____________________________________________________________
> Police Urge Your City Residents to Carry This at All Times
> Smart Trends
> http://thirdpartyoffers.netzero.net/TGL3231/58a39467a3d7f146654a1st03duc
Re: KIP-121 [VOTE]: Add KStream peek method
Posted by Zakee <kz...@netzero.net>.
+1
-Zakee
> On Feb 14, 2017, at 1:56 PM, Jay Kreps <ja...@confluent.io> wrote:
>
> +1
>
> Nice improvement.
>
> -Jay
>
> On Tue, Feb 14, 2017 at 1:22 PM, Steven Schlansker <
> sschlansker@opentable.com> wrote:
>
>> Hi, it looks like I have 2 of the 3 minimum votes, can a third voter
>> please consider this KIP?
>> Thanks.
>>
>> (PS - new revision on GitHub PR with hopefully the last round of
>> improvements)
>>
>>> On Feb 8, 2017, at 9:06 PM, Matthias J. Sax <ma...@confluent.io>
>> wrote:
>>>
>>> +1
>>>
>>> On 2/8/17 4:51 PM, Gwen Shapira wrote:
>>>> +1 (binding)
>>>>
>>>> On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker
>>>> <ss...@opentable.com> wrote:
>>>>> Hi everyone,
>>>>>
>>>>> Thank you for constructive feedback on KIP-121,
>> KStream.peek(ForeachAction<K, V>) ;
>>>>> it seems like it is time to call a vote which I hope will pass easily
>> :)
>>>>>
>>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
>> 121%3A+Add+KStream+peek+method
>>>>>
>>>>> I believe the PR attached is already in good shape to consider merging:
>>>>>
>>>>> https://github.com/apache/kafka/pull/2493
>>>>>
>>>>> Thanks!
>>>>> Steven
>>>>>
>>>>
>>>>
>>>>
>>>
>>
>>
____________________________________________________________
Police Urge Your City Residents to Carry This at All Times
Smart Trends
http://thirdpartyoffers.netzero.net/TGL3231/58a39467a3d7f146654a1st03duc
Re: KIP-121 [VOTE]: Add KStream peek method
Posted by Zakee <kz...@netzero.net>.
+1
-Zakee
> On Feb 14, 2017, at 1:56 PM, Jay Kreps <ja...@confluent.io> wrote:
>
> +1
>
> Nice improvement.
>
> -Jay
>
> On Tue, Feb 14, 2017 at 1:22 PM, Steven Schlansker <
> sschlansker@opentable.com> wrote:
>
>> Hi, it looks like I have 2 of the 3 minimum votes, can a third voter
>> please consider this KIP?
>> Thanks.
>>
>> (PS - new revision on GitHub PR with hopefully the last round of
>> improvements)
>>
>>> On Feb 8, 2017, at 9:06 PM, Matthias J. Sax <ma...@confluent.io>
>> wrote:
>>>
>>> +1
>>>
>>> On 2/8/17 4:51 PM, Gwen Shapira wrote:
>>>> +1 (binding)
>>>>
>>>> On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker
>>>> <ss...@opentable.com> wrote:
>>>>> Hi everyone,
>>>>>
>>>>> Thank you for constructive feedback on KIP-121,
>> KStream.peek(ForeachAction<K, V>) ;
>>>>> it seems like it is time to call a vote which I hope will pass easily
>> :)
>>>>>
>>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
>> 121%3A+Add+KStream+peek+method
>>>>>
>>>>> I believe the PR attached is already in good shape to consider merging:
>>>>>
>>>>> https://github.com/apache/kafka/pull/2493
>>>>>
>>>>> Thanks!
>>>>> Steven
>>>>>
>>>>
>>>>
>>>>
>>>
>>
>>
____________________________________________________________
Police Urge Your City Residents to Carry This at All Times
Smart Trends
http://thirdpartyoffers.netzero.net/TGL3231/58a39467a3d7f146654a1st03duc
Re: KIP-121 [VOTE]: Add KStream peek method
Posted by Jay Kreps <ja...@confluent.io>.
+1
Nice improvement.
-Jay
On Tue, Feb 14, 2017 at 1:22 PM, Steven Schlansker <
sschlansker@opentable.com> wrote:
> Hi, it looks like I have 2 of the 3 minimum votes, can a third voter
> please consider this KIP?
> Thanks.
>
> (PS - new revision on GitHub PR with hopefully the last round of
> improvements)
>
> > On Feb 8, 2017, at 9:06 PM, Matthias J. Sax <ma...@confluent.io>
> wrote:
> >
> > +1
> >
> > On 2/8/17 4:51 PM, Gwen Shapira wrote:
> >> +1 (binding)
> >>
> >> On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker
> >> <ss...@opentable.com> wrote:
> >>> Hi everyone,
> >>>
> >>> Thank you for constructive feedback on KIP-121,
> KStream.peek(ForeachAction<K, V>) ;
> >>> it seems like it is time to call a vote which I hope will pass easily
> :)
> >>>
> >>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 121%3A+Add+KStream+peek+method
> >>>
> >>> I believe the PR attached is already in good shape to consider merging:
> >>>
> >>> https://github.com/apache/kafka/pull/2493
> >>>
> >>> Thanks!
> >>> Steven
> >>>
> >>
> >>
> >>
> >
>
>
Re: KIP-121 [VOTE]: Add KStream peek method
Posted by Jay Kreps <ja...@confluent.io>.
+1
Nice improvement.
-Jay
On Tue, Feb 14, 2017 at 1:22 PM, Steven Schlansker <
sschlansker@opentable.com> wrote:
> Hi, it looks like I have 2 of the 3 minimum votes, can a third voter
> please consider this KIP?
> Thanks.
>
> (PS - new revision on GitHub PR with hopefully the last round of
> improvements)
>
> > On Feb 8, 2017, at 9:06 PM, Matthias J. Sax <ma...@confluent.io>
> wrote:
> >
> > +1
> >
> > On 2/8/17 4:51 PM, Gwen Shapira wrote:
> >> +1 (binding)
> >>
> >> On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker
> >> <ss...@opentable.com> wrote:
> >>> Hi everyone,
> >>>
> >>> Thank you for constructive feedback on KIP-121,
> KStream.peek(ForeachAction<K, V>) ;
> >>> it seems like it is time to call a vote which I hope will pass easily
> :)
> >>>
> >>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 121%3A+Add+KStream+peek+method
> >>>
> >>> I believe the PR attached is already in good shape to consider merging:
> >>>
> >>> https://github.com/apache/kafka/pull/2493
> >>>
> >>> Thanks!
> >>> Steven
> >>>
> >>
> >>
> >>
> >
>
>
Re: KIP-121 [VOTE]: Add KStream peek method
Posted by Steven Schlansker <ss...@opentable.com>.
Hi, it looks like I have 2 of the 3 minimum votes, can a third voter please consider this KIP?
Thanks.
(PS - new revision on GitHub PR with hopefully the last round of improvements)
> On Feb 8, 2017, at 9:06 PM, Matthias J. Sax <ma...@confluent.io> wrote:
>
> +1
>
> On 2/8/17 4:51 PM, Gwen Shapira wrote:
>> +1 (binding)
>>
>> On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker
>> <ss...@opentable.com> wrote:
>>> Hi everyone,
>>>
>>> Thank you for constructive feedback on KIP-121, KStream.peek(ForeachAction<K, V>) ;
>>> it seems like it is time to call a vote which I hope will pass easily :)
>>>
>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-121%3A+Add+KStream+peek+method
>>>
>>> I believe the PR attached is already in good shape to consider merging:
>>>
>>> https://github.com/apache/kafka/pull/2493
>>>
>>> Thanks!
>>> Steven
>>>
>>
>>
>>
>
Re: KIP-121 [VOTE]: Add KStream peek method
Posted by Steven Schlansker <ss...@opentable.com>.
Hi, it looks like I have 2 of the 3 minimum votes, can a third voter please consider this KIP?
Thanks.
(PS - new revision on GitHub PR with hopefully the last round of improvements)
> On Feb 8, 2017, at 9:06 PM, Matthias J. Sax <ma...@confluent.io> wrote:
>
> +1
>
> On 2/8/17 4:51 PM, Gwen Shapira wrote:
>> +1 (binding)
>>
>> On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker
>> <ss...@opentable.com> wrote:
>>> Hi everyone,
>>>
>>> Thank you for constructive feedback on KIP-121, KStream.peek(ForeachAction<K, V>) ;
>>> it seems like it is time to call a vote which I hope will pass easily :)
>>>
>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-121%3A+Add+KStream+peek+method
>>>
>>> I believe the PR attached is already in good shape to consider merging:
>>>
>>> https://github.com/apache/kafka/pull/2493
>>>
>>> Thanks!
>>> Steven
>>>
>>
>>
>>
>
Re: KIP-121 [VOTE]: Add KStream peek method
Posted by "Matthias J. Sax" <ma...@confluent.io>.
+1
On 2/8/17 4:51 PM, Gwen Shapira wrote:
> +1 (binding)
>
> On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker
> <ss...@opentable.com> wrote:
>> Hi everyone,
>>
>> Thank you for constructive feedback on KIP-121, KStream.peek(ForeachAction<K, V>) ;
>> it seems like it is time to call a vote which I hope will pass easily :)
>>
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-121%3A+Add+KStream+peek+method
>>
>> I believe the PR attached is already in good shape to consider merging:
>>
>> https://github.com/apache/kafka/pull/2493
>>
>> Thanks!
>> Steven
>>
>
>
>
Re: KIP-121 [VOTE]: Add KStream peek method
Posted by "Matthias J. Sax" <ma...@confluent.io>.
+1
On 2/8/17 4:51 PM, Gwen Shapira wrote:
> +1 (binding)
>
> On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker
> <ss...@opentable.com> wrote:
>> Hi everyone,
>>
>> Thank you for constructive feedback on KIP-121, KStream.peek(ForeachAction<K, V>) ;
>> it seems like it is time to call a vote which I hope will pass easily :)
>>
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-121%3A+Add+KStream+peek+method
>>
>> I believe the PR attached is already in good shape to consider merging:
>>
>> https://github.com/apache/kafka/pull/2493
>>
>> Thanks!
>> Steven
>>
>
>
>
Re: KIP-121 [VOTE]: Add KStream peek method
Posted by Gwen Shapira <gw...@confluent.io>.
+1 (binding)
On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker
<ss...@opentable.com> wrote:
> Hi everyone,
>
> Thank you for constructive feedback on KIP-121, KStream.peek(ForeachAction<K, V>) ;
> it seems like it is time to call a vote which I hope will pass easily :)
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-121%3A+Add+KStream+peek+method
>
> I believe the PR attached is already in good shape to consider merging:
>
> https://github.com/apache/kafka/pull/2493
>
> Thanks!
> Steven
>
--
Gwen Shapira
Product Manager | Confluent
650.450.2760 | @gwenshap
Follow us: Twitter | blog
Re: KIP-121 [VOTE]: Add KStream peek method
Posted by Gwen Shapira <gw...@confluent.io>.
+1 (binding)
On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker
<ss...@opentable.com> wrote:
> Hi everyone,
>
> Thank you for constructive feedback on KIP-121, KStream.peek(ForeachAction<K, V>) ;
> it seems like it is time to call a vote which I hope will pass easily :)
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-121%3A+Add+KStream+peek+method
>
> I believe the PR attached is already in good shape to consider merging:
>
> https://github.com/apache/kafka/pull/2493
>
> Thanks!
> Steven
>
--
Gwen Shapira
Product Manager | Confluent
650.450.2760 | @gwenshap
Follow us: Twitter | blog