You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sangeeta Ravindran <sa...@gmail.com> on 2016/11/30 18:43:01 UTC
Re: Review Request 53103: Workflow Designer View: When logs are empty,
you see the spinner, instead of a message
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53103/
-----------------------------------------------------------
(Updated Nov. 30, 2016, 6:43 p.m.)
Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Juanjo Marron, Pallav Kulshreshtha, Venkat Ranganathan, and Yusaku Sako.
Changes
-------
Updated patch based on latest code
Bugs: AMBARI-18600
https://issues.apache.org/jira/browse/AMBARI-18600
Repository: ambari
Description
-------
In the workflow designer view instance, if there is no log available for the workflow, then the spinner is seen giving the impression that logs are still being retrieved. This happens for all the logs, viz. the job log, error log and audit log.
A message sould be displayed when there are no messages in the log.
The test failure for this patch is caused by an existing issue unrelated to this patch.
Failed to execute goal on project wfmanager: Could not resolve dependencies for project org.apache.ambari.contrib.views:wfmanager:jar:0.1.0.0-SNAPSHOT: Failure to find org.apache.ambari.contrib.views:ambari-views-commons:jar:2.0.0.0-SNAPSHOT in https://oss.sonatype.org/content/groups/staging was cached in the local repository, resolution will not be reattempted until the update interval of oss.sonatype.org has elapsed or updates are forced -> [Help 1]
Diffs (updated)
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js e403dc4
Diff: https://reviews.apache.org/r/53103/diff/
Testing
-------
Manual tests.
File Attachments
----------------
C:\Sangeeta\Work\BigData\Ambari\Jira Submissions\18600
https://reviews.apache.org/media/uploaded/files/2016/10/27/5b87e2e8-23e1-456c-ab5d-f157db437624__AMBARI-18600.patch
Thanks,
Sangeeta Ravindran
Re: Review Request 53103: Workflow Designer View: When logs are empty,
you see the spinner, instead of a message
Posted by Juanjo Marron <jm...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53103/#review157438
-----------------------------------------------------------
Ship it!
Ship It!
- Juanjo Marron
On Nov. 30, 2016, 6:43 p.m., Sangeeta Ravindran wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53103/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 6:43 p.m.)
>
>
> Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Juanjo Marron, Pallav Kulshreshtha, Venkat Ranganathan, and Yusaku Sako.
>
>
> Bugs: AMBARI-18600
> https://issues.apache.org/jira/browse/AMBARI-18600
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In the workflow designer view instance, if there is no log available for the workflow, then the spinner is seen giving the impression that logs are still being retrieved. This happens for all the logs, viz. the job log, error log and audit log.
>
> A message sould be displayed when there are no messages in the log.
>
> The test failure for this patch is caused by an existing issue unrelated to this patch.
>
> Failed to execute goal on project wfmanager: Could not resolve dependencies for project org.apache.ambari.contrib.views:wfmanager:jar:0.1.0.0-SNAPSHOT: Failure to find org.apache.ambari.contrib.views:ambari-views-commons:jar:2.0.0.0-SNAPSHOT in https://oss.sonatype.org/content/groups/staging was cached in the local repository, resolution will not be reattempted until the update interval of oss.sonatype.org has elapsed or updates are forced -> [Help 1]
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js e403dc4
>
> Diff: https://reviews.apache.org/r/53103/diff/
>
>
> Testing
> -------
>
> Manual tests.
>
>
> File Attachments
> ----------------
>
> C:\Sangeeta\Work\BigData\Ambari\Jira Submissions\18600
> https://reviews.apache.org/media/uploaded/files/2016/10/27/5b87e2e8-23e1-456c-ab5d-f157db437624__AMBARI-18600.patch
>
>
> Thanks,
>
> Sangeeta Ravindran
>
>