[GitHub] [spark] wangyum commented on a diff in pull request #37267: [SPARK-39851][SQL] Improve join stats estimation if one side can keep uniqueness

[GitBox <gi...@apache.org>]

wangyum commented on code in PR #37267:
URL: https://github.com/apache/spark/pull/37267#discussion_r928341584


##########
sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala:
##########
@@ -57,7 +57,7 @@ class StatisticsCollectionSuite extends StatisticsCollectionTestBase with Shared
       }
 
       assert(sizes.size === 1, s"number of Join nodes is wrong:\n ${df.queryExecution}")
-      assert(sizes.head === BigInt(128),
+      assert(sizes.head === BigInt(129),

Review Comment:
   Before this PR. It is 128 * 1 = 128, After this PR. It is 128 + 1 = 129. Please see:
   https://github.com/apache/spark/blob/082d49aa810957a2cd6b4f4c06919e59fecca3bd/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/SizeInBytesOnlyStatsPlanVisitor.scala#L133-L136



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org