You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mahout.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/11/02 09:03:00 UTC
[jira] [Work logged] (MAHOUT-2071) fix bin.xml and assembly to
allow for a binary apache-mahout-14.1.tar.gz release
[ https://issues.apache.org/jira/browse/MAHOUT-2071?focusedWorklogId=337675&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337675 ]
ASF GitHub Bot logged work on MAHOUT-2071:
------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Nov/19 09:02
Start Date: 02/Nov/19 09:02
Worklog Time Spent: 10m
Work Description: andrewpalumbo commented on pull request #382: [MAHOUT-2071] Fix binary and source releases
URL: https://github.com/apache/mahout/pull/382
### Purpose of PR:
Please give a short description of what this PR is for.
### Important ToDos
Please mark each with an "x"
- [X ] A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/mahout/]
- [X ] Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number.
- [N/A ] Created unit tests where appropriate
- [ ?--check this ] Added licenses correct on newly added files
- [ X] Assigned JIRA to self
- [N/A ] Added documentation in scala docs/java docs, and to website
- [ X] Successfully built and ran all unit tests, verified that all tests pass locally.
If all of these things aren't complete, but you still feel it is
appropriate to open a PR, please add [WIP] after MAHOUT-XXXX before the
descriptions- e.g. "MAHOUT-XXXX [WIP] Description of Change"
Does this change break earlier versions?
Is this the beginning of a larger project for which a feature branch should be made?
Added a `distribution` module and src/bin assemblies in that tree. The `distribution` module must be last in order for the reactor build. The `mahout-release` profile will include the `distribution` module in the build.
Distributions will be build in the `distribution/target` directory.
Building a release Candidate with `mvn clean package install -DskipTests -Papache-Release,mahout-release release:prepare release:perform` (note the error `-Papache-Release` gives):
https://repository.apache.org/content/repositories/snapshots/org/apache/mahout/distribution/14.2-SNAPSHOT/
which is odd because locally, I have:
```
colleenpalumbo ~ sandbox mahout mahout-14.1 2? $ l distribution/target/
apache-mahout-14.1-bin.tar.bz2 apache-mahout-14.1-bin.tar.bz2.asc
apache-mahout-14.1-bin.tar.gz apache-mahout-14.1-bin.tar.gz.asc
apache-mahout-14.1-src.tar.bz2 apache-mahout-14.1-src.tar.bz2.asc
apache-mahout-14.1-src.tar.gz apache-mahout-14.1-src.tar.gz.asc
archive-tmp/ distribution-14.1.pom
distribution-14.1.pom.asc maven-shared-archive-resources/
```
i.e names as e.g. `apache-mahout-14.1-bin.tar.bz2 `. these should be relatively easy fixes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 337675)
Remaining Estimate: 0h
Time Spent: 10m
> fix bin.xml and assembly to allow for a binary apache-mahout-14.1.tar.gz release
> --------------------------------------------------------------------------------
>
> Key: MAHOUT-2071
> URL: https://issues.apache.org/jira/browse/MAHOUT-2071
> Project: Mahout
> Issue Type: Task
> Affects Versions: 0.14.0
> Reporter: Andrew Palumbo
> Assignee: Andrew Palumbo
> Priority: Blocker
> Fix For: 14.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> the problem is theoretically solved ... we were overwriting the apache parent {{pom.xml}}'s[https://github.com/apache/mahout/blob/mahout-14.1/pom.xml#L21-L25|https://slack-redir.net/link?url=https%3A%2F%2Fgithub.com%2Fapache%2Fmahout%2Fblob%2Fmahout-14.1%2Fpom.xml%23L21-L25&v=3] {{apache-release}} profile in our own, ...i removed the {{apache-release}} profile from ours and added what was left to {{mahout-release}}.so i expect that it should be working now. the thing that was breaking everything (im gambling this whole theory on is that by overwriting the parent pom'sdeclaration of {{</mahout.skip.distribution>}}:
> <skipAssembly>${mahout.skip.distribution}</skipAssembly>
> [https://github.com/apache/mahout/blob/mahout-14.1/pom.xml#L512|https://slack-redir.net/link?url=https%3A%2F%2Fgithub.com%2Fapache%2Fmahout%2Fblob%2Fmahout-14.1%2Fpom.xml%23L512&v=3]
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)