[commons-compress] branch master updated: Allow BC break for internals of pack200 implementation when updating ASM from 3.2 to 7.0.

[gg...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git


The following commit(s) were added to refs/heads/master by this push:
     new 7a4e8ce  Allow BC break for internals of pack200 implementation when updating ASM from 3.2 to 7.0.
7a4e8ce is described below

commit 7a4e8ceab012573941efcc8efd18df639c1f001c
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Tue Aug 10 10:41:46 2021 -0400

    Allow BC break for internals of pack200 implementation when updating ASM
    from 3.2 to 7.0.
    
    Also update ASM to current 9.2.
---
 pom.xml                 | 17 ++++++++++++++++-
 src/changes/changes.xml |  9 +++++++--
 2 files changed, 23 insertions(+), 3 deletions(-)

diff --git a/pom.xml b/pom.xml
index ccf11b1..834fdb9 100644
--- a/pom.xml
+++ b/pom.xml
@@ -78,7 +78,7 @@ Brotli, Zstandard and ar, cpio, jar, tar, zip, dump, 7z, arj.
     <commons.jacoco.version>0.8.7</commons.jacoco.version>
     <commons.japicmp.version>0.15.3</commons.japicmp.version>
     <commons.javadoc.version>3.3.0</commons.javadoc.version>
-    <asm.version>7.0</asm.version>
+    <asm.version>9.2</asm.version>
   </properties>
 
   <issueManagement>
@@ -362,6 +362,21 @@ Brotli, Zstandard and ar, cpio, jar, tar, zip, dump, 7z, arj.
           <artifactId>maven-bundle-plugin</artifactId>
           <version>${commons.felix.version}</version>
         </plugin>
+        <plugin>
+          <groupId>com.github.siom79.japicmp</groupId>
+          <artifactId>japicmp-maven-plugin</artifactId>
+          <configuration>
+            <parameter>
+              <excludes>
+                <!-- Compress 1.21 -> 1.22 updates ASM from 3.2 to 9.2 for pack200 implementation. -->
+                <exclude>org.apache.commons.compress.harmony.pack200.Segment</exclude>
+                <exclude>org.apache.commons.compress.harmony.pack200.SegmentMethodVisitor</exclude>
+                <exclude>org.apache.commons.compress.harmony.pack200.SegmentAnnotationVisitor</exclude>
+                <exclude>org.apache.commons.compress.harmony.pack200.SegmentFieldVisitor</exclude>
+              </excludes>
+            </parameter>
+          </configuration>
+        </plugin>
       </plugins>
     </pluginManagement>
     <plugins>
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 529b262..7e19060 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -62,8 +62,13 @@ The <action> type attribute can be add,update,fix,remove.
       <action type="update" dev="ggregory" due-to="Dependabot">
         Bump zstd-jni from 1.5.0-2 to 1.5.0-4 #215.
       </action>
-      <action type="update" issue="COMPRESS-582" dev="ggregory" due-to="Dependabot">
-        Bump Pack200 packages from ASM 3.2 to 7.0 #216.
+      <action type="update" issue="COMPRESS-582" dev="ggregory" due-to=", Gary Gregory">
+        Bump Pack200 packages from ASM 3.2 to 9.2 #216. 
+        Breaks binary compatibility in the internals of the pack200 implementation:
+        - org.apache.commons.compress.harmony.pack200.Segment
+        - org.apache.commons.compress.harmony.pack200.SegmentMethodVisitor
+        - org.apache.commons.compress.harmony.pack200.SegmentAnnotationVisitor
+        - org.apache.commons.compress.harmony.pack200.SegmentFieldVisitor
       </action>
     </release>
     <release version="1.21" date="2021-07-12"