You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/03/12 18:16:02 UTC
[GitHub] [openwhisk] tysonnorris opened a new pull request #4859: kcf -
enable use of fieldref to inject action pod details to pod env
tysonnorris opened a new pull request #4859: kcf - enable use of fieldref to inject action pod details to pod env
URL: https://github.com/apache/openwhisk/pull/4859
<!--- Provide a concise summary of your changes in the Title -->
Enables optional use of https://kubernetes.io/docs/tasks/inject-data-application/environment-variable-expose-pod-information/#the-downward-api to inject pod details into the user action container.
This is useful for running logging sidecar containers, which tag logs with the container id, and may be useful for other things.
## Description
<!--- Provide a detailed description of your changes. -->
<!--- Include details of what problem you are solving and how your changes are tested. -->
Operators can optionally add config like:
```
field-ref-environment: {
"POD_NAMESPACE":"metadata.namespace",
"POD_NAME":"metadata.name",
"POD_UID": "metadata.uid"
}
```
To make certain specific pod spec details visible to the container env.
## Related issue and scope
<!--- Please include a link to a related issue if there is one. -->
- [ ] I opened an issue to propose and discuss this change (#????)
## My changes affect the following components
<!--- Select below all system components are affected by your change. -->
<!--- Enter an `x` in all applicable boxes. -->
- [ ] API
- [ ] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [x] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [ ] Deployment
- [ ] CLI
- [ ] General tooling
- [ ] Documentation
## Types of changes
<!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
- [ ] Bug fix (generally a non-breaking change which closes an issue).
- [x] Enhancement or new feature (adds new functionality).
- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
## Checklist:
<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
- [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [x] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
- [x] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [ ] I updated the documentation where necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] tysonnorris merged pull request #4859: kcf - enable use
of fieldref to inject action pod details to pod env
Posted by GitBox <gi...@apache.org>.
tysonnorris merged pull request #4859: kcf - enable use of fieldref to inject action pod details to pod env
URL: https://github.com/apache/openwhisk/pull/4859
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] codecov-io edited a comment on issue #4859: kcf -
enable use of fieldref to inject action pod details to pod env
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4859: kcf - enable use of fieldref to inject action pod details to pod env
URL: https://github.com/apache/openwhisk/pull/4859#issuecomment-598395743
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4859?src=pr&el=h1) Report
> Merging [#4859](https://codecov.io/gh/apache/openwhisk/pull/4859?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/394e9f6cb3ec09dd4a5ce158afaf2268d64fec12&el=desc) will **decrease** coverage by `6.26%`.
> The diff coverage is `80.58%`.
[](https://codecov.io/gh/apache/openwhisk/pull/4859?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4859 +/- ##
==========================================
- Coverage 82.37% 76.11% -6.27%
==========================================
Files 198 200 +2
Lines 9021 9298 +277
Branches 353 378 +25
==========================================
- Hits 7431 7077 -354
- Misses 1590 2221 +631
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4859?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erpool/kubernetes/KubernetesContainerFactory.scala](https://codecov.io/gh/apache/openwhisk/pull/4859/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL0t1YmVybmV0ZXNDb250YWluZXJGYWN0b3J5LnNjYWxh) | `0.00% <ø> (ø)` | |
| [...re/containerpool/kubernetes/KubernetesClient.scala](https://codecov.io/gh/apache/openwhisk/pull/4859/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL0t1YmVybmV0ZXNDbGllbnQuc2NhbGE=) | `20.90% <7.14%> (-0.15%)` | :arrow_down: |
| [...e/elasticsearch/ElasticSearchActivationStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4859/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvZWxhc3RpY3NlYXJjaC9FbGFzdGljU2VhcmNoQWN0aXZhdGlvblN0b3JlLnNjYWxh) | `83.64% <83.64%> (ø)` | |
| [...a/org/apache/openwhisk/core/entity/Parameter.scala](https://codecov.io/gh/apache/openwhisk/pull/4859/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1BhcmFtZXRlci5zY2FsYQ==) | `88.77% <85.48%> (-1.80%)` | :arrow_down: |
| [...ore/containerpool/kubernetes/WhiskPodBuilder.scala](https://codecov.io/gh/apache/openwhisk/pull/4859/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL1doaXNrUG9kQnVpbGRlci5zY2FsYQ==) | `94.73% <89.47%> (-5.27%)` | :arrow_down: |
| [...he/openwhisk/core/entity/ParameterEncryption.scala](https://codecov.io/gh/apache/openwhisk/pull/4859/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1BhcmFtZXRlckVuY3J5cHRpb24uc2NhbGE=) | `94.82% <94.82%> (ø)` | |
| [.../scala/org/apache/openwhisk/core/WhiskConfig.scala](https://codecov.io/gh/apache/openwhisk/pull/4859/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvV2hpc2tDb25maWcuc2NhbGE=) | `94.89% <100.00%> (+0.07%)` | :arrow_up: |
| [...penwhisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/openwhisk/pull/4859/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `84.21% <100.00%> (-12.57%)` | :arrow_down: |
| [...org/apache/openwhisk/core/entity/WhiskAction.scala](https://codecov.io/gh/apache/openwhisk/pull/4859/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1doaXNrQWN0aW9uLnNjYWxh) | `91.25% <100.00%> (ø)` | |
| [...rg/apache/openwhisk/core/entity/WhiskPackage.scala](https://codecov.io/gh/apache/openwhisk/pull/4859/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1doaXNrUGFja2FnZS5zY2FsYQ==) | `96.66% <100.00%> (+0.05%)` | :arrow_up: |
| ... and [24 more](https://codecov.io/gh/apache/openwhisk/pull/4859/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4859?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4859?src=pr&el=footer). Last update [995387f...ed7de14](https://codecov.io/gh/apache/openwhisk/pull/4859?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] codecov-io commented on issue #4859: kcf - enable use
of fieldref to inject action pod details to pod env
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4859: kcf - enable use of fieldref to inject action pod details to pod env
URL: https://github.com/apache/openwhisk/pull/4859#issuecomment-598395743
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4859?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@995387f`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `81.81%`.
[](https://codecov.io/gh/apache/openwhisk/pull/4859?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4859 +/- ##
=========================================
Coverage ? 76.11%
=========================================
Files ? 200
Lines ? 9298
Branches ? 378
=========================================
Hits ? 7077
Misses ? 2221
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4859?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ore/containerpool/kubernetes/WhiskPodBuilder.scala](https://codecov.io/gh/apache/openwhisk/pull/4859/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL1doaXNrUG9kQnVpbGRlci5zY2FsYQ==) | `94.73% <100%> (ø)` | |
| [...re/containerpool/kubernetes/KubernetesClient.scala](https://codecov.io/gh/apache/openwhisk/pull/4859/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL0t1YmVybmV0ZXNDbGllbnQuc2NhbGE=) | `20.9% <33.33%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4859?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4859?src=pr&el=footer). Last update [995387f...ed7de14](https://codecov.io/gh/apache/openwhisk/pull/4859?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services