You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Loyal-Young (via GitHub)" <gi...@apache.org> on 2026/10/15 06:46:30 UTC
[PR] fix(acl): ignore invalid wildcard permissions in risk score [rocketmq-dashboard]
Loyal-Young opened a new pull request, #6717:
URL: https://github.com/apache/rocketmq-dashboard/pull/6717
## What is the purpose of the change
Fixes #6716. An ACL entry with wildcard resource but an unknown permission was counted as broad authorization. The same entry was also reported as malformed, so the panel could raise a false wildcard risk and inflate the wildcard-account count.
## Brief changelog
- Count wildcard entries only when their parsed permission grants `PUB`, `SUB`, or `ALL`.
- Keep the existing malformed-entry finding for `UNKNOWN` permissions.
- Cover `*=INVALID` and a bare `*` alongside the existing recognized-wildcard cases.
## Verification
- The new regression failed before the fix (`wildcardPermissionAccountCount` was 1 instead of 0).
- ACL risk diagnostic suite: 8/8 passed after the fix.
- TypeScript `--noEmit`, changed-file ESLint, and `git diff --check` passed.
## AI assistance
AI assistance helped trace the diagnostic classification and draft the regression. I reviewed the narrow permission-rank change and ran the checks above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(acl): ignore invalid wildcard permissions in risk score [rocketmq-dashboard]
Posted by "Loyal-Young (via GitHub)" <gi...@apache.org>.
Loyal-Young commented on PR #6717:
URL: https://github.com/apache/rocketmq-dashboard/pull/6717#issuecomment-6261575985
Progress update (2026-10-19): GitHub currently reports the branch as mergeable. The current CI run has 4 of 5 checks passing; the Backend Tests (Java 21) failure and its unrelated test cause are documented in the earlier PR discussion. The change is ready for maintainer review. I will follow up on any new feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(acl): ignore invalid wildcard permissions in risk score [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #6717:
URL: https://github.com/apache/rocketmq-dashboard/pull/6717#issuecomment-6263570640
Folded into #6715, merged into `rocketmq-studio` as 2e211671c — your change is in that commit and stays authored by you.
We batched five related ACL PRs (#6715 #6717 #6912 #6913 #6914) into a single integration commit to keep the history readable, so this one is closed as folded rather than merged separately. No action needed; the linked issue is closed as resolved by #6715.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(acl): ignore invalid wildcard permissions in risk score [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #6717: fix(acl): ignore invalid wildcard permissions in risk score
URL: https://github.com/apache/rocketmq-dashboard/pull/6717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(acl): ignore invalid wildcard permissions in risk score [rocketmq-dashboard]
Posted by "Loyal-Young (via GitHub)" <gi...@apache.org>.
Loyal-Young commented on PR #6717:
URL: https://github.com/apache/rocketmq-dashboard/pull/6717#issuecomment-6232725814
CI follow-up: this PR changes only web/src/utils/aclRiskDiagnostics.ts and its test. The Backend Tests failure is ResourceOwnershipGuardTest.migrationConcurrentStartupIsIdempotentTest, where H2 reported a ConcurrentModificationException; it is outside this PR's changed paths. The other four CI jobs passed. I am leaving the failure visible here for review rather than treating it as a passing check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org