You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datafusion.apache.org by al...@apache.org on 2025/08/04 19:22:48 UTC
(datafusion) branch main updated: test: Add logic tests for string_agg with order (#17033)
This is an automated email from the ASF dual-hosted git repository.
alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git
The following commit(s) were added to refs/heads/main by this push:
new 36f5f1456d test: Add logic tests for string_agg with order (#17033)
36f5f1456d is described below
commit 36f5f1456d8cda6d6d576c10baab9c59a4e84f8e
Author: Nuno Faria <nu...@gmail.com>
AuthorDate: Mon Aug 4 20:22:43 2025 +0100
test: Add logic tests for string_agg with order (#17033)
---
datafusion/sqllogictest/test_files/aggregate.slt | 78 ++++++++++++++++++++++++
1 file changed, 78 insertions(+)
diff --git a/datafusion/sqllogictest/test_files/aggregate.slt b/datafusion/sqllogictest/test_files/aggregate.slt
index 37a074bda4..882de5dc54 100644
--- a/datafusion/sqllogictest/test_files/aggregate.slt
+++ b/datafusion/sqllogictest/test_files/aggregate.slt
@@ -6078,6 +6078,84 @@ GROUP BY dummy
----
text1
+
+# Test string_agg with ORDER BY clasuses (issue #17011)
+statement ok
+create table t (k varchar, v int);
+
+statement ok
+insert into t values ('a', 2), ('b', 3), ('c', 1), ('d', null);
+
+query T
+select string_agg(k, ',' order by k) from t;
+----
+a,b,c,d
+
+query T
+select string_agg(k, ',' order by k desc) from t;
+----
+d,c,b,a
+
+query T
+select string_agg(k, ',' order by v) from t;
+----
+c,a,b,d
+
+query T
+select string_agg(k, ',' order by v nulls first) from t;
+----
+d,c,a,b
+
+query T
+select string_agg(k, ',' order by v desc) from t;
+----
+d,b,a,c
+
+query T
+select string_agg(k, ',' order by v desc nulls last) from t;
+----
+b,a,c,d
+
+query T
+-- odd indexes should appear first, ties solved by v
+select string_agg(k, ',' order by v % 2 == 0, v) from t;
+----
+c,b,a,d
+
+query T
+-- odd indexes should appear first, ties solved by v desc
+select string_agg(k, ',' order by v % 2 == 0, v desc) from t;
+----
+b,c,a,d
+
+query T
+select string_agg(k, ',' order by
+ case
+ when k = 'a' then 3
+ when k = 'b' then 0
+ when k = 'c' then 2
+ when k = 'd' then 1
+ end)
+from t;
+----
+b,d,c,a
+
+query T
+select string_agg(k, ',' order by
+ case
+ when k = 'a' then 3
+ when k = 'b' then 0
+ when k = 'c' then 2
+ when k = 'd' then 1
+ end desc)
+from t;
+----
+a,c,d,b
+
+statement ok
+drop table t;
+
+
# Tests for aggregating with NaN values
statement ok
CREATE TABLE float_table (
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org