You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/08/03 06:42:22 UTC
[GitHub] [incubator-mxnet] larroy commented on a change in pull request
#15581: Numpy-compatible Infra
larroy commented on a change in pull request #15581: Numpy-compatible Infra
URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310340395
##########
File path: include/mxnet/base.h
##########
@@ -451,7 +451,9 @@ inline int32_t Context::GetGPUCount() {
}
int32_t count;
cudaError_t e = cudaGetDeviceCount(&count);
- if (e == cudaErrorNoDevice) {
+ // TODO(junwu): Remove e == 35
+ // This is skipped for working around wheel build system with older CUDA driver.
+ if (e == cudaErrorNoDevice || e == 35) {
Review comment:
Please consider using propper error code here "cudaErrorInsufficientDriver" or adding a comment, not a constant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services