You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Daniel Lipski (JIRA)" <ji...@apache.org> on 2012/05/04 12:22:47 UTC
[jira] [Created] (WICKET-4532) Disable caching for particular
resources.
Daniel Lipski created WICKET-4532:
-------------------------------------
Summary: Disable caching for particular resources.
Key: WICKET-4532
URL: https://issues.apache.org/jira/browse/WICKET-4532
Project: Wicket
Issue Type: New Feature
Components: wicket
Affects Versions: 1.5.5
Reporter: Daniel Lipski
Priority: Minor
Currently it is possible to disable resources versioning by :
getResourceSettings().setCachingStrategy(NoOpResourceCachingStrategy.INSTANCE);
Unfortunately this disables caching for every resource, it would be nice to disable caching for particular (package) resource, something like:
PackageResourceReference res = new PackageResourceReference(....);
res.setCashable(false);
Caching in general is good think but some javascript libraries get broken when filenames are modified with "-ver-..." token.
Regards
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4532) Disable caching for particular
resources.
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269178#comment-13269178 ]
Martin Grigorov commented on WICKET-4532:
-----------------------------------------
It is OK to make API changes until we release 6.0.0-RC1.
A comment about the patch itself: I think the covariant return in CssResourceReference#getResource() is a good thing.
Can you also take a look at WICKET-4457?
> Disable caching for particular resources.
> -----------------------------------------
>
> Key: WICKET-4532
> URL: https://issues.apache.org/jira/browse/WICKET-4532
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.5.5
> Reporter: Daniel Lipski
> Assignee: Peter Ertl
> Priority: Minor
> Attachments: disable-caching-for-resource.patch
>
>
> Currently it is possible to disable resources versioning by :
> getResourceSettings().setCachingStrategy(NoOpResourceCachingStrategy.INSTANCE);
> Unfortunately this disables caching for every resource, it would be nice to disable caching for particular (package) resource, something like:
> PackageResourceReference res = new PackageResourceReference(....);
> res.setCashable(false);
> Caching in general is good think but some javascript libraries get broken when filenames are modified with "-ver-..." token.
> Regards
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (WICKET-4532) Disable caching for
particular resources.
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269477#comment-13269477 ]
Peter Ertl edited comment on WICKET-4532 at 5/7/12 10:00 AM:
-------------------------------------------------------------
there is now a new method
boolean org.apache.wicket.request.resource.caching.IStaticCacheableResource#isCachingEnabled()
which controls whether caching is applied or not.
in case of PackageResourceReference (and friends) disabling caching could e.g.be achieved like this:
PackageResourceReference reference = new PackageResourceReference(Home.class, "Beer.gif") {
@Override
public PackageResource getResource()
{
final PackageResource resource = super.getResource();
resource.setCachingEnabled(false);
return resource;
}
};
I will add this to the wiki later...
Since the interface change breaks the api we can not offer this for 1.5.x but only for 6.x.
was (Author: pete):
there is now a new method
boolean org.apache.wicket.request.resource.caching.IStaticCacheableResource#isCacheEnabled()
which controls whether caching is applied or not.
in case of PackageResourceReference (and friends) disabling caching could e.g.be achieved like this:
PackageResourceReference reference = new PackageResourceReference(Home.class, "Beer.gif") {
@Override
public PackageResource getResource()
{
final PackageResource resource = super.getResource();
resource.setCacheEnabled(false);
return resource;
}
};
I will add this to the wiki later...
Since the interface change breaks the api we can not offer this for 1.5.x but only for 6.x.
> Disable caching for particular resources.
> -----------------------------------------
>
> Key: WICKET-4532
> URL: https://issues.apache.org/jira/browse/WICKET-4532
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.5.5, 6.0.0-beta1
> Reporter: Daniel Lipski
> Assignee: Peter Ertl
> Priority: Minor
> Fix For: 6.0.0-RC1
>
> Attachments: disable-caching-for-resource.patch
>
>
> Currently it is possible to disable resources versioning by :
> getResourceSettings().setCachingStrategy(NoOpResourceCachingStrategy.INSTANCE);
> Unfortunately this disables caching for every resource, it would be nice to disable caching for particular (package) resource, something like:
> PackageResourceReference res = new PackageResourceReference(....);
> res.setCashable(false);
> Caching in general is good think but some javascript libraries get broken when filenames are modified with "-ver-..." token.
> Regards
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4532) Disable caching for particular
resources.
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Ertl updated WICKET-4532:
-------------------------------
Attachment: disable-caching-for-resource.patch
> Disable caching for particular resources.
> -----------------------------------------
>
> Key: WICKET-4532
> URL: https://issues.apache.org/jira/browse/WICKET-4532
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.5.5
> Reporter: Daniel Lipski
> Assignee: Peter Ertl
> Priority: Minor
> Attachments: disable-caching-for-resource.patch
>
>
> Currently it is possible to disable resources versioning by :
> getResourceSettings().setCachingStrategy(NoOpResourceCachingStrategy.INSTANCE);
> Unfortunately this disables caching for every resource, it would be nice to disable caching for particular (package) resource, something like:
> PackageResourceReference res = new PackageResourceReference(....);
> res.setCashable(false);
> Caching in general is good think but some javascript libraries get broken when filenames are modified with "-ver-..." token.
> Regards
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4532) Disable caching for particular
resources.
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268945#comment-13268945 ]
Peter Ertl commented on WICKET-4532:
------------------------------------
I could fix this in 6.x (not in 1.5 since it will break the api) with the patch that is included in this issue. Can I get some feedback please if it's okay to commit it into master since we so close to 6.0.0 ?
> Disable caching for particular resources.
> -----------------------------------------
>
> Key: WICKET-4532
> URL: https://issues.apache.org/jira/browse/WICKET-4532
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.5.5
> Reporter: Daniel Lipski
> Assignee: Peter Ertl
> Priority: Minor
>
> Currently it is possible to disable resources versioning by :
> getResourceSettings().setCachingStrategy(NoOpResourceCachingStrategy.INSTANCE);
> Unfortunately this disables caching for every resource, it would be nice to disable caching for particular (package) resource, something like:
> PackageResourceReference res = new PackageResourceReference(....);
> res.setCashable(false);
> Caching in general is good think but some javascript libraries get broken when filenames are modified with "-ver-..." token.
> Regards
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4532) Disable caching for particular
resources.
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Ertl resolved WICKET-4532.
--------------------------------
Resolution: Fixed
Fix Version/s: 6.0.0-RC1
> Disable caching for particular resources.
> -----------------------------------------
>
> Key: WICKET-4532
> URL: https://issues.apache.org/jira/browse/WICKET-4532
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.5.5, 6.0.0-beta1
> Reporter: Daniel Lipski
> Assignee: Peter Ertl
> Priority: Minor
> Fix For: 6.0.0-RC1
>
> Attachments: disable-caching-for-resource.patch
>
>
> Currently it is possible to disable resources versioning by :
> getResourceSettings().setCachingStrategy(NoOpResourceCachingStrategy.INSTANCE);
> Unfortunately this disables caching for every resource, it would be nice to disable caching for particular (package) resource, something like:
> PackageResourceReference res = new PackageResourceReference(....);
> res.setCashable(false);
> Caching in general is good think but some javascript libraries get broken when filenames are modified with "-ver-..." token.
> Regards
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4532) Disable caching for particular
resources.
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Ertl updated WICKET-4532:
-------------------------------
Affects Version/s: 6.0.0-beta1
> Disable caching for particular resources.
> -----------------------------------------
>
> Key: WICKET-4532
> URL: https://issues.apache.org/jira/browse/WICKET-4532
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.5.5, 6.0.0-beta1
> Reporter: Daniel Lipski
> Assignee: Peter Ertl
> Priority: Minor
> Attachments: disable-caching-for-resource.patch
>
>
> Currently it is possible to disable resources versioning by :
> getResourceSettings().setCachingStrategy(NoOpResourceCachingStrategy.INSTANCE);
> Unfortunately this disables caching for every resource, it would be nice to disable caching for particular (package) resource, something like:
> PackageResourceReference res = new PackageResourceReference(....);
> res.setCashable(false);
> Caching in general is good think but some javascript libraries get broken when filenames are modified with "-ver-..." token.
> Regards
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WICKET-4532) Disable caching for particular
resources.
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Ertl reassigned WICKET-4532:
----------------------------------
Assignee: Peter Ertl
> Disable caching for particular resources.
> -----------------------------------------
>
> Key: WICKET-4532
> URL: https://issues.apache.org/jira/browse/WICKET-4532
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.5.5
> Reporter: Daniel Lipski
> Assignee: Peter Ertl
> Priority: Minor
>
> Currently it is possible to disable resources versioning by :
> getResourceSettings().setCachingStrategy(NoOpResourceCachingStrategy.INSTANCE);
> Unfortunately this disables caching for every resource, it would be nice to disable caching for particular (package) resource, something like:
> PackageResourceReference res = new PackageResourceReference(....);
> res.setCashable(false);
> Caching in general is good think but some javascript libraries get broken when filenames are modified with "-ver-..." token.
> Regards
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4532) Disable caching for particular
resources.
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269477#comment-13269477 ]
Peter Ertl commented on WICKET-4532:
------------------------------------
there is now a new method
boolean org.apache.wicket.request.resource.caching.IStaticCacheableResource#isCacheEnabled()
which controls whether caching is applied or not.
in case of PackageResourceReference (and friends) disabling caching could e.g.be achieved like this:
PackageResourceReference reference = new PackageResourceReference(Home.class, "Beer.gif") {
@Override
public PackageResource getResource()
{
final PackageResource resource = super.getResource();
resource.setCacheEnabled(false);
return resource;
}
};
I will add this to the wiki later...
Since the interface change breaks the api we can not offer this for 1.5.x but only for 6.x.
> Disable caching for particular resources.
> -----------------------------------------
>
> Key: WICKET-4532
> URL: https://issues.apache.org/jira/browse/WICKET-4532
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.5.5
> Reporter: Daniel Lipski
> Assignee: Peter Ertl
> Priority: Minor
> Attachments: disable-caching-for-resource.patch
>
>
> Currently it is possible to disable resources versioning by :
> getResourceSettings().setCachingStrategy(NoOpResourceCachingStrategy.INSTANCE);
> Unfortunately this disables caching for every resource, it would be nice to disable caching for particular (package) resource, something like:
> PackageResourceReference res = new PackageResourceReference(....);
> res.setCashable(false);
> Caching in general is good think but some javascript libraries get broken when filenames are modified with "-ver-..." token.
> Regards
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira