You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by je...@apache.org on 2013/04/09 22:43:20 UTC

git commit: THRIFT-1922: Inconsistency in optional fields between Java/C# and python

Updated Branches:
  refs/heads/master c613cd2d9 -> 93220328d


THRIFT-1922: Inconsistency in optional fields between Java/C# and python

Patch: Nate Rosenblum


Project: http://git-wip-us.apache.org/repos/asf/thrift/repo
Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/93220328
Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/93220328
Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/93220328

Branch: refs/heads/master
Commit: 93220328d937df63f2a670fed8d4f8da3375c255
Parents: c613cd2
Author: Jens Geyer <je...@apache.org>
Authored: Tue Apr 9 22:35:42 2013 +0200
Committer: Jens Geyer <je...@apache.org>
Committed: Tue Apr 9 22:42:31 2013 +0200

----------------------------------------------------------------------
 compiler/cpp/src/generate/t_csharp_generator.cc |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/thrift/blob/93220328/compiler/cpp/src/generate/t_csharp_generator.cc
----------------------------------------------------------------------
diff --git a/compiler/cpp/src/generate/t_csharp_generator.cc b/compiler/cpp/src/generate/t_csharp_generator.cc
index 2d72598..f215e30 100644
--- a/compiler/cpp/src/generate/t_csharp_generator.cc
+++ b/compiler/cpp/src/generate/t_csharp_generator.cc
@@ -573,6 +573,8 @@ void t_csharp_generator::generate_csharp_struct_definition(ofstream &out, t_stru
         print_const_value(out, "this." + prop_name(*m_iter), t, (*m_iter)->get_value(), true, true);
       } else {
         print_const_value(out, "this._" + (*m_iter)->get_name(), t, (*m_iter)->get_value(), true, true);
+        // Optionals with defaults are marked set
+        indent(out) << "this.__isset." << (*m_iter)->get_name() << " = true;" << endl;
       }
     }
   }