You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "walterddr (via GitHub)" <gi...@apache.org> on 2023/05/02 04:22:35 UTC

[GitHub] [pinot] walterddr commented on pull request #10683: Refine the return error code of query killing

walterddr commented on PR #10683:
URL: https://github.com/apache/pinot/pull/10683#issuecomment-1530855113

   actually my concern was the other way around. sorry for miscommunication my concern.
   
   2xx is consider [success](https://en.wikipedia.org/wiki/List_of_HTTP_status_codes), this means 205 and 200 are both considered as success in HTTP standard. i was actually wondering if we should return an actual error code, for example
   - 429 Too Many Requests
   - 503 Service Unavailable
   both seems to be more suitable for query killed ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org