[GitHub] [hudi] nsivabalan commented on a diff in pull request #9553: [HUDI-1517] Adding support for per-logfile marker to track all log files added by a commit and to assist with rollbacks

["nsivabalan (via GitHub)" <gi...@apache.org>]

nsivabalan commented on code in PR #9553:
URL: https://github.com/apache/hudi/pull/9553#discussion_r1306746724


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/MarkerBasedRollbackStrategy.java:
##########
@@ -159,9 +161,18 @@ protected HoodieRollbackRequest getRollbackRequestForAppend(String markerFilePat
       HoodieLogFile latestLogFile = latestLogFileOption.get();
       // NOTE: Marker's don't carry information about the cumulative size of the blocks that have been appended,
       //       therefore we simply stub this value.
-      logFilesWithBlocksToRollback = Collections.singletonMap(latestLogFile.getPath().toString(), -1L);
+      FileSystem fileSystem = table.getMetaClient().getFs();

Review Comment:
   We need to ensure we merge multiple rollback requests such that, we have just 1 rollbackRequest per file slice. 
   eventually, during execution we will add rollback blocks once per roll back request. So, lets not break that assumption. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org