You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Animesh Chaturvedi <an...@citrix.com> on 2013/02/27 21:00:37 UTC

[DISCUSS] Review Board Guidelines DRAFT

Folks

I put together DRAFT review board guidelines in wiki https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines. Please review and update as needed.

Thanks
Animesh

Re: [DISCUSS] Review Board Guidelines DRAFT

Posted by Chip Childers <ch...@sungard.com>.
On Wed, Feb 27, 2013 at 02:17:50PM -0800, Alex Huang wrote:
> Good point Joe.  I think actually all patches in this manner should be treated as if it's a merge and go through Chip's merge guidelines.

+1 - added a link.

> 
> --Alex
> 
> > -----Original Message-----
> > From: Joe Brockmeier [mailto:jzb@zonker.net]
> > Sent: Wednesday, February 27, 2013 1:47 PM
> > To: cloudstack-dev@incubator.apache.org
> > Subject: Re: [DISCUSS] Review Board Guidelines DRAFT
> > 
> > On Wed, Feb 27, 2013, at 02:00 PM, Animesh Chaturvedi wrote:
> > > I put together DRAFT review board guidelines in wiki
> > >
> > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+
> > Guidelines.
> > > Please review and update as needed.
> > 
> > I have added a bullet about actually testing patches (not just that it
> > applies) before submitting and indicating what testing has been done.
> > 
> > Best,
> > 
> > jzb
> > --
> > Joe Brockmeier
> > jzb@zonker.net
> > Twitter: @jzb
> > http://www.dissociatedpress.net/
>

RE: [DISCUSS] Review Board Guidelines DRAFT

Posted by Alex Huang <Al...@citrix.com>.
Good point Joe.  I think actually all patches in this manner should be treated as if it's a merge and go through Chip's merge guidelines.

--Alex

> -----Original Message-----
> From: Joe Brockmeier [mailto:jzb@zonker.net]
> Sent: Wednesday, February 27, 2013 1:47 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: Re: [DISCUSS] Review Board Guidelines DRAFT
> 
> On Wed, Feb 27, 2013, at 02:00 PM, Animesh Chaturvedi wrote:
> > I put together DRAFT review board guidelines in wiki
> >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+
> Guidelines.
> > Please review and update as needed.
> 
> I have added a bullet about actually testing patches (not just that it
> applies) before submitting and indicating what testing has been done.
> 
> Best,
> 
> jzb
> --
> Joe Brockmeier
> jzb@zonker.net
> Twitter: @jzb
> http://www.dissociatedpress.net/

Re: [DISCUSS] Review Board Guidelines DRAFT

Posted by Joe Brockmeier <jz...@zonker.net>.
On Wed, Feb 27, 2013, at 02:00 PM, Animesh Chaturvedi wrote:
> I put together DRAFT review board guidelines in wiki
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines.
> Please review and update as needed.

I have added a bullet about actually testing patches (not just that it
applies) before submitting and indicating what testing has been done. 

Best,

jzb
-- 
Joe Brockmeier
jzb@zonker.net
Twitter: @jzb
http://www.dissociatedpress.net/

Re: [DISCUSS] Review Board Guidelines DRAFT

Posted by Prasanna Santhanam <ts...@apache.org>.
On Thu, Feb 28, 2013 at 01:30:37AM +0530, Animesh Chaturvedi wrote:
> Folks
> 
> I put together DRAFT review board guidelines in wiki
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines.
> Please review and update as needed.
> 
> Thanks
> Animesh

Looks good. Added a small section on acknowledging contribution.

-- 
Prasanna.,

RE: [DISCUSS] Review Board Guidelines DRAFT

Posted by Alex Huang <Al...@citrix.com>.
The issue has already been resolved and the step is added to Jira already.

I don't think everyone can see the workflow on Jira.  I added it to your page.  You can find a good place to put it.

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines

--Alex

> -----Original Message-----
> From: Animesh Chaturvedi
> Sent: Thursday, March 14, 2013 1:46 PM
> To: cloudstack-dev@incubator.apache.org; Alex Huang
> Subject: RE: [DISCUSS] Review Board Guidelines DRAFT
> 
> 
> 
> > -----Original Message-----
> > From: Alex Huang [mailto:Alex.Huang@citrix.com]
> > Sent: Wednesday, February 27, 2013 12:07 PM
> > To: cloudstack-dev@incubator.apache.org
> > Subject: RE: [DISCUSS] Review Board Guidelines DRAFT
> >
> > Nice.
> >
> > But I think the first step for any patch review is to go through the
> > jira workflow.  Can you add explanation on how to use the jira
> > workflow for a contributor contributing on review board?
> [Animesh>] Alex are referring to this workflow as mentioned in this infra
> issue https://issues.apache.org/jira/browse/INFRA-5294? Please cofirm and I
> will summarize in the guidelines
> 
> >
> > --Alex
> >
> > > -----Original Message-----
> > > From: Animesh Chaturvedi [mailto:animesh.chaturvedi@citrix.com]
> > > Sent: Wednesday, February 27, 2013 12:01 PM
> > > To: cloudstack-dev@incubator.apache.org
> > > Subject: [DISCUSS] Review Board Guidelines DRAFT
> > >
> > > Folks
> > >
> > > I put together DRAFT review board guidelines in wiki
> > >
> >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+
> > > Guidelines. Please review and update as needed.
> > >
> > > Thanks
> > > Animesh

RE: [DISCUSS] Review Board Guidelines DRAFT

Posted by Animesh Chaturvedi <an...@citrix.com>.

> -----Original Message-----
> From: Alex Huang [mailto:Alex.Huang@citrix.com]
> Sent: Wednesday, February 27, 2013 12:07 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: [DISCUSS] Review Board Guidelines DRAFT
> 
> Nice.
> 
> But I think the first step for any patch review is to go through the jira
> workflow.  Can you add explanation on how to use the jira workflow for a
> contributor contributing on review board?
[Animesh>] Alex are referring to this workflow as mentioned in this infra issue https://issues.apache.org/jira/browse/INFRA-5294? Please cofirm and I will summarize in the guidelines

> 
> --Alex
> 
> > -----Original Message-----
> > From: Animesh Chaturvedi [mailto:animesh.chaturvedi@citrix.com]
> > Sent: Wednesday, February 27, 2013 12:01 PM
> > To: cloudstack-dev@incubator.apache.org
> > Subject: [DISCUSS] Review Board Guidelines DRAFT
> >
> > Folks
> >
> > I put together DRAFT review board guidelines in wiki
> >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+
> > Guidelines. Please review and update as needed.
> >
> > Thanks
> > Animesh

RE: [DISCUSS] Review Board Guidelines DRAFT

Posted by Animesh Chaturvedi <an...@citrix.com>.

> -----Original Message-----
> From: Chip Childers [mailto:chip.childers@sungard.com]
> Sent: Tuesday, March 05, 2013 12:56 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: Re: [DISCUSS] Review Board Guidelines DRAFT
> 
> On Wed, Feb 27, 2013 at 12:07:13PM -0800, Alex Huang wrote:
> > Nice.
> >
> > But I think the first step for any patch review is to go through the jira
> workflow.  Can you add explanation on how to use the jira workflow for a
> contributor contributing on review board?
> 
> +1 - A Jira ID should be required for any patch, and the workflow is
> important.  Animesh - do you mind adding that?
> 
[Animesh>] Yes it's on my TODO
> >
> > --Alex
> >
> > > -----Original Message-----
> > > From: Animesh Chaturvedi [mailto:animesh.chaturvedi@citrix.com]
> > > Sent: Wednesday, February 27, 2013 12:01 PM
> > > To: cloudstack-dev@incubator.apache.org
> > > Subject: [DISCUSS] Review Board Guidelines DRAFT
> > >
> > > Folks
> > >
> > > I put together DRAFT review board guidelines in wiki
> > >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+
> > > Guidelines. Please review and update as needed.
> > >
> > > Thanks
> > > Animesh
> >

Re: [DISCUSS] Review Board Guidelines DRAFT

Posted by Chip Childers <ch...@sungard.com>.
On Wed, Feb 27, 2013 at 12:07:13PM -0800, Alex Huang wrote:
> Nice.
> 
> But I think the first step for any patch review is to go through the jira workflow.  Can you add explanation on how to use the jira workflow for a contributor contributing on review board?

+1 - A Jira ID should be required for any patch, and the workflow is
important.  Animesh - do you mind adding that?

> 
> --Alex
> 
> > -----Original Message-----
> > From: Animesh Chaturvedi [mailto:animesh.chaturvedi@citrix.com]
> > Sent: Wednesday, February 27, 2013 12:01 PM
> > To: cloudstack-dev@incubator.apache.org
> > Subject: [DISCUSS] Review Board Guidelines DRAFT
> > 
> > Folks
> > 
> > I put together DRAFT review board guidelines in wiki
> > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+
> > Guidelines. Please review and update as needed.
> > 
> > Thanks
> > Animesh
>

RE: [DISCUSS] Review Board Guidelines DRAFT

Posted by Animesh Chaturvedi <an...@citrix.com>.
Alex I know we talked about this a while back, but I cannot recall the entire context. I will sync up with you tomorrow and update the guidelines

> -----Original Message-----
> From: Alex Huang [mailto:Alex.Huang@citrix.com]
> Sent: Wednesday, February 27, 2013 12:07 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: [DISCUSS] Review Board Guidelines DRAFT
> 
> Nice.
> 
> But I think the first step for any patch review is to go through the jira
> workflow.  Can you add explanation on how to use the jira workflow for a
> contributor contributing on review board?
> 
> --Alex
> 
> > -----Original Message-----
> > From: Animesh Chaturvedi [mailto:animesh.chaturvedi@citrix.com]
> > Sent: Wednesday, February 27, 2013 12:01 PM
> > To: cloudstack-dev@incubator.apache.org
> > Subject: [DISCUSS] Review Board Guidelines DRAFT
> >
> > Folks
> >
> > I put together DRAFT review board guidelines in wiki
> >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+
> > Guidelines. Please review and update as needed.
> >
> > Thanks
> > Animesh

RE: [DISCUSS] Review Board Guidelines DRAFT

Posted by Alex Huang <Al...@citrix.com>.
Nice.

But I think the first step for any patch review is to go through the jira workflow.  Can you add explanation on how to use the jira workflow for a contributor contributing on review board?

--Alex

> -----Original Message-----
> From: Animesh Chaturvedi [mailto:animesh.chaturvedi@citrix.com]
> Sent: Wednesday, February 27, 2013 12:01 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: [DISCUSS] Review Board Guidelines DRAFT
> 
> Folks
> 
> I put together DRAFT review board guidelines in wiki
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+
> Guidelines. Please review and update as needed.
> 
> Thanks
> Animesh