You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "serhiy-bzhezytskyy (via GitHub)" <gi...@apache.org> on 2026/09/04 19:29:58 UTC
[PR] Rename converted operations from agg to facet, Solr's term [solr-orbit]
serhiy-bzhezytskyy opened a new pull request, #78:
URL: https://github.com/apache/solr-orbit/pull/78
### Description
`convert-workload` copies operation names through, so a converted workload keeps OpenSearch's word for an aggregation — `date_histogram_agg`, `country_agg_cached`. The workloads in solr-orbit-workloads use the facet names, so these are the only names a regeneration does not reproduce.
An operation name is also what a test procedure schedules, the prefix of its `<name>_iterations` parameters, and the key `workload.py` registers a value source under, so the rename covers all of them — renaming only the definition gives a workload that loads and then aborts with a missing value source. The token is matched on its own, so `aggs` and `aggregation` are untouched. Each rename is recorded in `CONVERTED.md`.
### Issues Resolved
None.
### Testing
- [x] New functionality includes testing
Unit tests for the token boundaries, all four reference sites and an end-to-end conversion. Regenerating nyc_taxis and geonames now produces every operation name the shipped workloads use, and the only lines that change in the generated output are the names themselves.
---
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Rename converted operations from agg to facet, Solr's term [solr-orbit]
Posted by "sergeybzhezitskiy (via GitHub)" <gi...@apache.org>.
sergeybzhezitskiy commented on PR #78:
URL: https://github.com/apache/solr-orbit/pull/78#issuecomment-5545724811
yes it is clear, and to be honest i converted almost all 18 workloads from OSB, and but then later i noticed some bugs and fixed them and had to back to fix them manually in already ported workloads so i thought that the converter might give me always reproducible result and i will be able to catch regression. this PR is just nice to have, it does only alignments. we can pause this changes and later i will share fully aligned version for all ported workloads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Rename converted operations from agg to facet, Solr's term [solr-orbit]
Posted by "serhiy-bzhezytskyy (via GitHub)" <gi...@apache.org>.
serhiy-bzhezytskyy commented on PR #78:
URL: https://github.com/apache/solr-orbit/pull/78#issuecomment-5545796637
One scope note, since it applies to the other converter PRs: this one is naming, and pausing it is fine. #74 and #77 are a different case — there the generated workload does not run. A space in a range term gives HTTP 400, and `fixed_interval: 60d` is converted to `+1MONTH`, so the facet returns monthly buckets for a 60-day interval. Hand-tuning is the only way to get a working workload out of those, which is what I would rather remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Rename converted operations from agg to facet, Solr's term [solr-orbit]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #78:
URL: https://github.com/apache/solr-orbit/pull/78#issuecomment-5545598663
I'm a bit reluctant to so much code for a naming. I considered this while doing the port but left it.
I view the converter tool as a bootstrap tool to get you started, and then it will be a starting point, but expect the developer to tune and tweak it until it is ok for Solr. So perhaps we can accept some minors like this?
I don't doubt that the code works, have not reviewed in detail, just my first reaction given the patch size, 277 lines more code to maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org