You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "tju-yxq (via GitHub)" <gi...@apache.org> on 2026/10/02 13:48:48 UTC
[PR] fix(web): stop showing the creation time as the delivery time [rocketmq-dashboard]
tju-yxq opened a new pull request, #5397:
URL: https://github.com/apache/rocketmq-dashboard/pull/5397
### Which Issue(s) This PR Fixes
- Fixes #5396
### Brief Description
The "Delivered At" column rendered `formatUtcDateTime(record.deliveredAt ?? record.createdAt)`, so every undelivered record (PENDING/SENDING/RETRY_WAIT/FAILED) showed its creation timestamp as the delivery time — a rejected webhook send looked delivered at the moment it was queued. The detail drawer renders the same field without the fallback (`formatUtcDateTime` returns `-` for null), so the page contradicted itself row by row.
The column now renders `deliveredAt` alone: undelivered records show `-` exactly like the drawer, delivered records are unchanged.
### How Did You Test This Change?
```
cd web && npm test -- NotificationDeliveriesPage.test.tsx --run
Test Files 1 passed (1)
Tests 7 passed (7)
```
One new test loads a FAILED and a DELIVERED record side by side and asserts, scoped to each row: the failed row's cells do not contain the formatted creation time and include the `-` placeholder, while the delivered row shows the formatted `deliveredAt`. The six existing tests (retry flows, double-submit guard, filter changes, UTC time-range forwarding) pass unchanged.
```
cd web && npm run lint
✖ 10 problems (0 errors, 10 warnings) # all pre-existing warnings in files this PR does not touch
```
```
cd web && npx tsc -b --force
(no output — exit 0)
```
### Checklist
- [x] One coherent change; unrelated modifications are not bundled in
- [x] Commit subject follows Conventional Commits
- [x] Tests added or updated for non-trivial changes, test methods named `...Test`
- [x] New UI text has both Chinese and English entries under `web/src/i18n/` (no new UI text)
- [x] Architecture constraints stay green (`mvn test` runs the ArchUnit checks) (no Java changes)
- [x] New source files carry the ASF license header (no new source files)
- [ ] Documentation touched where behaviour changed (display correction only)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): stop showing the creation time as the delivery time [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #5397: fix(web): stop showing the creation time as the delivery time
URL: https://github.com/apache/rocketmq-dashboard/pull/5397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): stop showing the creation time as the delivery time [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5397:
URL: https://github.com/apache/rocketmq-dashboard/pull/5397#issuecomment-6091522520
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org