You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/11 22:29:15 UTC

[GitHub] [incubator-superset] craig-rueda commented on a change in pull request #11207: feat: Added setup for running Cypress tests in docker locally

craig-rueda commented on a change in pull request #11207:
URL: https://github.com/apache/incubator-superset/pull/11207#discussion_r541364309



##########
File path: docker-compose.yml
##########
@@ -43,8 +44,6 @@ services:
     restart: unless-stopped
     ports:
       - "127.0.0.1:5432:5432"
-    volumes:

Review comment:
       We should keep the volumes here, as folks tend to use them across container re-builds. If you need to delete PG data, just run `docker-compose down -v`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org