You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/14 05:07:25 UTC
[GitHub] [kafka] kkonstantine commented on a change in pull request #9407: MINOR: Merge log error to avoid double error
kkonstantine commented on a change in pull request #9407:
URL: https://github.com/apache/kafka/pull/9407#discussion_r504402600
##########
File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java
##########
@@ -184,8 +184,7 @@ private void doRun() throws InterruptedException {
execute();
} catch (Throwable t) {
- log.error("{} Task threw an uncaught and unrecoverable exception", this, t);
- log.error("{} Task is being killed and will not recover until manually restarted", this);
+ log.error("{} Task threw an uncaught and unrecoverable exception, task is being killed and will not recover until manually restarted", this, t);
Review comment:
I'd suggest keeping the format slightly closer to what we had before. Specifically:
`Task threw an uncaught and unrecoverable exception. Task is being killed and will not recover until manually restarted`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org