You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/23 09:15:10 UTC
[GitHub] [incubator-nuttx-apps] PetervdPerk-NXP opened a new pull request #494: Candump: Fix printf compile warning regarding time_t
PetervdPerk-NXP opened a new pull request #494:
URL: https://github.com/apache/incubator-nuttx-apps/pull/494
## Summary
Candump original Linux version (linux-can/can-utils) assumes that time_t is a long integer whereas in NuttX time_t is a unsigned integer. Thus giving compiler printf warnings, this PR removes the warnings by using the correct specifier.
## Impact
Minimal removes compile warnings, no functional change.
## Testing
Tested on PX4-Firmware also fixes PX4/PX4-Autopilot#16251
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #494: Candump: Fix printf compile warning regarding time_t
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #494:
URL: https://github.com/apache/incubator-nuttx-apps/pull/494
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] PetervdPerk-NXP commented on pull request #494: Candump: Fix printf compile warning regarding time_t
Posted by GitBox <gi...@apache.org>.
PetervdPerk-NXP commented on pull request #494:
URL: https://github.com/apache/incubator-nuttx-apps/pull/494#issuecomment-732167431
The candump.c follows the original formatting from the original source (https://github.com/linux-can/can-utils/blob/master/candump.c) with some minor changes to work on NuttX.
I could change the formatting to the NuttX style however, this means it would be harder to backport changes from linux-can/can-utils repository. Thus why also initially the code has been contributed in the linux-can/can-utils coding style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] davids5 commented on pull request #494: Candump: Fix printf compile warning regarding time_t
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #494:
URL: https://github.com/apache/incubator-nuttx-apps/pull/494#issuecomment-732089789
@PetervdPerk-NXP Would you please resolve the formatting issues
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org