You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/03/23 02:38:49 UTC
[GitHub] [incubator-inlong] kipshi opened a new pull request #3319: [INLONG-3317] Change agent heartbeat/report interval to 10s
kipshi opened a new pull request #3319:
URL: https://github.com/apache/incubator-inlong/pull/3319
### Title Name: [INLONG-3317] Change agent heartbeat/report interval to 10s
where *XYZ* should be replaced by the actual issue number.
Fixes #3317
### Motivation
### Modifications
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #3319: [INLONG-3317][Agent] Change the default heartbeat and report interval to 10s
Posted by GitBox <gi...@apache.org>.
healchow merged pull request #3319:
URL: https://github.com/apache/incubator-inlong/pull/3319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] EMsnap commented on a change in pull request #3319: [INLONG-3317][Agent] Change the default heartbeat and report interval to 10s
Posted by GitBox <gi...@apache.org>.
EMsnap commented on a change in pull request #3319:
URL: https://github.com/apache/incubator-inlong/pull/3319#discussion_r832794981
##########
File path: inlong-agent/agent-core/src/main/java/org/apache/inlong/agent/core/task/TaskPositionManager.java
##########
@@ -91,13 +97,15 @@ private Runnable taskPositionFlushThread() {
JobProfile jobProfile = jobConfDb.getJobById(jobId);
if (jobProfile == null) {
LOGGER.warn("jobProfile {} cannot be found in db, "
- + "might be deleted by standalone mode, now delete job position in memory", jobId);
+ + "might be deleted by standalone mode, now delete job position in memory", jobId);
deleteJobPosition(jobId);
continue;
}
flushJobProfile(jobId, jobProfile);
}
- TimeUnit.SECONDS.sleep(DEFAULT_FLUSH_TIMEOUT);
+ int flushTime = conf.getInt(AGENT_HEARTBEAT_INTERVAL,
+ DEFAULT_AGENT_FETCHER_INTERVAL);
Review comment:
Here the fetcher timeout may be inconsistant with the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] kipshi commented on a change in pull request #3319: [INLONG-3317][Agent] Change the default heartbeat and report interval to 10s
Posted by GitBox <gi...@apache.org>.
kipshi commented on a change in pull request #3319:
URL: https://github.com/apache/incubator-inlong/pull/3319#discussion_r832797228
##########
File path: inlong-agent/agent-core/src/main/java/org/apache/inlong/agent/core/task/TaskPositionManager.java
##########
@@ -91,13 +97,15 @@ private Runnable taskPositionFlushThread() {
JobProfile jobProfile = jobConfDb.getJobById(jobId);
if (jobProfile == null) {
LOGGER.warn("jobProfile {} cannot be found in db, "
- + "might be deleted by standalone mode, now delete job position in memory", jobId);
+ + "might be deleted by standalone mode, now delete job position in memory", jobId);
deleteJobPosition(jobId);
continue;
}
flushJobProfile(jobId, jobProfile);
}
- TimeUnit.SECONDS.sleep(DEFAULT_FLUSH_TIMEOUT);
+ int flushTime = conf.getInt(AGENT_HEARTBEAT_INTERVAL,
+ DEFAULT_AGENT_FETCHER_INTERVAL);
Review comment:
In old cold, HeartBeatManager use the same constant(DEFAULT_FLUSH_TIMEOUT) with TaskPositionManager, so i use HEART_BEAT_INTERVAL instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] EMsnap commented on a change in pull request #3319: [INLONG-3317][Agent] Change the default heartbeat and report interval to 10s
Posted by GitBox <gi...@apache.org>.
EMsnap commented on a change in pull request #3319:
URL: https://github.com/apache/incubator-inlong/pull/3319#discussion_r832815702
##########
File path: inlong-agent/agent-core/src/main/java/org/apache/inlong/agent/core/task/TaskPositionManager.java
##########
@@ -91,13 +97,15 @@ private Runnable taskPositionFlushThread() {
JobProfile jobProfile = jobConfDb.getJobById(jobId);
if (jobProfile == null) {
LOGGER.warn("jobProfile {} cannot be found in db, "
- + "might be deleted by standalone mode, now delete job position in memory", jobId);
+ + "might be deleted by standalone mode, now delete job position in memory", jobId);
deleteJobPosition(jobId);
continue;
}
flushJobProfile(jobId, jobProfile);
}
- TimeUnit.SECONDS.sleep(DEFAULT_FLUSH_TIMEOUT);
+ int flushTime = conf.getInt(AGENT_HEARTBEAT_INTERVAL,
+ DEFAULT_AGENT_FETCHER_INTERVAL);
Review comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org