You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Jark Wu (Jira)" <ji...@apache.org> on 2019/12/03 02:22:00 UTC
[jira] [Updated] (FLINK-14649) Flatten all the connector properties
keys to make it easy to configure in DDL
[ https://issues.apache.org/jira/browse/FLINK-14649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jark Wu updated FLINK-14649:
----------------------------
Description:
There are some connector properties are lists. For example, Kafka connector specific properties have to been set in the following way:
{code}
'connector.properties.0.key' = 'zookeeper.connect',
'connector.properties.0.value' = 'localhost:2181',
'connector.properties.1.key' = 'bootstrap.servers',
'connector.properties.1.value' = 'localhost:9092',
'connector.properties.2.key' = 'group.id',
'connector.properties.2.value' = 'testGroup',
{code}
It is complex and not intuitive to define in this way. In order to cooperate with DDL better, we propose to flatten all the property keys.
It has some disadvantage to define in this way.
- Users need to keep track of the indices
- The key space is not constant. Validation of keys would require prefix magic and wildcards. Like in TableFactories: `connector.propertie.#.key`.
- It is complex and not intuitive to define and document.
See FLIP-86 for the proposed new properties.
was:
There are some connector properties are lists. For example, Kafka connector specific properties have to been set in the following way:
{code}
'connector.properties.0.key' = 'zookeeper.connect',
'connector.properties.0.value' = 'localhost:2181',
'connector.properties.1.key' = 'bootstrap.servers',
'connector.properties.1.value' = 'localhost:9092',
'connector.properties.2.key' = 'group.id',
'connector.properties.2.value' = 'testGroup',
{code}
It woule be better to flatten the properties for user friendly, for example:
{code}
'connector.zookeeper.connect' = 'localhost:2181',
'connector.bootstrap.servers' = 'localhost:9092',
'connector.group.id' = 'testGroup',
{code}
> Flatten all the connector properties keys to make it easy to configure in DDL
> -----------------------------------------------------------------------------
>
> Key: FLINK-14649
> URL: https://issues.apache.org/jira/browse/FLINK-14649
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / API
> Reporter: Jark Wu
> Assignee: Leonard Xu
> Priority: Major
>
> There are some connector properties are lists. For example, Kafka connector specific properties have to been set in the following way:
> {code}
> 'connector.properties.0.key' = 'zookeeper.connect',
> 'connector.properties.0.value' = 'localhost:2181',
> 'connector.properties.1.key' = 'bootstrap.servers',
> 'connector.properties.1.value' = 'localhost:9092',
> 'connector.properties.2.key' = 'group.id',
> 'connector.properties.2.value' = 'testGroup',
> {code}
> It is complex and not intuitive to define in this way. In order to cooperate with DDL better, we propose to flatten all the property keys.
> It has some disadvantage to define in this way.
> - Users need to keep track of the indices
> - The key space is not constant. Validation of keys would require prefix magic and wildcards. Like in TableFactories: `connector.propertie.#.key`.
> - It is complex and not intuitive to define and document.
> See FLIP-86 for the proposed new properties.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)