Re: [PR] HDDS-14103. Create an option to suppress/unsuppress containers from report [ozone]

["sreejasahithi (via GitHub)" <gi...@apache.org>]

sreejasahithi commented on code in PR #9719:
URL: https://github.com/apache/ozone/pull/9719#discussion_r3007686382


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java:
##########


Review Comment:
   Here I think you can add the following here in buildAuditMap
   
   // Add this block for traceability
   if (suppressed != null) {
     auditMap.put("suppressed", String.valueOf(suppressed));
   }



##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java:
##########
@@ -487,20 +487,27 @@ public ContainerListResult listContainer(long startContainerID,
   public ContainerListResult listContainer(long startContainerID,
       int count, HddsProtos.LifeCycleState state,
       HddsProtos.ReplicationFactor factor) throws IOException {
-    return listContainerInternal(startContainerID, count, state, factor, null, null);
+    return listContainerInternal(startContainerID, count, state, factor, null, null, null);
   }
 
   private ContainerListResult listContainerInternal(long startContainerID, int count,
       HddsProtos.LifeCycleState state,
       HddsProtos.ReplicationFactor factor,
       HddsProtos.ReplicationType replicationType,
-      ReplicationConfig repConfig) throws IOException {
+      ReplicationConfig repConfig,
+      Boolean suppressed) throws IOException {
     boolean auditSuccess = true;
     Map<String, String> auditMap = buildAuditMap(startContainerID, count, state, factor, replicationType, repConfig);

Review Comment:
   here you can pass 'suppressed' as the last argument.
   Adding this ensures that the intent of the query is preserved in the audit logs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org