You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Philip Zeyliger (Code Review)" <ge...@cloudera.org> on 2018/01/25 17:07:06 UTC
[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9135
Change subject: IMPALA-6410: compare_branches: use looser expression
......................................................................
IMPALA-6410: compare_branches: use looser expression
We've already got one use of "Cherry-pick:" instead of "Cherry-picks:"
in master, so I'm loosening the regular expression a bit. (And
converting the string search into a case-insensitive regexp search.)
I tested this by running it manually and inspecting results.
Change-Id: Ie3f75d9e01d2760571547b1a1a5f42bbc8455a05
---
M bin/compare_branches.py
1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/9135/1
--
To view, visit http://gerrit.cloudera.org:8080/9135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3f75d9e01d2760571547b1a1a5f42bbc8455a05
Gerrit-Change-Number: 9135
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9135 )
Change subject: IMPALA-6410: compare_branches: use looser expression
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f75d9e01d2760571547b1a1a5f42bbc8455a05
Gerrit-Change-Number: 9135
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jan 2018 22:45:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9135 )
Change subject: IMPALA-6410: compare_branches: use looser expression
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f75d9e01d2760571547b1a1a5f42bbc8455a05
Gerrit-Change-Number: 9135
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jan 2018 00:37:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Hello Taras Bobrovytsky, Lars Volker, Jim Apple,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9135
to look at the new patch set (#3).
Change subject: IMPALA-6410: compare_branches: use looser expression
......................................................................
IMPALA-6410: compare_branches: use looser expression
We've already got one use of "Cherry-pick:" instead of "Cherry-picks:"
in master, so I'm loosening the regular expression a bit. (And
converting the string search into a case-insensitive regexp search.)
I tested this by running it manually and inspecting results.
Change-Id: Ie3f75d9e01d2760571547b1a1a5f42bbc8455a05
---
M bin/compare_branches.py
1 file changed, 7 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/9135/3
--
To view, visit http://gerrit.cloudera.org:8080/9135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie3f75d9e01d2760571547b1a1a5f42bbc8455a05
Gerrit-Change-Number: 9135
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9135 )
Change subject: IMPALA-6410: compare_branches: use looser expression
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1807/
--
To view, visit http://gerrit.cloudera.org:8080/9135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f75d9e01d2760571547b1a1a5f42bbc8455a05
Gerrit-Change-Number: 9135
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jan 2018 19:06:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9135 )
Change subject: IMPALA-6410: compare_branches: use looser expression
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9135/2/bin/compare_branches.py
File bin/compare_branches.py:
http://gerrit.cloudera.org:8080/#/c/9135/2/bin/compare_branches.py@107
PS2, Line 107: .?
> I don't think we want an unlimited number of chars (the "*" operator).
Done
http://gerrit.cloudera.org:8080/#/c/9135/2/bin/compare_branches.py@236
PS2, Line 236: skip_commits_matching = options.skip_commits_matching.format(
> I think makes more sense to use format here.
Done
--
To view, visit http://gerrit.cloudera.org:8080/9135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f75d9e01d2760571547b1a1a5f42bbc8455a05
Gerrit-Change-Number: 9135
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jan 2018 00:29:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Hello Taras Bobrovytsky, Lars Volker, Jim Apple,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9135
to look at the new patch set (#2).
Change subject: IMPALA-6410: compare_branches: use looser expression
......................................................................
IMPALA-6410: compare_branches: use looser expression
We've already got one use of "Cherry-pick:" instead of "Cherry-picks:"
in master, so I'm loosening the regular expression a bit. (And
converting the string search into a case-insensitive regexp search.)
I tested this by running it manually and inspecting results.
Change-Id: Ie3f75d9e01d2760571547b1a1a5f42bbc8455a05
---
M bin/compare_branches.py
1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/9135/2
--
To view, visit http://gerrit.cloudera.org:8080/9135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie3f75d9e01d2760571547b1a1a5f42bbc8455a05
Gerrit-Change-Number: 9135
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9135 )
Change subject: IMPALA-6410: compare_branches: use looser expression
......................................................................
IMPALA-6410: compare_branches: use looser expression
We've already got one use of "Cherry-pick:" instead of "Cherry-picks:"
in master, so I'm loosening the regular expression a bit. (And
converting the string search into a case-insensitive regexp search.)
I tested this by running it manually and inspecting results.
Change-Id: Ie3f75d9e01d2760571547b1a1a5f42bbc8455a05
Reviewed-on: http://gerrit.cloudera.org:8080/9135
Reviewed-by: Taras Bobrovytsky <tb...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M bin/compare_branches.py
1 file changed, 7 insertions(+), 6 deletions(-)
Approvals:
Taras Bobrovytsky: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3f75d9e01d2760571547b1a1a5f42bbc8455a05
Gerrit-Change-Number: 9135
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9135 )
Change subject: IMPALA-6410: compare_branches: use looser expression
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9135/1/bin/compare_branches.py
File bin/compare_branches.py:
http://gerrit.cloudera.org:8080/#/c/9135/1/bin/compare_branches.py@107
PS1, Line 107: (fo
> nit: While you're here, should we add "not [for|to] {branch}" instead?
Done
--
To view, visit http://gerrit.cloudera.org:8080/9135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f75d9e01d2760571547b1a1a5f42bbc8455a05
Gerrit-Change-Number: 9135
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jan 2018 19:58:21 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9135 )
Change subject: IMPALA-6410: compare_branches: use looser expression
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9135/2/bin/compare_branches.py
File bin/compare_branches.py:
http://gerrit.cloudera.org:8080/#/c/9135/2/bin/compare_branches.py@107
PS2, Line 107: .*
I don't think we want an unlimited number of chars (the "*" operator).
I think we want this regex:
"Cherry-pick.?:.?not (for|to) {branch}"
http://gerrit.cloudera.org:8080/#/c/9135/2/bin/compare_branches.py@236
PS2, Line 236: skip_commits_matching = options.skip_commits_matching.replace(
I think makes more sense to use format here.
This should work:
options.skip_commits_matching.format(branch=options.target_branch)
--
To view, visit http://gerrit.cloudera.org:8080/9135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f75d9e01d2760571547b1a1a5f42bbc8455a05
Gerrit-Change-Number: 9135
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jan 2018 20:11:24 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9135 )
Change subject: IMPALA-6410: compare_branches: use looser expression
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9135/1/bin/compare_branches.py
File bin/compare_branches.py:
http://gerrit.cloudera.org:8080/#/c/9135/1/bin/compare_branches.py@107
PS1, Line 107: for
nit: While you're here, should we add "not [for|to] {branch}" instead?
--
To view, visit http://gerrit.cloudera.org:8080/9135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f75d9e01d2760571547b1a1a5f42bbc8455a05
Gerrit-Change-Number: 9135
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jan 2018 17:10:58 +0000
Gerrit-HasComments: Yes