You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/27 16:10:07 UTC

[GitHub] [incubator-mxnet] JonTanS edited a comment on pull request #17462: Updated PartialSortSmallK for LT support

JonTanS edited a comment on pull request #17462:
URL: https://github.com/apache/incubator-mxnet/pull/17462#issuecomment-618596980


   After syncing up with @access2rohit, we found that a test already exists within the current suite of tests.
   
   There is currently a test written in tests/python/gpu/test_operator_gpu.py, but it does not run on the large tensor nightly tests because GPU context is not tested on nightly. This verifies that this change indeed fixes the topk gpu call.
   
   In Summary:
   No Change 
   LT On - Failed
   LT Off - Pass
   Change
   LT On - Pass
   LT Off - Pass
   
   
   Command to Execute:
   MXNET_TEST_COUNT=1 nosetests --logging-level=DEBUG --verbose -s tests/python/gpu/test_operator_gpu.py:test_order
   
   **No Change, LT Off**
   ```
   Flags Used:
   [✔ CUDA, ✔ CUDNN, ✔ NCCL, ✔ CUDA_RTC, ✖ TENSORRT, ✔ CPU_SSE, ✔ CPU_SSE2, ✔ CPU_SSE3, ✔ CPU_SSE4_1, ✔ CPU_SSE4_2, ✖ CPU_SSE4A, ✔ CPU_AVX, ✖ CPU_AVX2, ✔ OPENMP, ✖ SSE, ✔ F16C, ✖ JEMALLOC, ✔ BLAS_OPEN, ✖ BLAS_ATLAS, ✖ BLAS_MKL, ✖ BLAS_APPLE, ✔ LAPACK, ✔ MKLDNN, ✔ OPENCV, ✖ CAFFE, ✖ PROFILER, ✖ DIST_KVSTORE, ✖ CXX14, ✖ INT64_TENSOR_SIZE, ✔ SIGNAL_HANDLER, ✖ DEBUG, ✖ TVM_OP]
   
   MXNET_TEST_COUNT=1 nosetests --logging-level=DEBUG --verbose -s tests/python/gpu/test_operator_gpu.py:test_order
   
   (2, 5)
   [INFO] Setting module np/mx/python random seeds, use MXNET_MODULE_SEED=548212641 to reproduce.
   test_operator_gpu.test_order ... [DEBUG] Setting test np/mx/python random seeds, use MXNET_TEST_SEED=1891020679 to reproduce.
   [18:15:41] ../src/base.cc:84: Upgrade advisory: this mxnet has been built against cuDNN lib version 7501, which is older than the oldest version tested by CI (7600).  Set MXNET_CUDNN_LIB_CHECKING=0 to quiet this warning.
   ok
   
   ----------------------------------------------------------------------
   Ran 1 test in 8.737s
   
   OK
   ```
   
   
   **No Change, LT On**
   ```
   Flags Used:
   [✔ CUDA, ✔ CUDNN, ✔ NCCL, ✔ CUDA_RTC, ✖ TENSORRT, ✔ CPU_SSE, ✔ CPU_SSE2, ✔ CPU_SSE3, ✔ CPU_SSE4_1, ✔ CPU_SSE4_2, ✖ CPU_SSE4A, ✔ CPU_AVX, ✖ CPU_AVX2, ✔ OPENMP, ✖ SSE, ✔ F16C, ✖ JEMALLOC, ✔ BLAS_OPEN, ✖ BLAS_ATLAS, ✖ BLAS_MKL, ✖ BLAS_APPLE, ✔ LAPACK, ✔ MKLDNN, ✔ OPENCV, ✖ CAFFE, ✖ PROFILER, ✖ DIST_KVSTORE, ✖ CXX14, ✔ INT64_TENSOR_SIZE, ✔ SIGNAL_HANDLER, ✖ DEBUG, ✖ TVM_OP]
   
   MXNET_TEST_COUNT=1 nosetests --logging-level=DEBUG --verbose -s tests/python/gpu/test_operator_gpu.py:test_order
   (2, 5)
   [INFO] Setting module np/mx/python random seeds, use MXNET_MODULE_SEED=548212641 to reproduce.
   test_operator_gpu.test_order ... [DEBUG] Setting test np/mx/python random seeds, use MXNET_TEST_SEED=1891020679 to reproduce.
   [17:55:51] ../src/base.cc:84: Upgrade advisory: this mxnet has been built against cuDNN lib version 7501, which is older than the oldest version tested by CI (7600).  Set MXNET_CUDNN_LIB_CHECKING=0 to quiet this warning.
   [INFO] Setting test np/mx/python random seeds, use MXNET_TEST_SEED=1891020679 to reproduce.
   ERROR
   
   ======================================================================
   ERROR: test_operator_gpu.test_order
   ----------------------------------------------------------------------
   Traceback (most recent call last):
     File "/home/ubuntu/anaconda3/lib/python3.6/site-packages/nose/case.py", line 197, in runTest
       self.test(*self.arg)
     File "/home/ubuntu/anaconda3/lib/python3.6/site-packages/nose/util.py", line 620, in newfunc
       return func(*arg, **kw)
     File "/home/ubuntu/incubator-mxnet/tests/python/gpu/../unittest/common.py", line 215, in test_new
       orig_test(*args, **kwargs)
     File "/home/ubuntu/incubator-mxnet/tests/python/gpu/../unittest/test_ndarray.py", line 948, in test_order
       nd_ret_topk = mx.nd.topk(large_matrix_nd, axis=1, ret_typ="indices", k=5, is_ascend=False).asnumpy()
     File "/home/ubuntu/incubator-mxnet/python/mxnet/ndarray/ndarray.py", line 2566, in asnumpy
       ctypes.c_size_t(data.size)))
     File "/home/ubuntu/incubator-mxnet/python/mxnet/base.py", line 246, in check_call
       raise get_last_ffi_error()
   mxnet.base.MXNetError: Traceback (most recent call last):
     File "../include/mshadow/./stream_gpu-inl.h", line 81
   CUDA: Check failed: e == cudaSuccess: an illegal memory access was encountered
   -------------------- >> begin captured logging << --------------------
   root: INFO: NumPy-shape semantics has been activated in your code. This is required for creating and manipulating scalar and zero-size tensors, which were not supported in MXNet before, as in the official NumPy library. Please DO NOT manually deactivate this semantics while using `mxnet.numpy` and `mxnet.numpy_extension` modules.
   common: INFO: Setting module np/mx/python random seeds, use MXNET_MODULE_SEED=548212641 to reproduce.
   common: DEBUG: Setting test np/mx/python random seeds, use MXNET_TEST_SEED=1891020679 to reproduce.
   common: INFO: Setting test np/mx/python random seeds, use MXNET_TEST_SEED=1891020679 to reproduce.
   --------------------- >> end captured logging << ---------------------
   
   ----------------------------------------------------------------------
   Ran 1 test in 76.899s
   
   FAILED (errors=1)
   ```
   
   
   **Change, LT Off**
   ```
   Flags
   [✔ CUDA, ✔ CUDNN, ✔ NCCL, ✔ CUDA_RTC, ✖ TENSORRT, ✔ CPU_SSE, ✔ CPU_SSE2, ✔ CPU_SSE3, ✔ CPU_SSE4_1, ✔ CPU_SSE4_2, ✖ CPU_SSE4A, ✔ CPU_AVX, ✖ CPU_AVX2, ✔ OPENMP, ✖ SSE, ✔ F16C, ✖ JEMALLOC, ✔ BLAS_OPEN, ✖ BLAS_ATLAS, ✖ BLAS_MKL, ✖ BLAS_APPLE, ✔ LAPACK, ✔ MKLDNN, ✔ OPENCV, ✖ CAFFE, ✖ PROFILER, ✖ DIST_KVSTORE, ✖ CXX14, ✖ INT64_TENSOR_SIZE, ✔ SIGNAL_HANDLER, ✖ DEBUG, ✖ TVM_OP]
   
   MXNET_TEST_COUNT=1 nosetests --logging-level=DEBUG --verbose -s tests/python/gpu/test_operator_gpu.py:test_order
   
   (2, 5)
   [INFO] Setting module np/mx/python random seeds, use MXNET_MODULE_SEED=548212641 to reproduce.
   test_operator_gpu.test_order ... [DEBUG] Setting test np/mx/python random seeds, use MXNET_TEST_SEED=1891020679 to reproduce.
   [18:28:05] ../src/base.cc:84: Upgrade advisory: this mxnet has been built against cuDNN lib version 7501, which is older than the oldest version tested by CI (7600).  Set MXNET_CUDNN_LIB_CHECKING=0 to quiet this warning.
   ok
   
   ----------------------------------------------------------------------
   Ran 1 test in 8.652s
   
   OK
   ```
   
   **Change, LT On**
   ```
   [✔ CUDA, ✔ CUDNN, ✔ NCCL, ✔ CUDA_RTC, ✖ TENSORRT, ✔ CPU_SSE, ✔ CPU_SSE2, ✔ CPU_SSE3, ✔ CPU_SSE4_1, ✔ CPU_SSE4_2, ✖ CPU_SSE4A, ✔ CPU_AVX, ✖ CPU_AVX2, ✔ OPENMP, ✖ SSE, ✔ F16C, ✖ JEMALLOC, ✔ BLAS_OPEN, ✖ BLAS_ATLAS, ✖ BLAS_MKL, ✖ BLAS_APPLE, ✔ LAPACK, ✔ MKLDNN, ✔ OPENCV, ✖ CAFFE, ✖ PROFILER, ✖ DIST_KVSTORE, ✖ CXX14, ✔ INT64_TENSOR_SIZE, ✔ SIGNAL_HANDLER, ✖ DEBUG, ✖ TVM_OP]
   
   MXNET_TEST_COUNT=1 nosetests --logging-level=DEBUG --verbose -s tests/python/gpu/test_operator_gpu.py:test_order
   
   (2, 5)
   [INFO] Setting module np/mx/python random seeds, use MXNET_MODULE_SEED=548212641 to reproduce.
   test_operator_gpu.test_order ... [DEBUG] Setting test np/mx/python random seeds, use MXNET_TEST_SEED=1891020679 to reproduce.
   [18:42:21] ../src/base.cc:84: Upgrade advisory: this mxnet has been built against cuDNN lib version 7501, which is older than the oldest version tested by CI (7600).  Set MXNET_CUDNN_LIB_CHECKING=0 to quiet this warning.
   ok
   
   ----------------------------------------------------------------------
   Ran 1 test in 9.185s
   
   OK
   ```
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org