You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/09 13:34:23 UTC

[GitHub] [pulsar] nodece commented on a diff in pull request #17017: [improve][broker] Add close function worker

nodece commented on code in PR #17017:
URL: https://github.com/apache/pulsar/pull/17017#discussion_r941347611


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -411,6 +411,8 @@ public CompletableFuture<Void> closeAsync() {
             LOG.info("Closing PulsarService");
             state = State.Closing;
 
+            functionWorkerService.ifPresent(WorkerService::stop);

Review Comment:
   That is cli code, not PulsarService, we also need to add close in PulsarService.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org