You are viewing a plain text version of this content. The canonical link for it is here.
Posted to xmlrpc-dev@ws.apache.org by Jochen Wiedmann <jo...@freenet.de> on 2004/06/16 10:05:53 UTC

Patch: Create sources zip file in build.xml

Hi,

the following makes the "jar" target create a file called
xmlrpc-<version>-src.zip as well. This file contains the sources.

The reason for doing so is, that such files are quite convenient for
attaching them to the Java debugger. For example, in Eclipse I am always
adding the jar file and the source file as well, if possible.

Jochen




Index: build.xml
===================================================================
RCS file: /home/cvspublic/ws-xmlrpc/build.xml,v
retrieving revision 1.25
diff -u -r1.25 build.xml
--- build.xml	21 May 2003 15:58:23 -0000	1.25
+++ build.xml	16 Jun 2004 07:58:54 -0000
@@ -184,6 +184,9 @@
       <fileset dir="${build.dest}"
       excludes="**/xmlrpc/*,**/fesi/*,**/secure/*"/>
     </jar>
+    <zip zipfile="${build.dir}/${final.name}-src.zip">
+       <fileset dir="src/java"/>
+    </zip>
   </target>
 
   <!-- 


Re: Patch: Create sources zip file in build.xml

Posted by "Daniel L. Rall" <dl...@finemaltcoding.com>.
Jochen Wiedmann wrote:
> On Do, 2004-06-17 at 03:32, Daniel Rall wrote:
> 
>>Jochen, this sounds like a reasonable activity for a target other than "jar" 
>>(perhaps a new target which has "jar" as a dependency).
> 
> Fine for me. I'd like to suggest, though, that the zip file is added to
> the binary distribution as well, if noone else minds. How about that?

I'd rather request that people who want this download both the binary and 
source distributions, as I assume it'll fall more on the exception than rule 
side of things.

>>However, it would be 
>>useful if the Maven-based build had parity here.
> 
> Never used Maven, so I don't know what that's supposed to mean?

The Maven build should do the same thing as the Ant-based build.

Re: Patch: Create sources zip file in build.xml

Posted by Jochen Wiedmann <jo...@freenet.de>.
On Do, 2004-06-17 at 03:32, Daniel Rall wrote:
> Jochen, this sounds like a reasonable activity for a target other than "jar" 
> (perhaps a new target which has "jar" as a dependency).

Fine for me. I'd like to suggest, though, that the zip file is added to
the binary distribution as well, if noone else minds. How about that?

>   However, it would be 
> useful if the Maven-based build had parity here.

Never used Maven, so I don't know what that's supposed to mean?


Jochen


Re: Patch: Create sources zip file in build.xml

Posted by Daniel Rall <dl...@collab.net>.
Jochen, this sounds like a reasonable activity for a target other than "jar" 
(perhaps a new target which has "jar" as a dependency).  However, it would be 
useful if the Maven-based build had parity here.

- Dan

Jochen Wiedmann wrote:
> Hi,
> 
> the following makes the "jar" target create a file called
> xmlrpc-<version>-src.zip as well. This file contains the sources.
> 
> The reason for doing so is, that such files are quite convenient for
> attaching them to the Java debugger. For example, in Eclipse I am always
> adding the jar file and the source file as well, if possible.
 >
> Index: build.xml
> ===================================================================
> RCS file: /home/cvspublic/ws-xmlrpc/build.xml,v
> retrieving revision 1.25
> diff -u -r1.25 build.xml
> --- build.xml	21 May 2003 15:58:23 -0000	1.25
> +++ build.xml	16 Jun 2004 07:58:54 -0000
> @@ -184,6 +184,9 @@
>        <fileset dir="${build.dest}"
>        excludes="**/xmlrpc/*,**/fesi/*,**/secure/*"/>
>      </jar>
> +    <zip zipfile="${build.dir}/${final.name}-src.zip">
> +       <fileset dir="src/java"/>
> +    </zip>
>    </target>
>  
>    <!--