You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2012/08/14 02:39:38 UTC
[jira] [Created] (HADOOP-8696) Trash.moveToTrash should be more
helpful on errors
Steve Loughran created HADOOP-8696:
--------------------------------------
Summary: Trash.moveToTrash should be more helpful on errors
Key: HADOOP-8696
URL: https://issues.apache.org/jira/browse/HADOOP-8696
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 1.0.3
Reporter: Steve Loughran
Priority: Minor
When {{Trash.moveToTrash()}} catches an exception, it wraps it with an IOException: {{new IOException("Failed to move to trash: "+path).initCause(cause);}} -but this doesn't include the exception name in the end-user string.
As a result, people see the "Failed to move to trash" exception, but nobody knows what went wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8696) Trash.moveToTrash should be more
helpful on errors
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433808#comment-13433808 ]
Steve Loughran commented on HADOOP-8696:
----------------------------------------
Simple fix: include {{cause.toString()}} in the error string.
> Trash.moveToTrash should be more helpful on errors
> --------------------------------------------------
>
> Key: HADOOP-8696
> URL: https://issues.apache.org/jira/browse/HADOOP-8696
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 1.0.3
> Reporter: Steve Loughran
> Priority: Minor
>
> When {{Trash.moveToTrash()}} catches an exception, it wraps it with an IOException: {{new IOException("Failed to move to trash: "+path).initCause(cause);}} -but this doesn't include the exception name in the end-user string.
> As a result, people see the "Failed to move to trash" exception, but nobody knows what went wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8696) Trash.moveToTrash should be more
helpful on errors
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-8696:
--------------------------------
Labels: newbie (was: )
> Trash.moveToTrash should be more helpful on errors
> --------------------------------------------------
>
> Key: HADOOP-8696
> URL: https://issues.apache.org/jira/browse/HADOOP-8696
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 1.0.3
> Reporter: Steve Loughran
> Priority: Minor
> Labels: newbie
>
> When {{Trash.moveToTrash()}} catches an exception, it wraps it with an IOException: {{new IOException("Failed to move to trash: "+path).initCause(cause);}} -but this doesn't include the exception name in the end-user string.
> As a result, people see the "Failed to move to trash" exception, but nobody knows what went wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8696) Trash.moveToTrash should be more
helpful on errors
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446297#comment-13446297 ]
Steve Loughran commented on HADOOP-8696:
----------------------------------------
It didn't in the output we saw from the logs -the remote client got the error string but not the nested cause
> Trash.moveToTrash should be more helpful on errors
> --------------------------------------------------
>
> Key: HADOOP-8696
> URL: https://issues.apache.org/jira/browse/HADOOP-8696
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 1.0.3
> Reporter: Steve Loughran
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-8696.patch
>
>
> When {{Trash.moveToTrash()}} catches an exception, it wraps it with an IOException: {{new IOException("Failed to move to trash: "+path).initCause(cause);}} -but this doesn't include the exception name in the end-user string.
> As a result, people see the "Failed to move to trash" exception, but nobody knows what went wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8696) Trash.moveToTrash should be more
helpful on errors
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445915#comment-13445915 ]
Daryn Sharp commented on HADOOP-8696:
-------------------------------------
Doesn't putting the exception string in the message and the exception in the cause result in doubled up output of the error?
> Trash.moveToTrash should be more helpful on errors
> --------------------------------------------------
>
> Key: HADOOP-8696
> URL: https://issues.apache.org/jira/browse/HADOOP-8696
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 1.0.3
> Reporter: Steve Loughran
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-8696.patch
>
>
> When {{Trash.moveToTrash()}} catches an exception, it wraps it with an IOException: {{new IOException("Failed to move to trash: "+path).initCause(cause);}} -but this doesn't include the exception name in the end-user string.
> As a result, people see the "Failed to move to trash" exception, but nobody knows what went wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8696) Trash.moveToTrash should be more
helpful on errors
Posted by "Ivan Vladimirov Ivanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446071#comment-13446071 ]
Ivan Vladimirov Ivanov commented on HADOOP-8696:
------------------------------------------------
You are right Daryn.
I am assuming that there is a need, for some reason, for the exception message to contain details about the cause, independent of the ones that show up in the stack trace. It will be nice if Steve would clarify if this is what he had in mind.
> Trash.moveToTrash should be more helpful on errors
> --------------------------------------------------
>
> Key: HADOOP-8696
> URL: https://issues.apache.org/jira/browse/HADOOP-8696
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 1.0.3
> Reporter: Steve Loughran
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-8696.patch
>
>
> When {{Trash.moveToTrash()}} catches an exception, it wraps it with an IOException: {{new IOException("Failed to move to trash: "+path).initCause(cause);}} -but this doesn't include the exception name in the end-user string.
> As a result, people see the "Failed to move to trash" exception, but nobody knows what went wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8696) Trash.moveToTrash should be more
helpful on errors
Posted by "Ivan Vladimirov Ivanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Vladimirov Ivanov updated HADOOP-8696:
-------------------------------------------
Attachment: HADOOP-8696.patch
This patch is against "release-1.0.3".
This is my first contribution so don't be to harsh with me if I did something wrong :)
> Trash.moveToTrash should be more helpful on errors
> --------------------------------------------------
>
> Key: HADOOP-8696
> URL: https://issues.apache.org/jira/browse/HADOOP-8696
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 1.0.3
> Reporter: Steve Loughran
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-8696.patch
>
>
> When {{Trash.moveToTrash()}} catches an exception, it wraps it with an IOException: {{new IOException("Failed to move to trash: "+path).initCause(cause);}} -but this doesn't include the exception name in the end-user string.
> As a result, people see the "Failed to move to trash" exception, but nobody knows what went wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira