You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tuscany.apache.org by "Simon Laws (JIRA)" <de...@tuscany.apache.org> on 2011/07/15 11:03:00 UTC

[jira] [Commented] (TUSCANY-3898) Developing implementation.scala

    [ https://issues.apache.org/jira/browse/TUSCANY-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065786#comment-13065786 ] 

Simon Laws commented on TUSCANY-3898:
-------------------------------------

Hi Guilherme. 

I committed this patch but subsequently noticed that it doesn't look like you checked the "Grant license to ASF for inclusion in ASF works (as per the Apache License §5) " check box. At least I don't think you did but it's a little difficult to tell with the new JIRA GUI.  I need to see that checked to keep the code in the code base as it's saying that you have appropriate rights to the code changes in order to contribute them to Apache. Can you re-attach the patch with that box checked please. Remember to check that box for subsequent patches. 

On the patch itself. Be sure to add the Apache header to any source files you create. You missed one from ScalaException. I note the providers are not yet wired up to create the invoker so keep the patches coming. I look forward to seeing you add a test case!

Simon

> Developing implementation.scala
> -------------------------------
>
>                 Key: TUSCANY-3898
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-3898
>             Project: Tuscany
>          Issue Type: Improvement
>            Reporter: Guilherme Moraes Armigliatto
>            Assignee: Guilherme Moraes Armigliatto
>         Attachments: 3898-tuscany-guilherme
>
>
> Implement the implementation-scala-runtime module

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira