You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/06/17 20:10:42 UTC
Review Request 22687: Added logging to http error states.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22687/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1500
https://issues.apache.org/jira/browse/MESOS-1500
Repository: mesos-git
Description
-------
see summary
Diffs
-----
3rdparty/libprocess/src/http.cpp eb20380d6e3b3a027f03a85a0a572cae1939e1f9
Diff: https://reviews.apache.org/r/22687/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 22687: Added logging to http error states.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22687/#review46031
-----------------------------------------------------------
Bad patch!
Reviews applied: [22687]
Failed command: ./support/mesos-style.py
Error:
Checking 477 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo
3rdparty/libprocess/src/http.cpp:92: Lines should be <= 80 characters long [whitespace/line_length] [2]
Total errors found: 1
- Mesos ReviewBot
On June 17, 2014, 6:10 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22687/
> -----------------------------------------------------------
>
> (Updated June 17, 2014, 6:10 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1500
> https://issues.apache.org/jira/browse/MESOS-1500
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/http.cpp eb20380d6e3b3a027f03a85a0a572cae1939e1f9
>
> Diff: https://reviews.apache.org/r/22687/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 22687: Added logging to http error states.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22687/#review46149
-----------------------------------------------------------
Ship it!
Thanks! Committing this now.
3rdparty/libprocess/src/http.cpp
<https://reviews.apache.org/r/22687/#comment81378>
Looks like we don't need the string(...) here.
- Ben Mahler
On June 18, 2014, 8:09 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22687/
> -----------------------------------------------------------
>
> (Updated June 18, 2014, 8:09 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1500
> https://issues.apache.org/jira/browse/MESOS-1500
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/http.cpp eb20380d6e3b3a027f03a85a0a572cae1939e1f9
>
> Diff: https://reviews.apache.org/r/22687/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 22687: Added logging to http error states.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22687/
-----------------------------------------------------------
(Updated June 18, 2014, 1:09 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1500
https://issues.apache.org/jira/browse/MESOS-1500
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/src/http.cpp eb20380d6e3b3a027f03a85a0a572cae1939e1f9
Diff: https://reviews.apache.org/r/22687/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 22687: Added logging to http error states.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22687/#review46115
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/src/http.cpp
<https://reviews.apache.org/r/22687/#comment81300>
Seems a bit odd to have this in between the addr struct and the connect call, how about placing it in the beginning or above the addr struct declaration?
3rdparty/libprocess/src/http.cpp
<https://reviews.apache.org/r/22687/#comment81299>
Looks like we don't need the explicit "string(...)" since we're constructing it with a + constructed string, right?
- Ben Mahler
On June 18, 2014, 7:26 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22687/
> -----------------------------------------------------------
>
> (Updated June 18, 2014, 7:26 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1500
> https://issues.apache.org/jira/browse/MESOS-1500
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/http.cpp eb20380d6e3b3a027f03a85a0a572cae1939e1f9
>
> Diff: https://reviews.apache.org/r/22687/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 22687: Added logging to http error states.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22687/
-----------------------------------------------------------
(Updated June 18, 2014, 12:26 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
fixed style
Bugs: MESOS-1500
https://issues.apache.org/jira/browse/MESOS-1500
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/src/http.cpp eb20380d6e3b3a027f03a85a0a572cae1939e1f9
Diff: https://reviews.apache.org/r/22687/diff/
Testing
-------
make check
Thanks,
Dominic Hamon