[jira] [Comment Edited] (IGNITE-6842) Stop all nodes after test by default.

["Maxim Muzafarov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-6842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355588#comment-16355588 ] 

Maxim Muzafarov edited comment on IGNITE-6842 at 2/7/18 3:27 PM:
-----------------------------------------------------------------

Discussed in dev-list
  
{quote}*Anton Vinogradov*

We discussed with Dima privately, and decided
 1) We have to assert that there is no alive nodes at GridAbstractTest'sbeforeTestsStarted
 2) We have to kill all alive nodes (without force) at GridAbstractTest'safterTestsStopped
 3) In case of any exceptions at #2 we have to see test error
 4) We can get rid of all useless stopAllGrids at GridAbstractTest'ssubclasses.
{quote}
{quote}*Dmitry Pavlov*
{quote}
{quote}Yes, this solution allows to cover both cases:
 a) not stopped node from previous test and
 b) allows to remove useless code that stops Ignite nodes from each test.
{quote}
 


was (Author: mmuzaf):
Discussed in dev-list
 
{quote}*Anton Vinogradov*We discussed with Dima privately, and decided
1) We have to assert that there is no alive nodes at GridAbstractTest'sbeforeTestsStarted
2) We have to kill all alive nodes (without force) at GridAbstractTest'safterTestsStopped
3) In case of any exceptions at #2 we have to see test error
4) We can get rid of all useless stopAllGrids at GridAbstractTest'ssubclasses.{quote}
{quote}*Dmitry Pavlov*{quote}
{quote}Yes, this solution allows to cover both cases:
a) not stopped node from previous test and
b) allows to remove useless code that stops Ignite nodes from each test.{quote}
 

> Stop all nodes after test by default.
> -------------------------------------
>
>                 Key: IGNITE-6842
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6842
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Alexei Scherbakov
>            Assignee: Maxim Muzafarov
>            Priority: Major
>              Labels: newbie
>             Fix For: 2.5
>
>
> Currently it's required to manually call stopAllGrids() after test completion.
> This leads to errors in subsequent tests if someone forgets to call it and to additional boilerplate code in tests.
> Right choice is to make this default behavior.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)