You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/03/14 23:54:44 UTC
[jira] [Commented] (CB-6272) Fix subdir handling
[ https://issues.apache.org/jira/browse/CB-6272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935774#comment-13935774 ]
ASF GitHub Bot commented on CB-6272:
------------------------------------
GitHub user jsoref opened a pull request:
https://github.com/apache/cordova-plugman/pull/65
CB-6272 Fix subdir handling
https://issues.apache.org/jira/browse/CB-6272
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jsoref/cordova-plugman cb_6272
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugman/pull/65.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #65
----
commit 433b035e335492971f23c0fba19262081cd2cbdf
Author: Josh Soref <js...@blackberry.com>
Date: 2014-03-14T22:53:13Z
CB-6272 Fix subdir handling
----
> Fix subdir handling
> -------------------
>
> Key: CB-6272
> URL: https://issues.apache.org/jira/browse/CB-6272
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugman
> Affects Versions: 3.5.0
> Reporter: Josh Soref
> Assignee: Josh Soref
> Priority: Blocker
>
> CB-6160 landed [~jbondc]'s ae2ce7ac6325d1c6558365b4be82e5a8ff0983b9
> which broke some portion of install:
> + if (dep.subdir) {
> + dep.subdir = path.join(dep.subdir.split('/'));
> ...
> - if (dep_subdir) {
> - dep_subdir = path.join.apply(null, dep_subdir.split('/'));
--
This message was sent by Atlassian JIRA
(v6.2#6252)