You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/02 13:58:19 UTC
[GitHub] [airflow] dkinzer opened a new pull request #14562: Fix flask_oautlib throws error.
dkinzer opened a new pull request #14562:
URL: https://github.com/apache/airflow/pull/14562
closes: #8467
Fixes dependency issue that causes an error when users try to create
a new user using the oauth type.
This commit adds the Flask-OAuthlib==0.9.5 and it's dependencies to the constraints-1-10 branch which is missing there but not in constraints for 2.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14562: Fix flask_oautlib throws error.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14562:
URL: https://github.com/apache/airflow/pull/14562#issuecomment-821906172
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] andriisoldatenko commented on pull request #14562: Fix flask_oautlib throws error.
Posted by GitBox <gi...@apache.org>.
andriisoldatenko commented on pull request #14562:
URL: https://github.com/apache/airflow/pull/14562#issuecomment-889395282
@dkinzer @kaxil i think i still can reproduce this issue.
https://raw.githubusercontent.com/apache/airflow/constraints-1.10.15/constraints-3.7.txt doesn't have `Flask-OAuthlib==0.9.5`, so if you try to install 1.10.15 you can still see same issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dkinzer commented on pull request #14562: Fix flask_oautlib throws error.
Posted by GitBox <gi...@apache.org>.
dkinzer commented on pull request #14562:
URL: https://github.com/apache/airflow/pull/14562#issuecomment-822569408
Assuming this is fixed upstream so I'm closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #14562: Fix flask_oautlib throws error.
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #14562:
URL: https://github.com/apache/airflow/pull/14562#issuecomment-788927836
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on pull request #14562: Fix flask_oautlib throws error.
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #14562:
URL: https://github.com/apache/airflow/pull/14562#issuecomment-789296983
This should not go to `constraints-1-10`. Instead https://github.com/apache/airflow/blob/v1-10-stable/setup.py#L609 needs updating.
Once that is merged, it will update constraints
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dkinzer commented on pull request #14562: Fix flask_oautlib throws error.
Posted by GitBox <gi...@apache.org>.
dkinzer commented on pull request #14562:
URL: https://github.com/apache/airflow/pull/14562#issuecomment-789668905
Thanks @kaxil . Apologies , I'm not versant in this repo. It looks there there may have already been an attempt to fix this issue 2 months ago via https://github.com/apache/airflow/pull/10828, but constraints-1-10 has not been updated for three months and it looks like Flask-OAuth is still missing on that branch. Will the constraint-1-10 get updated with the changes that were added to setup.py 2 months ago, or is there an issue somewhere in the process that is preventing that update to occur?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dkinzer closed pull request #14562: Fix flask_oautlib throws error.
Posted by GitBox <gi...@apache.org>.
dkinzer closed pull request #14562:
URL: https://github.com/apache/airflow/pull/14562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dkinzer edited a comment on pull request #14562: Fix flask_oautlib throws error.
Posted by GitBox <gi...@apache.org>.
dkinzer edited a comment on pull request #14562:
URL: https://github.com/apache/airflow/pull/14562#issuecomment-789668905
Thanks @kaxil . Apologies , I'm not versant in this repo. It looks like there may have already been an attempt to fix this issue 2 months ago via https://github.com/apache/airflow/pull/10828.
However, the constraints-1-10 branch has not been updated for three months and it looks like Flask-OAuth is still missing on that branch.
Will the constraint-1-10 branch get updated with the changes that were added to setup.py 2 months ago, or is there an issue somewhere in the process that is preventing that update to occur?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #14562: Fix flask_oautlib throws error.
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #14562:
URL: https://github.com/apache/airflow/pull/14562#issuecomment-789296983
This should not go to `constraints-1-10`. Instead https://github.com/apache/airflow/blob/v1-10-stable/setup.py#L609 needs updating
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org