You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/01/22 16:04:33 UTC
[GitHub] incubator-brooklyn pull request: Adds catalog item example to exte...
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1172
Adds catalog item example to externalized-configuration.md
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn docs/catalogItem-externalizedConfiguration
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1172.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1172
----
commit 9e688969d23f5fa8be66f6be0d811d6e5618d5e1
Author: Aled Sage <al...@gmail.com>
Date: 2016-01-22T15:03:41Z
Adds catalog item example to externalized-configuration.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Adds catalog item example to exte...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1172#issuecomment-173991781
Thanks @alasdairhodge - have changed heading capitalisation. And yes, the example parses :-)
Merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Adds catalog item example to exte...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1172
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Adds catalog item example to exte...
Posted by alasdairhodge <gi...@git.apache.org>.
Github user alasdairhodge commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1172#discussion_r50565720
--- Diff: brooklyn-docs/guide/ops/externalized-configuration.md ---
@@ -122,6 +122,23 @@ brooklyn.location.jclouds.aws-ec2.credential=$brooklyn:external("mysupplier", "a
{% endhighlight %}
+## Referring to External Configuration in catalog items
--- End diff --
Capitalisation of "catalog items" is inconsistent with other section headings. /nitpick
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Adds catalog item example to exte...
Posted by alasdairhodge <gi...@git.apache.org>.
Github user alasdairhodge commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1172#discussion_r50546773
--- Diff: brooklyn-docs/guide/ops/externalized-configuration.md ---
@@ -122,6 +122,19 @@ brooklyn.location.jclouds.aws-ec2.credential=$brooklyn:external("mysupplier", "a
{% endhighlight %}
+## Referring to External Configuration in catalog items
+
+The same blueprint language DSL can be used within YAML catalog items. For example:
+
+ brooklyn.catalog:
+ id: com.example.myblueprint
+ version: 1.2.3
+ brooklyn.libraries:
+ - $brooklyn:external("mysupplier", "my-blueprint-lib")
+ item:
+ type: com.example.MyBlueprint
+
+
--- End diff --
Good thing to demonstrate,but example feels a bit contrived. Perhaps show a *location* catalog item, with user ID and credential externalised?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Adds catalog item example to exte...
Posted by alasdairhodge <gi...@git.apache.org>.
Github user alasdairhodge commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1172#discussion_r50565476
--- Diff: brooklyn-docs/guide/ops/externalized-configuration.md ---
@@ -122,6 +122,23 @@ brooklyn.location.jclouds.aws-ec2.credential=$brooklyn:external("mysupplier", "a
{% endhighlight %}
+## Referring to External Configuration in catalog items
+
+The same blueprint language DSL can be used within YAML catalog items. For example:
+
+ brooklyn.catalog:
+ id: com.example.myblueprint
+ version: 1.2.3
+ brooklyn.libraries:
+ - >
+ $brooklyn:formatString("https://%s:%s@repo.example.com/libs/myblueprint-1.2.3.jar",
+ external("mysuppier", "username"), external("mysupplier", "password"))
+ item:
+ type: com.example.MyBlueprint
+
+Note the `>` in the example above is used to split across multiple lines.
+
+
--- End diff --
Much better example. I didn't realise that the `$brooklyn` prefix can be dropped inside the scope of the function arguments; does this definitely parse? ;o)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---