[GitHub] storm pull request #2303: STORM-2660 The Nimbus storm-local directory is rel...

[srdo <gi...@git.apache.org>]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2303#discussion_r136595401
  
    --- Diff: storm-client/src/jvm/org/apache/storm/utils/ConfigUtils.java ---
    @@ -215,6 +215,20 @@ public static String absoluteStormLocalDir(Map<String, Object> conf) {
             }
         }
     
    +    public static String absoluteStormBlobStoreDir(Map<String, Object> conf) {
    +        String stormHome = System.getProperty("storm.home");
    +        String blobStoreDir = (String) conf.get(Config.BLOBSTORE_DIR);
    +        if (blobStoreDir == null) {
    +            return null;
    --- End diff --
    
    I think we can make this a little nicer by having this return absoluteStormLocalDir. There's less risk of us accidentally forgetting to null check the result if this ever gets used elsewhere.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---