You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2006/05/28 09:04:24 UTC
[Bug 4924] New: tag name shown in add_header if test failed
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4924
Summary: tag name shown in add_header if test failed
Product: Spamassassin
Version: 3.1.2
Platform: PC
OS/Version: Linux
Status: NEW
Severity: trivial
Priority: P5
Component: spamassassin
AssignedTo: dev@spamassassin.apache.org
ReportedBy: graham@gmurray.org.uk
Where an add_header line contains as tag and the test/plugin producing the value
for the tag fails then the name of the tag is printed. This happens for example
where the mail matches an "OK" in my DCC whitelist and therefore dccifd does not
return an X-Dcc header. Spamassassin then inserts the header "X-Spam-Dcc: _DCCB_
_DCCR_ " I have also seen the same with the Pyzor add_header. In previous
versions, a blank header 'value' was output not the tag name.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4924] [review] tag name shown in add_header if test failed
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4924
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard| |needs 2 votes
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4924] tag name shown in add_header if test failed
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4924
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|dev@spamassassin.apache.org |spamassassin@dostech.ca
Status|NEW |ASSIGNED
------- Additional Comments From spamassassin@dostech.ca 2006-05-29 07:03 -------
Created an attachment (id=3525)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3525&action=view)
3.1 patch
This fixes the three tags from the plugins and a few other tags that the same
thing can happen to.
Note that running SA with -L (local tests only) will still cause this to happen
to the plugins that require network tests. To avoid it we'd have to add a
callback, to say check_start, to the plugins to initialize the tags.
Of course, if you're using -L the plugins in question are essentially disabled
so their tags might as well be too.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4924] [review] tag name shown in add_header if test failed
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4924
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
Status Whiteboard|needs 1 |ready
------- Additional Comments From felicity@apache.org 2006-06-30 03:28 -------
+1
Sending lib/Mail/SpamAssassin/PerMsgStatus.pm
Sending lib/Mail/SpamAssassin/Plugin/DCC.pm
Sending lib/Mail/SpamAssassin/Plugin/Pyzor.pm
Transmitting file data ...
Committed revision 418174.
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4924] tag name shown in add_header if test failed
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4924
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|spamassassin |Plugins
Target Milestone|Undefined |3.1.3
------- Additional Comments From felicity@apache.org 2006-05-28 18:37 -------
I didn't fully parse the original comment, but I believe the issue is that in at
least the DCC and Pyzor plugins, the "DCCB", "DCCR", and "PYZOR" tags aren't
defined unless the lookups complete "successfully". Therefore, via bug 4793,
the tags are left intact when used via add_header, etc.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4924] [review] tag name shown in add_header if test failed
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4924
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|3.1.3 |3.1.4
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4924] [review] tag name shown in add_header if test failed
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4924
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dev@spamassassin.apache.org
Summary|tag name shown in add_header|[review] tag name shown in
|if test failed |add_header if test failed
------- Additional Comments From spamassassin@dostech.ca 2006-05-29 07:06 -------
[dos@cyan trunk]$ svn ci -m 'bug 4924: initialize tag data for _DCCB_, _DCCR_,
_PYZOR_, _RBL_, _BAYESTC*_'
Sending lib/Mail/SpamAssassin/PerMsgStatus.pm
Sending lib/Mail/SpamAssassin/Plugin/DCC.pm
Sending lib/Mail/SpamAssassin/Plugin/Pyzor.pm
Transmitting file data ...
Committed revision 410038.
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4924] [review] tag name shown in add_header if test failed
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4924
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes |needs 1
------- Additional Comments From jm@jmason.org 2006-06-29 09:27 -------
+1
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.