You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Martin Marinschek <ma...@gmail.com> on 2006/04/18 12:17:43 UTC
Refactoring tomahawk source
Hi *,
before the tomahawk release, I'd love to do a refactoring - move over
everything in tomahawk from org.apache.myfaces to
org.apache.myfaces.tomahawk
is that ok with you guys - if yes, I'd finish with that today.
regards,
Martin
--
http://www.irian.at
Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces
Re: Refactoring tomahawk source
Posted by Mario Ivankovits <ma...@ops.co.at>.
Hi!
> I was referring to the problems the user have with old libs in their
> directories - with a clear package name in the game, we could more
> easily find out where the problems are. But I can wait until after the
> release, sure.
>
On the other hand we have to decide which burden we can put on our
users. If every upgrade requires some drastic changes in the local setup
this is a huge burden.
A user might also be a developer and as a developer one might create its
own components - maybe reusing tomahawk stuff.
Or those who created custom renderer classes for tomahawk components
(like I've done)
For the future we should find a way how to deal with such changes.
In apache-commons you never ever can make such a drastic change between
minor releases.
So this change would require a tomahawk-2.0 release.
Ciao,
Mario
Re: Refactoring tomahawk source
Posted by Martin Marinschek <ma...@gmail.com>.
o-k.
I was referring to the problems the user have with old libs in their
directories - with a clear package name in the game, we could more
easily find out where the problems are. But I can wait until after the
release, sure.
regards,
Martin
On 4/18/06, Sean Schofield <se...@gmail.com> wrote:
> I'm -1 based on Volker's concerns and the fact that this can only slow
> us down. Its pretty crucial that we get a release out now and we can
> refactor the next release. I'm still having trouble running the core
> trunk btw (which is preventing me from tweaking tomahawk.)
>
> Sean
>
> On 4/18/06, Volker Weber <us...@weber-oldenburg.de> wrote:
> > Hi,
> >
> > my (non binding) -0.5 for this.
> >
> > I like to see some of the tomahawk classes (e.g. Validators, Converters
> > and non rendering tags(saveState, aliasBean, ...)) moving from
> > tomahawk.jar to a new commons.jar after the tomahawk release, to enable
> > using them in tobago.
> >
> > I don't think we should rename the package of them now to
> > org.apache.myfaces.tomahawk and next week (or so) rename them again to
> > org.apache.myfaces.commons.
> >
> >
> > Regards,
> > Volker
> >
> >
> >
> > Martin Marinschek wrote:
> > > Hi *,
> > >
> > > before the tomahawk release, I'd love to do a refactoring - move over
> > > everything in tomahawk from org.apache.myfaces to
> > > org.apache.myfaces.tomahawk
> > >
> > > is that ok with you guys - if yes, I'd finish with that today.
> > >
> > > regards,
> > >
> > > Martin
> > >
> > > --
> > >
> > > http://www.irian.at
> > >
> > > Your JSF powerhouse -
> > > JSF Consulting, Development and
> > > Courses in English and German
> > >
> > > Professional Support for Apache MyFaces
> > >
> >
> > --
> > Don't answer to From: address!
> > Mail to this account are droped if not recieved via mailinglist.
> > To contact me direct create the mail address by
> > concatenating my forename to my senders domain.
> >
>
--
http://www.irian.at
Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces
Re: Refactoring tomahawk source
Posted by Sean Schofield <se...@gmail.com>.
I'm -1 based on Volker's concerns and the fact that this can only slow
us down. Its pretty crucial that we get a release out now and we can
refactor the next release. I'm still having trouble running the core
trunk btw (which is preventing me from tweaking tomahawk.)
Sean
On 4/18/06, Volker Weber <us...@weber-oldenburg.de> wrote:
> Hi,
>
> my (non binding) -0.5 for this.
>
> I like to see some of the tomahawk classes (e.g. Validators, Converters
> and non rendering tags(saveState, aliasBean, ...)) moving from
> tomahawk.jar to a new commons.jar after the tomahawk release, to enable
> using them in tobago.
>
> I don't think we should rename the package of them now to
> org.apache.myfaces.tomahawk and next week (or so) rename them again to
> org.apache.myfaces.commons.
>
>
> Regards,
> Volker
>
>
>
> Martin Marinschek wrote:
> > Hi *,
> >
> > before the tomahawk release, I'd love to do a refactoring - move over
> > everything in tomahawk from org.apache.myfaces to
> > org.apache.myfaces.tomahawk
> >
> > is that ok with you guys - if yes, I'd finish with that today.
> >
> > regards,
> >
> > Martin
> >
> > --
> >
> > http://www.irian.at
> >
> > Your JSF powerhouse -
> > JSF Consulting, Development and
> > Courses in English and German
> >
> > Professional Support for Apache MyFaces
> >
>
> --
> Don't answer to From: address!
> Mail to this account are droped if not recieved via mailinglist.
> To contact me direct create the mail address by
> concatenating my forename to my senders domain.
>
Re: Refactoring tomahawk source
Posted by Adam Winer <aw...@gmail.com>.
And a non-binding -1 here too; I'd like to see a more extensive
refactoring; e.g., components not each in separate packages,
renderers and tags not in the same package as components,
etc., plus some things moved to a shared lib for ADF Faces + Tobago,
etc. Maybe a post-J1 Tomahawk 2.0?
-- Adam
On 4/19/06, Werner Punz <we...@gmx.at> wrote:
> Volker Weber schrieb:
> > Hi,
> >
> > my (non binding) -0.5 for this.
> >
> > I like to see some of the tomahawk classes (e.g. Validators, Converters
> > and non rendering tags(saveState, aliasBean, ...)) moving from
> > tomahawk.jar to a new commons.jar after the tomahawk release, to enable
> > using them in tobago.
> >
> > I don't think we should rename the package of them now to
> > org.apache.myfaces.tomahawk and next week (or so) rename them again to
> > org.apache.myfaces.commons.
> >
> >
> -1 (non binding) from me as well, given the fact that users really have
> a hard time in the user list to use anything with 1.1.2 jsf (follow the
> mails of the people having problems getting tomahawk to run on 1.1.2 due
> to all the build time refactoring stuff) I think the biggest priority
> for now should be to get tomahawk out asap so that people actually can
> start to work again, with it (and toolvendors can integrate it before j1)
>
>
Re: Refactoring tomahawk source
Posted by Sean Schofield <se...@gmail.com>.
Good point.
On 4/20/06, Mike Kienenberger <mk...@gmail.com> wrote:
> Before we refactor the tomahawk package names, I think we should
> either commit or reject any open tomahawk issues with patches
> available.
>
> Since that's likely to take awhile, I think it's best to release
> before refactoring.
>
Re: Refactoring tomahawk source
Posted by Mike Kienenberger <mk...@gmail.com>.
Before we refactor the tomahawk package names, I think we should
either commit or reject any open tomahawk issues with patches
available.
Since that's likely to take awhile, I think it's best to release
before refactoring.
Re: Refactoring tomahawk source
Posted by Werner Punz <we...@gmx.at>.
Volker Weber schrieb:
> Hi,
>
> my (non binding) -0.5 for this.
>
> I like to see some of the tomahawk classes (e.g. Validators, Converters
> and non rendering tags(saveState, aliasBean, ...)) moving from
> tomahawk.jar to a new commons.jar after the tomahawk release, to enable
> using them in tobago.
>
> I don't think we should rename the package of them now to
> org.apache.myfaces.tomahawk and next week (or so) rename them again to
> org.apache.myfaces.commons.
>
>
-1 (non binding) from me as well, given the fact that users really have
a hard time in the user list to use anything with 1.1.2 jsf (follow the
mails of the people having problems getting tomahawk to run on 1.1.2 due
to all the build time refactoring stuff) I think the biggest priority
for now should be to get tomahawk out asap so that people actually can
start to work again, with it (and toolvendors can integrate it before j1)
Re: Refactoring tomahawk source
Posted by Volker Weber <us...@weber-oldenburg.de>.
Hi,
my (non binding) -0.5 for this.
I like to see some of the tomahawk classes (e.g. Validators, Converters
and non rendering tags(saveState, aliasBean, ...)) moving from
tomahawk.jar to a new commons.jar after the tomahawk release, to enable
using them in tobago.
I don't think we should rename the package of them now to
org.apache.myfaces.tomahawk and next week (or so) rename them again to
org.apache.myfaces.commons.
Regards,
Volker
Martin Marinschek wrote:
> Hi *,
>
> before the tomahawk release, I'd love to do a refactoring - move over
> everything in tomahawk from org.apache.myfaces to
> org.apache.myfaces.tomahawk
>
> is that ok with you guys - if yes, I'd finish with that today.
>
> regards,
>
> Martin
>
> --
>
> http://www.irian.at
>
> Your JSF powerhouse -
> JSF Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
>
--
Don't answer to From: address!
Mail to this account are droped if not recieved via mailinglist.
To contact me direct create the mail address by
concatenating my forename to my senders domain.
Re: Refactoring tomahawk source
Posted by Matthias Wessendorf <ma...@apache.org>.
> before the tomahawk release, I'd love to do a refactoring - move over
> everything in tomahawk from org.apache.myfaces to
> org.apache.myfaces.tomahawk
+1
makes it easier to *follow*, when referencing to tomahawk clazzes IMO
-Matthias
> is that ok with you guys - if yes, I'd finish with that today.
>
> regards,
>
> Martin
>
> --
>
> http://www.irian.at
>
> Your JSF powerhouse -
> JSF Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
>
--
Matthias Wessendorf
Aechterhoek 18
48282 Emsdetten
http://jroller.com/page/mwessendorf
mwessendorf-at-gmail-dot-com
Re: Refactoring tomahawk source
Posted by Bruno Aranda <br...@gmail.com>.
+1 For me it is ok, a more clear separation at package level will
avoid many missunderstandings.
Cheers,
Bruno
On 4/18/06, Martin Marinschek <ma...@gmail.com> wrote:
> Hi *,
>
> before the tomahawk release, I'd love to do a refactoring - move over
> everything in tomahawk from org.apache.myfaces to
> org.apache.myfaces.tomahawk
>
> is that ok with you guys - if yes, I'd finish with that today.
>
> regards,
>
> Martin
>
> --
>
> http://www.irian.at
>
> Your JSF powerhouse -
> JSF Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
>