You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/23 15:38:19 UTC
[GitHub] [incubator-shardingsphere] cherrylzhao opened a new pull request
#4421: skip sharding-proxy & sharding-ui in deploy phase
cherrylzhao opened a new pull request #4421: skip sharding-proxy & sharding-ui in deploy phase
URL: https://github.com/apache/incubator-shardingsphere/pull/4421
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4421: skip
sharding-proxy & sharding-ui in deploy phase
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #4421: skip sharding-proxy & sharding-ui in deploy phase
URL: https://github.com/apache/incubator-shardingsphere/pull/4421#issuecomment-590155216
Please add to dev branch too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4421: skip sharding-proxy & sharding-ui in deploy phase
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4421: skip sharding-proxy & sharding-ui in deploy phase
URL: https://github.com/apache/incubator-shardingsphere/pull/4421#issuecomment-590085305
## Pull Request Test Coverage Report for [Build 9733](https://coveralls.io/builds/28911387)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **67.462%**
---
| Totals | [](https://coveralls.io/builds/28911387) |
| :-- | --: |
| Change from base [Build 9602](https://coveralls.io/builds/28776487): | 0.0% |
| Covered Lines: | 11306 |
| Relevant Lines: | 16759 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4421: skip sharding-proxy & sharding-ui in deploy phase
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4421: skip sharding-proxy & sharding-ui in deploy phase
URL: https://github.com/apache/incubator-shardingsphere/pull/4421#issuecomment-590085305
## Pull Request Test Coverage Report for [Build 1850](https://coveralls.io/builds/28911435)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **2** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.006%**) to **67.468%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28911435/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L74) | 2 | 80.0% |
<!-- | **Total:** | **2** | | -->
| Totals | [](https://coveralls.io/builds/28911435) |
| :-- | --: |
| Change from base [Build 9602](https://coveralls.io/builds/28776487): | 0.006% |
| Covered Lines: | 11307 |
| Relevant Lines: | 16759 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4421:
skip sharding-proxy & sharding-ui in deploy phase
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4421: skip sharding-proxy & sharding-ui in deploy phase
URL: https://github.com/apache/incubator-shardingsphere/pull/4421#issuecomment-590087012
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4421?src=pr&el=h1) Report
> Merging [#4421](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4421?src=pr&el=desc) into [dev-4.x](https://codecov.io/gh/apache/incubator-shardingsphere/commit/b1ef1665462005823767c3a87c0a419a4d8f91da?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4421?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev-4.x #4421 +/- ##
==========================================
Coverage 63.33% 63.33%
Complexity 876 876
==========================================
Files 1057 1057
Lines 17001 17001
Branches 2739 2739
==========================================
Hits 10767 10767
Misses 5631 5631
Partials 603 603
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4421?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4421?src=pr&el=footer). Last update [b1ef166...dde79f7](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4421?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] SanmuWangZJU commented on issue #4421:
skip sharding-proxy & sharding-ui in deploy phase
Posted by GitBox <gi...@apache.org>.
SanmuWangZJU commented on issue #4421: skip sharding-proxy & sharding-ui in deploy phase
URL: https://github.com/apache/incubator-shardingsphere/pull/4421#issuecomment-596891575
why skip deploy sharding-proxy and sharding-ui ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4421: skip sharding-proxy & sharding-ui in deploy phase
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4421: skip sharding-proxy & sharding-ui in deploy phase
URL: https://github.com/apache/incubator-shardingsphere/pull/4421#issuecomment-590085305
## Pull Request Test Coverage Report for [Build 1852](https://coveralls.io/builds/28911666)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **2** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.006%**) to **67.468%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28911666/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L74) | 2 | 80.0% |
<!-- | **Total:** | **2** | | -->
| Totals | [](https://coveralls.io/builds/28911666) |
| :-- | --: |
| Change from base [Build 9602](https://coveralls.io/builds/28776487): | 0.006% |
| Covered Lines: | 11307 |
| Relevant Lines: | 16759 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4421:
skip sharding-proxy & sharding-ui in deploy phase
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4421: skip sharding-proxy & sharding-ui in deploy phase
URL: https://github.com/apache/incubator-shardingsphere/pull/4421
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #4421:
skip sharding-proxy & sharding-ui in deploy phase
Posted by GitBox <gi...@apache.org>.
cherrylzhao commented on issue #4421: skip sharding-proxy & sharding-ui in deploy phase
URL: https://github.com/apache/incubator-shardingsphere/pull/4421#issuecomment-590163881
> Please set label and milestone
have fix it yet
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4421: skip
sharding-proxy & sharding-ui in deploy phase
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4421: skip sharding-proxy & sharding-ui in deploy phase
URL: https://github.com/apache/incubator-shardingsphere/pull/4421#issuecomment-590085305
## Pull Request Test Coverage Report for [Build 1846](https://coveralls.io/builds/28905018)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **2** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.006%**) to **67.468%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28905018/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L74) | 2 | 80.0% |
<!-- | **Total:** | **2** | | -->
| Totals | [](https://coveralls.io/builds/28905018) |
| :-- | --: |
| Change from base [Build 9602](https://coveralls.io/builds/28776487): | 0.006% |
| Covered Lines: | 11307 |
| Relevant Lines: | 16759 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4421: skip sharding-proxy & sharding-ui in deploy phase
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4421: skip sharding-proxy & sharding-ui in deploy phase
URL: https://github.com/apache/incubator-shardingsphere/pull/4421#issuecomment-590085305
## Pull Request Test Coverage Report for [Build 9727](https://coveralls.io/builds/28905318)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **67.462%**
---
| Totals | [](https://coveralls.io/builds/28905318) |
| :-- | --: |
| Change from base [Build 9602](https://coveralls.io/builds/28776487): | 0.0% |
| Covered Lines: | 11306 |
| Relevant Lines: | 16759 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services