You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "CritasWang (via GitHub)" <gi...@apache.org> on 2025/11/11 02:51:43 UTC
[PR] [To dev/1.3]chore!: Bind real config address for Thrift and Raft services (#16717) [iotdb]
CritasWang opened a new pull request, #16730:
URL: https://github.com/apache/iotdb/pull/16730
* chore: Bind real internal address for Thrift and Raft services
* keep ExternalRpcAddress use config value
* Update iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/ExternalRPCService.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [To dev/1.3]chore!: Bind real config address for Thrift and Raft services (#16717) [iotdb]
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou merged PR #16730:
URL: https://github.com/apache/iotdb/pull/16730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [To dev/1.3]chore!: Bind real config address for Thrift and Raft services (#16717) [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #16730:
URL: https://github.com/apache/iotdb/pull/16730#issuecomment-3514876320
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/16730?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.00000%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 41.04%. Comparing base ([`926f195`](https://app.codecov.io/gh/apache/iotdb/commit/926f1959af179ebe56e21507b2b577122ad28c6b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6e7ee2c`](https://app.codecov.io/gh/apache/iotdb/commit/6e7ee2c8a4ea04569e3e8b3c578e4adb168a780a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on dev/1.3.
| [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/16730?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...b/commons/service/AbstractThriftServiceThread.java](https://app.codecov.io/gh/apache/iotdb/pull/16730?src=pr&el=tree&filepath=iotdb-core%2Fnode-commons%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fcommons%2Fservice%2FAbstractThriftServiceThread.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9ub2RlLWNvbW1vbnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL2NvbW1vbnMvc2VydmljZS9BYnN0cmFjdFRocmlmdFNlcnZpY2VUaHJlYWQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/16730?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## dev/1.3 #16730 +/- ##
==========================================
Coverage 41.04% 41.04%
Complexity 198 198
==========================================
Files 3586 3586
Lines 235273 235277 +4
Branches 28387 28388 +1
==========================================
+ Hits 96565 96568 +3
- Misses 138708 138709 +1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/16730?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [To dev/1.3]chore!: Bind real config address for Thrift and Raft services (#16717) [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #16730:
URL: https://github.com/apache/iotdb/pull/16730#issuecomment-3514799931
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=16730) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=16730&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=16730&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=16730&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=16730&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=16730&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=16730)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org