[GitHub] [cloudstack] weizhouapache commented on a change in pull request #6007: StorPool storage plugin

[GitBox <gi...@apache.org>]

weizhouapache commented on a change in pull request #6007:
URL: https://github.com/apache/cloudstack/pull/6007#discussion_r839608137



##########
File path: packaging/centos7/cloud.spec
##########
@@ -346,6 +346,7 @@ install -D agent/target/transformed/cloudstack-agent-profile.sh ${RPM_BUILD_ROOT
 install -D agent/target/transformed/cloudstack-agent.logrotate ${RPM_BUILD_ROOT}%{_sysconfdir}/logrotate.d/%{name}-agent
 install -D plugins/hypervisors/kvm/target/cloud-plugin-hypervisor-kvm-%{_maventag}.jar ${RPM_BUILD_ROOT}%{_datadir}/%name-agent/lib/cloud-plugin-hypervisor-kvm-%{_maventag}.jar
 cp plugins/hypervisors/kvm/target/dependencies/*  ${RPM_BUILD_ROOT}%{_datadir}/%{name}-agent/lib
+cp plugins/storage/volume/storpool/target/*.jar  ${RPM_BUILD_ROOT}%{_datadir}/%{name}-agent/lib

Review comment:
       @slavkap 
   if we support StorPool in ACS 4.17, this separated jar may be not needed any more. all other jars including the hypervisor plugins, storage provider plugins, network plugins are included in cloudstack-4.xx.x.0.jar. there is no exception.
   
   I understand this is easy for you to maintain or upgrade. I believe you can find some other good solutions.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org