You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/11/23 20:12:09 UTC

[GitHub] [incubator-yunikorn-core] wilfred-s commented on a change in pull request #343: [YUNIKORN-952] nil pointer error in webservice.getApplicationJSON()

wilfred-s commented on a change in pull request #343:
URL: https://github.com/apache/incubator-yunikorn-core/pull/343#discussion_r755467180



##########
File path: pkg/webservice/handlers.go
##########
@@ -774,8 +774,7 @@ func getApplicationsDAO(lists map[string]*scheduler.PartitionContext) []*dao.App
 	result := make([]*dao.ApplicationDAOInfo, 0, 32)

Review comment:
       Can we simplify this one too? The capacity is arbitrarily set.
   The make in line 800 (new code) should also be cleaned up to get it inline with the rest of the make calls: should be similar to the make in line 790




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org