You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by "Martin Heidegger (Issue Comment Edited) (JIRA)" <ji...@apache.org> on 2012/02/25 09:41:52 UTC

[jira] [Issue Comment Edited] (FLEX-19) Code style improvements in framework

    [ https://issues.apache.org/jira/browse/FLEX-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216376#comment-13216376 ] 

Martin Heidegger edited comment on FLEX-19 at 2/25/12 8:41 AM:
---------------------------------------------------------------

There were empty spaces after the ";". Slipped into the patch. I apologize. Is that a problem?
                
      was (Author: martin.heidegger):
    There were empty spaces after the ";".
                  
> Code style improvements in framework
> ------------------------------------
>
>                 Key: FLEX-19
>                 URL: https://issues.apache.org/jira/browse/FLEX-19
>             Project: Apache Flex
>          Issue Type: Improvement
>            Reporter: Martin Heidegger
>            Assignee: Bertrand Delacretaz
>            Priority: Trivial
>         Attachments: A-semicolon.patch, B-nullboolean.patch, C-unusedimports.patch, D-unusedlocalvariables.patch, E-returntovoid.patch, F-dynamicKeyInVariable.patch, G-unusedprivatemethods.patch
>
>
> After skimming the "framework" sub-project I created a set of patches to the source code of various categories.
>   A) Missing semicolons in the code
>   B) Changed implict casting from object to boolean to a explicit != null
>   C) Removed unused imports
>   D) Removed local variables that are unused and arguments of private functions that are unused
>   E) Removed return statement in functions with : void signature
>   F) Changed variables named "dynamic" to a name that is not same as a keyword
>   G) Removed unused private methods

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira