You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2017/11/03 12:10:58 UTC

[GitHub] rhtyd commented on a change in pull request #2306: CLOUDSTACK-10129: Allow navigation from VRs to network, instances, owners etc.

rhtyd commented on a change in pull request #2306: CLOUDSTACK-10129: Allow navigation from VRs to network, instances, owners etc.
URL: https://github.com/apache/cloudstack/pull/2306#discussion_r148766667
 
 

 ##########
 File path: ui/scripts/system.js
 ##########
 @@ -31,6 +31,7 @@
 
         if (router.projectid) routerType = _l('label.project');
         if (router.vpcid) routerType = _l('label.vpc');
+        if ("isredundantrouter" in router && router.isredundantrouter) routerType = routerType + " (" + router.redundantstate + ")";
 
 Review comment:
   @nitin-maharana I'm not sure how could all these three disjoint if conditions be refactored into if..else, what do you have in mind?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services