You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/15 21:08:47 UTC
[GitHub] [beam] TheNeuralBit opened a new pull request #12015: Clarify release guide for publishing release notes to GitHub
TheNeuralBit opened a new pull request #12015:
URL: https://github.com/apache/beam/pull/12015
- Move GitHub release note publication after merging the blog post, since the script reads from the blog post.
- Change command to first cd into `beam/release/src/main/scripts`. Otherwise sourcing script.config fails.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Samza | Spark
--- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit merged pull request #12015: Clarify release guide for publishing release notes to GitHub
Posted by GitBox <gi...@apache.org>.
TheNeuralBit merged pull request #12015:
URL: https://github.com/apache/beam/pull/12015
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #12015: Clarify release guide for publishing release notes to GitHub
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #12015:
URL: https://github.com/apache/beam/pull/12015#discussion_r440466354
##########
File path: website/www/site/content/en/contribute/release-guide.md
##########
@@ -1126,21 +1126,28 @@ Verify that:
* Images with *latest* tag are pointing to current release by confirming
1. Digest of the image with *latest* tag is the same as the one with {RELEASE} tag.
+### Merge website pull request
+
+Merge the website pull request to [list the release](/get-started/downloads/), publish the [Python API reference manual](https://beam.apache.org/releases/pydoc/), the [Java API reference manual](https://beam.apache.org/releases/javadoc/) and Blogpost created earlier.
Review comment:
Pushed a commit tweaking this section, PTAL
##########
File path: website/www/site/content/en/contribute/release-guide.md
##########
@@ -1126,21 +1126,28 @@ Verify that:
* Images with *latest* tag are pointing to current release by confirming
1. Digest of the image with *latest* tag is the same as the one with {RELEASE} tag.
+### Merge website pull request
+
+Merge the website pull request to [list the release](/get-started/downloads/), publish the [Python API reference manual](https://beam.apache.org/releases/pydoc/), the [Java API reference manual](https://beam.apache.org/releases/javadoc/) and Blogpost created earlier.
+
### Git tag
Create and push a new signed tag for the released version by copying the tag for the final release candidate, as follows:
- VERSION_TAG="v${RELEASE}"
- git tag -s "$VERSION_TAG" "$RC_TAG"
- git push upstream "$VERSION_TAG"
+```
+VERSION_TAG="v${RELEASE}"
+git tag -s "$VERSION_TAG" "$RC_TAG"
+git push origin "$VERSION_TAG"
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #12015: Clarify release guide for publishing release notes to GitHub
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #12015:
URL: https://github.com/apache/beam/pull/12015#issuecomment-644391297
R: @ibzib
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on a change in pull request #12015: Clarify release guide for publishing release notes to GitHub
Posted by GitBox <gi...@apache.org>.
ibzib commented on a change in pull request #12015:
URL: https://github.com/apache/beam/pull/12015#discussion_r440461040
##########
File path: website/www/site/content/en/contribute/release-guide.md
##########
@@ -1126,21 +1126,28 @@ Verify that:
* Images with *latest* tag are pointing to current release by confirming
1. Digest of the image with *latest* tag is the same as the one with {RELEASE} tag.
+### Merge website pull request
+
+Merge the website pull request to [list the release](/get-started/downloads/), publish the [Python API reference manual](https://beam.apache.org/releases/pydoc/), the [Java API reference manual](https://beam.apache.org/releases/javadoc/) and Blogpost created earlier.
+
### Git tag
Create and push a new signed tag for the released version by copying the tag for the final release candidate, as follows:
- VERSION_TAG="v${RELEASE}"
- git tag -s "$VERSION_TAG" "$RC_TAG"
- git push upstream "$VERSION_TAG"
+```
+VERSION_TAG="v${RELEASE}"
+git tag -s "$VERSION_TAG" "$RC_TAG"
+git push origin "$VERSION_TAG"
Review comment:
The remote name depends on the users's `git remote` settings, which are arbitrary. I think we should be able to use `https://github.com/apache/beam` instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on a change in pull request #12015: Clarify release guide for publishing release notes to GitHub
Posted by GitBox <gi...@apache.org>.
ibzib commented on a change in pull request #12015:
URL: https://github.com/apache/beam/pull/12015#discussion_r440458283
##########
File path: website/www/site/content/en/contribute/release-guide.md
##########
@@ -1126,21 +1126,28 @@ Verify that:
* Images with *latest* tag are pointing to current release by confirming
1. Digest of the image with *latest* tag is the same as the one with {RELEASE} tag.
+### Merge website pull request
+
+Merge the website pull request to [list the release](/get-started/downloads/), publish the [Python API reference manual](https://beam.apache.org/releases/pydoc/), the [Java API reference manual](https://beam.apache.org/releases/javadoc/) and Blogpost created earlier.
Review comment:
Shouldn't this be pull request**s** (plural)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #12015: Clarify release guide for publishing release notes to GitHub
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #12015:
URL: https://github.com/apache/beam/pull/12015#discussion_r440464906
##########
File path: website/www/site/content/en/contribute/release-guide.md
##########
@@ -1126,21 +1126,28 @@ Verify that:
* Images with *latest* tag are pointing to current release by confirming
1. Digest of the image with *latest* tag is the same as the one with {RELEASE} tag.
+### Merge website pull request
+
+Merge the website pull request to [list the release](/get-started/downloads/), publish the [Python API reference manual](https://beam.apache.org/releases/pydoc/), the [Java API reference manual](https://beam.apache.org/releases/javadoc/) and Blogpost created earlier.
+
### Git tag
Create and push a new signed tag for the released version by copying the tag for the final release candidate, as follows:
- VERSION_TAG="v${RELEASE}"
- git tag -s "$VERSION_TAG" "$RC_TAG"
- git push upstream "$VERSION_TAG"
+```
+VERSION_TAG="v${RELEASE}"
+git tag -s "$VERSION_TAG" "$RC_TAG"
+git push origin "$VERSION_TAG"
Review comment:
Yeah, I just figured that `origin` is closer to a standard than `upstream`. That's a great point that we can just use the full URL though
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org