You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Robert Nettleton <rn...@hortonworks.com> on 2017/01/03 16:28:52 UTC
Re: Review Request 55107: LogSearch upgrade support 2.4 -> 2.5
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55107/#review160393
-----------------------------------------------------------
Fix it, then Ship it!
The patch looks fine to me, just a minor issue raised, since it looks like some additional unit tests would be useful.
Thanks.
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java (line 277)
<https://reviews.apache.org/r/55107/#comment231524>
It might be a good idea to consider adding some unit tests to verify the upgrade-related changes in the "updateLogSearchConfigs" method.
Since the config in 2.5 separates out "logsearch-env" and "logfeeder-env", it would probably be a good idea to have some unit tests to verify this change.
- Robert Nettleton
On Dec. 31, 2016, 12:47 a.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55107/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2016, 12:47 a.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-19330
> https://issues.apache.org/jira/browse/AMBARI-19330
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Upgrade the logsearch properties from 2.4 to 2.5
>
> Also fixed some property descriptions / display names
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java 38c7537
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-ambari-config.xml 64d7946
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-custom-logsearch-conf.xml 8358266
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml bc65e3c
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-log4j.xml 9371530
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-output-config.xml 85654c8
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml e7cd476
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-system_log-env.xml b8dd4b9
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-audit_logs-solrconfig.xml 6272dd1
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-log4j.xml 66b9bba
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 370588a
>
> Diff: https://reviews.apache.org/r/55107/diff/
>
>
> Testing
> -------
>
> Check configuration differences between logsearch in ambari version 2.4 and 2.5.
> Manually did a yum upgrade with new packages, then during ambari upgrade:
> - checked the new configurations were added properly
> - implemented renames/deletions in UpgradeCatalog250.java
>
>
> Thanks,
>
> Miklos Gergely
>
>