[jira] [Commented] (KAFKA-6367) Fix StateRestoreListener To Use Correct Ending Offset

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349206#comment-16349206 ] 

ASF GitHub Bot commented on KAFKA-6367:
---------------------------------------

bbejeck opened a new pull request #4507: KAFKA-6367: StateRestoreListener use actual last restored offset for restored batch
URL: https://github.com/apache/kafka/pull/4507
 
 
   
   Use the last actual restored offset for the `StoreRestoreListener.onBatchRestored` method.  Probably should update the docs to inform users this could include gaps in sequence due to commit markers.
   
   Updated existing tests
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix StateRestoreListener To Use Correct Ending Offset
> -----------------------------------------------------
>
>                 Key: KAFKA-6367
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6367
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 0.11.0.0, 1.0.0
>            Reporter: Bill Bejeck
>            Assignee: Bill Bejeck
>            Priority: Major
>             Fix For: 1.0.2
>
>
> {{StateRestoreListener#restoreBatchCompleted}} takes the {{nextPosition}} long  but the {{nextPosition}} is not correct, it should be the offset of the latest restored offset, but {{nextPosition}} is the offset of the first not restored offset.
> We can't automatically use {{nextPosition}} - 1 as this could be a commit marker.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)