[GitHub] [beam] slilichenko commented on a diff in pull request #28171: Properly handle in-flight deletes followed by adds in OrderedListState

["slilichenko (via GitHub)" <gi...@apache.org>]

slilichenko commented on code in PR #28171:
URL: https://github.com/apache/beam/pull/28171#discussion_r1307605068


##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillStateInternals.java:
##########
@@ -970,9 +972,7 @@ public TimestampedValueWithId<T> next() {
             Iterables.mergeSorted(
                 ImmutableList.of(data, pendingInRange), TimestampedValueWithId.COMPARATOR);
         Iterable<TimestampedValue<T>> fullIterable =
-            Iterables.filter(
-                Iterables.transform(includingAdds, TimestampedValueWithId::getValue),
-                tv -> !pendingDeletes.contains(tv.getTimestamp()));
+            Iterables.transform(includingAdds, TimestampedValueWithId::getValue);

Review Comment:
   What if a delete was issued after an add? It feels like the timing of overlapping deletes and adds also needs to be considered.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org