You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Andrew Lynch (JIRA)" <ji...@apache.org> on 2008/08/18 02:34:44 UTC

[jira] Created: (LUCENE-1359) FrenchAnalyzer's tokenStream method does not honour the contact of Analyzer

FrenchAnalyzer's tokenStream method does not honour the contact of Analyzer
---------------------------------------------------------------------------

                 Key: LUCENE-1359
                 URL: https://issues.apache.org/jira/browse/LUCENE-1359
             Project: Lucene - Java
          Issue Type: Bug
            Reporter: Andrew Lynch


In {{Analyzer}} :
{code}
/** Creates a TokenStream which tokenizes all the text in the provided
    Reader.  Default implementation forwards to tokenStream(Reader) for 
    compatibility with older version.  Override to allow Analyzer to choose 
    strategy based on document and/or field.  Must be able to handle null
    field name for backward compatibility. */
  public abstract TokenStream tokenStream(String fieldName, Reader reader);
{code}


and in {{FrenchAnalyzer}}

{code}
public final TokenStream tokenStream(String fieldName, Reader reader) {

    if (fieldName == null) throw new IllegalArgumentException("fieldName must not be null");
    if (reader == null) throw new IllegalArgumentException("reader must not be null");
{code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1359) FrenchAnalyzer's tokenStream method does not honour the contract of Analyzer

Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Miller updated LUCENE-1359:
--------------------------------

    Priority: Minor  (was: Major)

Depends on how you read things - it must be able to handle null for backward compatibility - but contrib analyzers have no explicit back compat requirement - so not supporting such a thing, while inconvenient, is not necessarily wrong.

> FrenchAnalyzer's tokenStream method does not honour the contract of Analyzer
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-1359
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1359
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Analysis
>    Affects Versions: 2.2
>            Reporter: Andrew Lynch
>            Priority: Minor
>
> In {{Analyzer}} :
> {code}
> /** Creates a TokenStream which tokenizes all the text in the provided
>     Reader.  Default implementation forwards to tokenStream(Reader) for 
>     compatibility with older version.  Override to allow Analyzer to choose 
>     strategy based on document and/or field.  Must be able to handle null
>     field name for backward compatibility. */
>   public abstract TokenStream tokenStream(String fieldName, Reader reader);
> {code}
> and in {{FrenchAnalyzer}}
> {code}
> public final TokenStream tokenStream(String fieldName, Reader reader) {
>     if (fieldName == null) throw new IllegalArgumentException("fieldName must not be null");
>     if (reader == null) throw new IllegalArgumentException("reader must not be null");
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-1359) FrenchAnalyzer's tokenStream method does not honour the contract of Analyzer

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir resolved LUCENE-1359.
---------------------------------

    Resolution: Fixed

Committed revision 828298.

this inconsistency annoyed me too.

thanks Andrew!

> FrenchAnalyzer's tokenStream method does not honour the contract of Analyzer
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-1359
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1359
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Analysis
>    Affects Versions: 2.2
>            Reporter: Andrew Lynch
>            Assignee: Robert Muir
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: LUCENE-1359.patch
>
>
> In {{Analyzer}} :
> {code}
> /** Creates a TokenStream which tokenizes all the text in the provided
>     Reader.  Default implementation forwards to tokenStream(Reader) for 
>     compatibility with older version.  Override to allow Analyzer to choose 
>     strategy based on document and/or field.  Must be able to handle null
>     field name for backward compatibility. */
>   public abstract TokenStream tokenStream(String fieldName, Reader reader);
> {code}
> and in {{FrenchAnalyzer}}
> {code}
> public final TokenStream tokenStream(String fieldName, Reader reader) {
>     if (fieldName == null) throw new IllegalArgumentException("fieldName must not be null");
>     if (reader == null) throw new IllegalArgumentException("reader must not be null");
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1359) FrenchAnalyzer's tokenStream method does not honour the contract of Analyzer

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-1359:
--------------------------------

    Lucene Fields: [New, Patch Available]  (was: [New])
    Fix Version/s: 3.0
         Assignee: Robert Muir

> FrenchAnalyzer's tokenStream method does not honour the contract of Analyzer
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-1359
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1359
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Analysis
>    Affects Versions: 2.2
>            Reporter: Andrew Lynch
>            Assignee: Robert Muir
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: LUCENE-1359.patch
>
>
> In {{Analyzer}} :
> {code}
> /** Creates a TokenStream which tokenizes all the text in the provided
>     Reader.  Default implementation forwards to tokenStream(Reader) for 
>     compatibility with older version.  Override to allow Analyzer to choose 
>     strategy based on document and/or field.  Must be able to handle null
>     field name for backward compatibility. */
>   public abstract TokenStream tokenStream(String fieldName, Reader reader);
> {code}
> and in {{FrenchAnalyzer}}
> {code}
> public final TokenStream tokenStream(String fieldName, Reader reader) {
>     if (fieldName == null) throw new IllegalArgumentException("fieldName must not be null");
>     if (reader == null) throw new IllegalArgumentException("reader must not be null");
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1359) FrenchAnalyzer's tokenStream method does not honour the contact of Analyzer

Posted by "Andrew Lynch (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Lynch updated LUCENE-1359:
---------------------------------

          Component/s: Analysis
    Affects Version/s: 2.2

> FrenchAnalyzer's tokenStream method does not honour the contact of Analyzer
> ---------------------------------------------------------------------------
>
>                 Key: LUCENE-1359
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1359
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Analysis
>    Affects Versions: 2.2
>            Reporter: Andrew Lynch
>
> In {{Analyzer}} :
> {code}
> /** Creates a TokenStream which tokenizes all the text in the provided
>     Reader.  Default implementation forwards to tokenStream(Reader) for 
>     compatibility with older version.  Override to allow Analyzer to choose 
>     strategy based on document and/or field.  Must be able to handle null
>     field name for backward compatibility. */
>   public abstract TokenStream tokenStream(String fieldName, Reader reader);
> {code}
> and in {{FrenchAnalyzer}}
> {code}
> public final TokenStream tokenStream(String fieldName, Reader reader) {
>     if (fieldName == null) throw new IllegalArgumentException("fieldName must not be null");
>     if (reader == null) throw new IllegalArgumentException("reader must not be null");
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1359) FrenchAnalyzer's tokenStream method does not honour the contract of Analyzer

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-1359:
--------------------------------

    Attachment: LUCENE-1359.patch

> FrenchAnalyzer's tokenStream method does not honour the contract of Analyzer
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-1359
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1359
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Analysis
>    Affects Versions: 2.2
>            Reporter: Andrew Lynch
>            Priority: Minor
>         Attachments: LUCENE-1359.patch
>
>
> In {{Analyzer}} :
> {code}
> /** Creates a TokenStream which tokenizes all the text in the provided
>     Reader.  Default implementation forwards to tokenStream(Reader) for 
>     compatibility with older version.  Override to allow Analyzer to choose 
>     strategy based on document and/or field.  Must be able to handle null
>     field name for backward compatibility. */
>   public abstract TokenStream tokenStream(String fieldName, Reader reader);
> {code}
> and in {{FrenchAnalyzer}}
> {code}
> public final TokenStream tokenStream(String fieldName, Reader reader) {
>     if (fieldName == null) throw new IllegalArgumentException("fieldName must not be null");
>     if (reader == null) throw new IllegalArgumentException("reader must not be null");
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1359) FrenchAnalyzer's tokenStream method does not honour the contract of Analyzer

Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Otis Gospodnetic updated LUCENE-1359:
-------------------------------------

    Summary: FrenchAnalyzer's tokenStream method does not honour the contract of Analyzer  (was: FrenchAnalyzer's tokenStream method does not honour the contact of Analyzer)

> FrenchAnalyzer's tokenStream method does not honour the contract of Analyzer
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-1359
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1359
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Analysis
>    Affects Versions: 2.2
>            Reporter: Andrew Lynch
>
> In {{Analyzer}} :
> {code}
> /** Creates a TokenStream which tokenizes all the text in the provided
>     Reader.  Default implementation forwards to tokenStream(Reader) for 
>     compatibility with older version.  Override to allow Analyzer to choose 
>     strategy based on document and/or field.  Must be able to handle null
>     field name for backward compatibility. */
>   public abstract TokenStream tokenStream(String fieldName, Reader reader);
> {code}
> and in {{FrenchAnalyzer}}
> {code}
> public final TokenStream tokenStream(String fieldName, Reader reader) {
>     if (fieldName == null) throw new IllegalArgumentException("fieldName must not be null");
>     if (reader == null) throw new IllegalArgumentException("reader must not be null");
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org